From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81E44606A33F for ; Tue, 20 Oct 2026 11:24:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=tf3mbr1z; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=WP8OiJFd DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rS0U0BV3DlzyKW7Kj88bDcmzdStC3ZIRD4+CLnMasSU=; b=tf3mbr1zmdwUoWHN8zUydtBw0P vJTpaRKFKwUxRBUXYvrHlT2f42sWjhVtF9MLepLJw7jdwgve/BLEuELT6U+He0GO15mylLTWRpij9 GdHulDE2bjRi8sZI/ugTusTns07hcZBuRQeWjhbhj0ynEkgcU3j6/qR5U39lzVK8uBgVDahJ0kQnH QRE0wIu3TBWKIK8wW/BdC1/O2RdOVgwjSCXqzV/8L38F8PMi6T6rIVn8lqeZU+E3v0zyubBEaMBdI aA6Sy3dIXHp8hbh5z+vflO5Qb+rxcCsXApnR7omDaMOmWi5dK/Rl/05lVvNt5bp+a/m820wksqFon iX05cRew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJ7xC-00000009XAD-3IOo; Tue, 20 Oct 2026 11:24:26 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJ7xB-00000009X9r-0YdV for linux-arm-kernel@lists.infradead.org; Tue, 20 Oct 2026 11:24:25 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 8D07E60136; Tue, 20 Oct 2026 11:24:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DE281F000C4; Tue, 20 Oct 2026 11:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792495464; bh=rS0U0BV3DlzyKW7Kj88bDcmzdStC3ZIRD4+CLnMasSU=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=WP8OiJFdpLbJ8qGweqWco5i6gVn8/RAtNYIdKbhlEtztn4gcf6fA9X+8/b5vVsQtW ke5bpdj3Ox8rt2qn0BvwEeEgdjCjxeGjJTr2Ny+j4EBnHseTEx6Y7ksVMRafRbCisg 3zT9RBtVnoUKXGzFtps8taluj2CgHMJSpCZo1k3SO+Zmigo72sO/w0FlHTlO+KEVf/ FhYzzTSDPlWXZkmhmG4SYaKA4p7O0+wOHvzC3sQmsAyrMabRI7xt8/kiq1R4NrPzYC ys9/EEXYuGrD/PhgIXCocxyDYSDG8RGFhJLPp6Ngnk9bnrq1YLwaY6wNh5UmzVAxRr Pg96BEGW3k2Ww== Message-ID: Date: Tue, 20 Oct 2026 13:22:45 +0200 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/10] dt-bindings: pinctrl: Add devicetree bindings for DM816x SoC Pinctrl To: Ettore Chimenti , Paul Walmsley , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Russell King , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Christopher Obbard , Andrew Goodbody , Linus Walleij , Rouven Czerwinski Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org References: <20261016-patch-ektor5-dm8168-dts-v1-0-b4ce30217028@linaro.org> <20261016-patch-ektor5-dm8168-dts-v1-2-b4ce30217028@linaro.org> <46414ff2-1273-4690-9001-4d1f825d8cf6@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 20/10/2026 12:18, Ettore Chimenti wrote: > Hi Krzyszrof, > > On Mon Oct 19, 2026 at 8:46 AM CEST, Krzysztof Kozlowski wrote: >> On 16/10/2026 17:07, Ettore Chimenti wrote: >>> Hi Krzyszrof, >>> >>> On Fri Oct 16, 2026 at 4:51 PM CEST, Krzysztof Kozlowski wrote: >>>> On 16/10/2026 16:41, Ettore Chimenti wrote: >>>>> Add devicetree bindings for TI DM816x SoC pinctrl configuration. >>>>> Using same definition as OMAP2/3 except pullup/down enable macros, which >>>>> are inverted in this SoC. >>>>> >>>>> Signed-off-by: Ettore Chimenti >>>>> --- >>>>> include/dt-bindings/pinctrl/dm816x.h | 20 ++++++++++++++++++++ >>>>> 1 file changed, 20 insertions(+) >>>>> >>>>> diff --git a/include/dt-bindings/pinctrl/dm816x.h b/include/dt-bindings/pinctrl/dm816x.h >>>>> new file mode 100644 >>>>> index 000000000000..15aa15bca9bd >>>>> --- /dev/null >>>>> +++ b/include/dt-bindings/pinctrl/dm816x.h >>>>> @@ -0,0 +1,20 @@ >>>>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>>>> +/* >>>>> + * This header provides constants specific to DM816X pinctrl bindings. >>>>> + */ >>>>> + >>>>> +#ifndef _DT_BINDINGS_PINCTRL_DM816X_H >>>>> +#define _DT_BINDINGS_PINCTRL_DM816X_H >>>>> + >>>>> +#include >>>> >>>> I do not see this being used here, IWYU. >>>> >>>>> + >>>>> +#undef PULL_UP >>>>> +#undef PULL_ENA >>>> >>>> Why are you undefining other macros? That's not a easy to follow code. >>> >>> Do you prefer to duplicate `omap.h` defines? Only the defines above do not >>> apply to DM816x. >> >> Not sure what you need to duplicate, but if you add header with bindings >> for this device, then you should not include headers for other devices. > > I basically used dm814x.h as a template which does that, is that not > correct? > >> >>> >>>> >>>> >>>>> + >>>>> +/* DM81xx mux bit defines */ >>>>> +#define PULL_ENA (0 << 3) /* Pullup enabled => 0 */ >>>>> +#define PULL_DIS (1 << 3) /* Pullup disabled => 1 */ >>>>> +#define PULL_DN (0 << 4) >>>>> +#define PULL_UP (1 << 4) >>>> >>>> I do not see this used by drivers, so why do we need one more header? >>>> What part of SW are you binding here? >>>> >>> >>> I added those (DN/UP) because they are not defined in `omap.h`. It may be >>> convenient for future board upstreaming. I can drop those if undesired. >> >> Just add the header to proper place - DTS. These are just not looking as >> bindings. > > Sorry, does dm814x.h not look as bindings? I'm a bit confused. I asked which part of SW are you binding. There was no answer, but question. So if you cannot point which part of software you bind, then we can assume it is not a binding. I did not do any extensive look, because I assume that contributor will bring the argument in favor of their patch, not me. > FWIW, dm8148-evm.dts is not including the header, dm814x.dtsi is. > Following > > Basically PULL_ENA define in omap.h is wrong for DM8168 SoCs. > > For a better solution, you would prefer: > - Keep omap.h in dm816x.dtsi > - Add a variant like DM816X_PULL_{ENA,DIS} in dm816x.h > - Replace defines in dm8168-evm.dts > - Add the header in dm8168-evm.dts > > or: > > - Keep omap.h in dm816x.dtsi > - Add a variant like DM816X_PULL_{ENA,DIS} in omap.h > - Replace defines in dm8168-evm.dts I gave you one idea, but feel free to implement it in other ways aligned with that platform maintainer. Best regards, Krzysztof