From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AD9AC4321E for ; Sun, 27 Nov 2022 13:12:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bg4+I0tgRwrqfyly8HZBuTpLtdEzfBp1Vlh9PpqSsH8=; b=hBrjobiR00xOvV lRsqv2RLP2lwpOZ4eIC51d5BXyFnGWT6UrRAZIg2xP/h8hmer+/Q+/6BJqzJ12CkCabxntMq5ZLEe jSwUP+rFMWbXg0zhK8g69Hs0PbzPbGPZ1lxn4EvsbFHr0ZBJGXtMi3FC/aDPO/54KSbV8Pcr6vLpp APwlhJaNZg9jXjA0h65UhxBCh+1TtOUc5HyIt25UJvdXKwNpCVMHeqAAmQKmAhKOQ434PjS87yx3S /vqsqu51VoGn6wQtsfKf3cqLyZFmE+f5ZZJQtOr0SzQirOHDiJ1ewpQmzm7aZeazYtXpescqnP9H6 ystKJTowdhs9MTWqA5tA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozHRv-00BLlc-3b; Sun, 27 Nov 2022 13:11:59 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozHRp-00BLjh-MC for linux-arm-kernel@lists.infradead.org; Sun, 27 Nov 2022 13:11:57 +0000 Received: by mail-lj1-x229.google.com with SMTP id bn5so10252098ljb.2 for ; Sun, 27 Nov 2022 05:11:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lsGPEbguNLyXyXtQzAB2wJ4fId8JLFhyfl8o2yashtI=; b=Li8wQ2MQpsuNmifYz+kZPILDr2YWOgtE++hH3wSz9Z+uybeOrU6yyv7gDgyYRvZAao K/WQQAGYKTxeFyp2lJ6yr4rGmA62AyzdTDQm4qkyyfLXDGDhXUZkuiX1Y5upwCOru6Qp e/7iO2LdF0Yj03tAP9XKjVFAXFUeBkBP3MZZldlKmCRIha4elFm2h1HNfzjZFodGmwrH O3ValvaUQYKgnFAfzlfh59v2zqUkzcWEqXo5b2BkbyPRrhfXKtsHbgMNk17fZ96rkNd+ E4UUeYlbXU/owMrUuyd9fQ4Ly34fFLgYlskbnO5pey4cLlYW7Uyy5ugOkbR8jX7VNbpc ReHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lsGPEbguNLyXyXtQzAB2wJ4fId8JLFhyfl8o2yashtI=; b=psTAZg7F+JpywigQ/N0wA64UQkzsyMy50hLI6nwjT6jvgtmHKI+F2zJQPRVNhzFnh8 OKZN0KFugzS+BpGeQAP95AEFJU2IgJW4OdJYU7Pr6L954URGGnqnQKicVI3z+c3H4yit 2aThh/IdluYD4bQlFz5i86jA3MRw5/+d6gJuuP65i/Q/3Y00XxOpg0wxFHcd0Ohmg41x iR5i+phS7dXW4sF3A6D10y+wGoPAt9UIaf5qCYjg89Xlijk5RsUgUkmvzM4nCSCcNrMM +nLdtoOMsCzVCjMjPSaYNyZlpXSrBPfA8YshcAjEZo2EfWgxXJY/29K9rLMaa1cSojxN jkEA== X-Gm-Message-State: ANoB5plfQHg2NkiJtz1e/keDz4kTZWGP6YdsBzO4xJFkybgk4kKhUZHQ K25HhR4ikljep2zHrJr3v1ogdg== X-Google-Smtp-Source: AA0mqf7D55Zimr5WD3Ta5W+Zbl1zFVFSuDEI4UZ2hLZvj32iV1yJ3DkH5cOJNK3LtUi7drUUjwEUdA== X-Received: by 2002:a05:651c:198a:b0:277:6c67:1a7f with SMTP id bx10-20020a05651c198a00b002776c671a7fmr15712660ljb.133.1669554710421; Sun, 27 Nov 2022 05:11:50 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id bp29-20020a056512159d00b0048aee825e2esm1298537lfb.282.2022.11.27.05.11.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Nov 2022 05:11:49 -0800 (PST) Message-ID: Date: Sun, 27 Nov 2022 14:11:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v6 05/10] dt-bindings: soc: mediatek: convert pwrap documentation Content-Language: en-US From: Krzysztof Kozlowski To: Alexandre Mergnat , Krzysztof Kozlowski , Sean Wang , Rob Herring , Matthias Brugger , Chen Zhong , Fabien Parent , Alessandro Zummo , Mark Brown , Alexandre Belloni , Flora Fu , Tianping Fang , Pavel Machek , Lee Jones , Liam Girdwood , Dmitry Torokhov Cc: Mattijs Korpershoek , Rob Herring , AngeloGioacchino Del Regno , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Fabien Parent , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org References: <20221005-mt6357-support-v6-0-4f589756befa@baylibre.com> <20221005-mt6357-support-v6-5-4f589756befa@baylibre.com> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221127_051153_786640_92983828 X-CRM114-Status: GOOD ( 15.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/11/2022 14:04, Krzysztof Kozlowski wrote: > On 25/11/2022 16:10, Alexandre Mergnat wrote: >> - Convert soc/mediatek/pwrap.txt to soc/mediatek/mediatek,pwrap.yaml >> - Add syscon compatible const for mt8186 and mt8195 to match the DTS needs. >> >> + resets: >> + minItems: 1 >> + items: >> + - description: PMIC wrapper reset >> + - description: IP pairing reset >> + >> + reset-names: >> + minItems: 1 >> + items: >> + - const: pwrap >> + - const: pwrap-bridge >> + >> + pmic: >> + type: object > > What's here? Other schema? If not then maybe compatible? What about > description? I guess this was comment from Rob, so it's fine. > >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - interrupts >> + - clocks >> + - clock-names >> + >> +dependentRequired: >> + resets: [reset-names] > > Drop. > >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: mediatek,mt8365-pwrap >> + then: >> + properties: >> + clocks: >> + minItems: 4 >> + >> + clock-names: >> + minItems: 4 > > else: > ??? Actually this looks less complete than your previous patch. else: clocks: maxItems: 2 same for clock-names > >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + #include >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + pwrap@1000d000 { >> + compatible = "mediatek,mt8135-pwrap"; >> + reg = <0 0x1000f000 0 0x1000>, > > This does not match your unit address. No warnings when compile testing? > >> + <0 0x11017000 0 0x1000>; >> + reg-names = "pwrap", "pwrap-bridge"; >> + interrupts = ; >> + clocks = <&clk26m>, <&clk26m>; >> + clock-names = "spi", "wrap"; >> + resets = <&infracfg MT8135_INFRA_PMIC_WRAP_RST>, >> + <&pericfg MT8135_PERI_PWRAP_BRIDGE_SW_RST>; >> + reset-names = "pwrap", "pwrap-bridge"; > > Missing pmic. Make your example complete. Probably pmic should be skipped, I understand it is described in MFD binding. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel