From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE58BC4345F for ; Tue, 16 Apr 2024 07:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OgdGmjuxw/lHvFpqXS15ojdHAaxKK88wVAlcTDsrtw8=; b=jVKkd0J1HEnCmv n+pEhnoSKwj7NuXSYrGEsKZEUKktKkB2I6B940MzrnMt0xiWMe+5yj9FjN3M9nOV5uacSY8RfJzEV m2K0NFWzerx5P4+c43ufF03j9pj3nfn1h1U+IpwT70eVlIuejAkNQeIF3qwg3OiTS2yjr7Nov+oSV ULQnZbzu01R52n5SbGp46+Sv6rWl40vZ5+g3r1Ac/4ssOZq/nGLi8rwyWX5klNRCBN+arusH+WoLv R/1ftTKt8C/wjChZ9owXeoSxOiXP5ZcmdQ9O3p25nWm+VEM4DmGLFY4mPRPUgeEiKGeWbvRbJpdj1 jBug1AlkiUezH8qT1eOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwcrA-0000000BAQV-1WsC; Tue, 16 Apr 2024 07:03:52 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwcr3-0000000BAM2-0MiW; Tue, 16 Apr 2024 07:03:49 +0000 X-UUID: 748cd0aafbbf11ee96d5dfc950b7243d-20240416 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=s3OdwgS0tBf1B5SsriamF0uETDJic+KRgO9K7OxrSVw=; b=ovVX41XRLwQ2XP8ukPbXWl8lik23i+pZTQ3b2G4uRDzBHsVvehF6uVLzKBiJ5RYqjnOQxLx99ER09kOLx0csHEcyqjAI32tVCABfctw6+XFy4wZ63sMBbNctdU21MOebtudkirtfhT45oH8vE8GIL4LY33DhlL7oA4NdyFZaiiY=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.38,REQID:28fc30ef-0300-4e7a-a0b1-d2fb063cf880,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:82c5f88,CLOUDID:0a50f7fa-ed05-4274-9204-014369d201e8,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1, SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 748cd0aafbbf11ee96d5dfc950b7243d-20240416 Received: from mtkmbs09n1.mediatek.inc [(172.21.101.35)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 916010025; Tue, 16 Apr 2024 00:03:40 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS09N2.mediatek.inc (172.21.101.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 16 Apr 2024 00:03:14 -0700 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Tue, 16 Apr 2024 15:03:14 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XdeY49y948BHLNi7P8JsUVZlkTVaKlWkyhM6bzb8ugk8ulPrZQwjHb8G3C0+OKI2I1Ty/0YjUvFFS2xl3uNH4nbk3L0kg24ihF+Fi4KFYY+7F6C/Jbv6dsUmhyooiJaSL1+VgxjdGJ1HuhvSfhTy9PLRtqHKP6orWdWEzADtgmKvdejkDcwcCIkTX9FqaVWKUMvqdKawv9rnZFhlVDDKnMBPebGD8dGhJ9GrlFInRKotcXM5xIJgzMMD5LAY+lR6R6v9tpRgZaKmtHyfdap75c25URGCYE/4FSnJgW54M8s9AzjcX/SyzBDclCG7Uz5mapyE8VVlGX+lLriOcc5o6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s3OdwgS0tBf1B5SsriamF0uETDJic+KRgO9K7OxrSVw=; b=VlvClkVDjmLUE6OAob0fana7SQlwMDD0aXc6xlwStuzRRSgVST/VpmfTV6gBWHOREyfLmFgLmdc6Tk0JqiKkM98i4WdnKUC5TlHxVRVBNbyhkSakOSW6HLnN2GXBYNp2IyAmSjBzWVOsJR1JJCze/h71nI8tkNAPFsFKL5RyoCTAc9mcrlD+Po8i8bImaf8M4CfbZDo+uD+yO+8G/qpd2YFEhaPMZ5HBQuDsBkXX/kDt52erQ5ea6RkiPl/ygkAUG0o8YJhK4qhgCMUrxChAZBof6u345OOtySeWningRK7BoQYQr4x0ljS3/3wrcT/2XnbhOZWurPOES+FqH7fkrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3OdwgS0tBf1B5SsriamF0uETDJic+KRgO9K7OxrSVw=; b=B7uBmTHGuR4AuyyiNd12HxkiNRGza7dn5Ru3j5h/l48DtG8ygk5gbOo59RQFvSqp3tIg+PHaXUx71PjmcneCpMY64fIxm3P/uJG3eNygB7RGmHS5R1sh89+ZO8B3LerccQVXYkoyxyHGghFVObob4+1hN0WSdwMmsPfnXxaof1Y= Received: from PSAPR03MB5605.apcprd03.prod.outlook.com (2603:1096:301:66::6) by TY0PR03MB6452.apcprd03.prod.outlook.com (2603:1096:400:1bf::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Tue, 16 Apr 2024 07:03:12 +0000 Received: from PSAPR03MB5605.apcprd03.prod.outlook.com ([fe80::3945:7dbc:62bd:c31c]) by PSAPR03MB5605.apcprd03.prod.outlook.com ([fe80::3945:7dbc:62bd:c31c%7]) with mapi id 15.20.7452.049; Tue, 16 Apr 2024 07:03:12 +0000 From: =?utf-8?B?UGV0ZXIgV2FuZyAo546L5L+h5Y+LKQ==?= To: "linux-scsi@vger.kernel.org" , "angelogioacchino.delregno@collabora.com" CC: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "jejb@linux.ibm.com" , "devicetree@vger.kernel.org" , "avri.altman@wdc.com" , "bvanassche@acm.org" , "martin.petersen@oracle.com" , "broonie@kernel.org" , "alim.akhtar@samsung.com" , "conor+dt@kernel.org" , "robh@kernel.org" , "lgirdwood@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" Subject: Re: [PATCH v4 3/8] scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-boost-crypt property Thread-Topic: [PATCH v4 3/8] scsi: ufs: ufs-mediatek: Remove useless mediatek,ufs-boost-crypt property Thread-Index: AQHajyQsFRoxXt1vlE2SkQwxcZAltLFqegCA Date: Tue, 16 Apr 2024 07:03:11 +0000 Message-ID: References: <20240415110012.148871-1-angelogioacchino.delregno@collabora.com> <20240415110012.148871-4-angelogioacchino.delregno@collabora.com> In-Reply-To: <20240415110012.148871-4-angelogioacchino.delregno@collabora.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PSAPR03MB5605:EE_|TY0PR03MB6452:EE_ x-ms-office365-filtering-correlation-id: 7b7f0a9c-9101-415b-f351-08dc5de34792 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: =?utf-8?B?QVpXand4Nk9PZHZhZUJNOWkreHZva1Q4VTlyazNDeE96RnNWaHA0Z1lzUXgx?= =?utf-8?B?dE1EcVNFeTNhWlltTjJTczc1cEJyUGx5T2ZNWFZ4dmpGUWdhbHRwM0FRWjd6?= =?utf-8?B?MU1CN09hSlVNWlB3UmZQY2FqQkVTK1hTSG9lOVREcGMxZnpMaXBRQWU5VmtG?= =?utf-8?B?V05CelBSNUpncEtobmRiSDYrK0V3ZjBzdUprcHFUMm5WMmJSWVB2TFU1MkVY?= =?utf-8?B?VVUrcVVuRWxPZy9meEE0UTdFWUt6UGVDNTdWbHZyNWRpbWdmT0tBQTBqek1i?= =?utf-8?B?NHlqZzNKRWw0Nm9UZDBHWVFPbFYrYUN6YVE1eGNMT1lxK1RGTW5TUnMrQkxl?= =?utf-8?B?WDgvK0pWNzhHa0Y0RmtGSXlWUEcvWkJSQmVuZDFtSXBSRFNZTnBVK3BUcUVn?= =?utf-8?B?bDIxZTBYRlBiQjlLeThPcTJpdEEySXZqZHVDZmpCWk9XZXZUSXE1NlBseE5N?= =?utf-8?B?dXovZkNuTlluK3g0SnVCdUNIUXRxbG9OeHNNeVJwRkNSNXJleVJ2SmRpR2tJ?= =?utf-8?B?eUUvRGRHa2JtaXBmRnBobjRlQTFmWG54dXc3MDJxd2dYS2JiOE5ZbmtSeFRI?= =?utf-8?B?Z2FCcjVGbnRqMXFUVjAzSlFCWmIzbGptRjEzN0tsYzFKS2JWekU0SHB0SWZo?= =?utf-8?B?Ly8zVC94Tk9yVVNPQjFzMkZFOC8yQXBtcDhJVDZiK1hwSUN6MUsxMzd0c2lx?= =?utf-8?B?cDhEZnZweDZmam5hZFY3aUhZbGFPZDN2NW5MaFFzOHh0U1oxbjVqUkx0YkJU?= =?utf-8?B?NTZ6dWMzcnplTDhMSkducFd6N1JpMytFVHJ5L3ZOU0I1ait1a3lhZ2xiRlFl?= =?utf-8?B?NTV4ZkRMVmlMQmEwSU9iY2MvMDNqZ3dQTG94WGppZmhPRWdqT05odTFncEJZ?= =?utf-8?B?SW9ZQ3p0WlBuemI3TitTczlEYWdPeGVQcVZGTnk5RnJ5ZllZTW95c2VHdUFF?= =?utf-8?B?eXZzaWdsQm0wTHQ0dXVtQ1c2UXlqVlcvb1RpVTZwUkt0aWdNeko4aXhlZzc4?= =?utf-8?B?UXhYMGJDK3RVemlxYUNKMTJFd0xNQXQ4dmZPYzUxWm15VUJoV1VtMndQaHZh?= =?utf-8?B?dWRpRlZIN1ZkQmFKbG5aQ3BwRlBENTdETlVCTWpVdjdhM0JRRzc5SU1zMk81?= =?utf-8?B?OFhzOXNLSGUrekZTK0cyVWpaTnNvb3VyN0pDeGZjci9TQWN0SjB5bm55dXBp?= =?utf-8?B?MExBMnl6b3NXQWVpd3lRSWVkUXNMbFJOeWhzR3pYMjNGenZqSUF3Z3M4emd1?= =?utf-8?B?MXZZamQ4K1Iyc0V5ZWk0S3RWZXZ5ai9DU3R1T0c0V29oQmU2T0RocS9KQzVF?= =?utf-8?B?azFrWE02cnluOGNpYUFwRlN0QTRtYUN1UUR0bi8veU00WjJMNXMxUWUzQnJP?= =?utf-8?B?dXo4Yk52a1JkUXUwK3JVK1ZQK2JXWk4vdmRscFN4VHdTSGRCTUY0SUZrSEph?= =?utf-8?B?NHNHejg1RVBUdEJ1MU13MkxkbmsxVE1RY2hqcGdXQ1hJUE16SXEySGhQdTZL?= =?utf-8?B?cFR4QTk0Rkx3Tjc0SjdhMDl1N1RJdmVYTFBETDdVL1dzRUxCS0NLNk8rYjd5?= =?utf-8?B?NlJ5SlFTL0RVOGx0L1RhRDJoSGp1TFZnbjRqUWxQM1l0SDFYMEdEZnlCRHhw?= =?utf-8?B?K1J3UFg2VE5DUHN0a3lSb0FPbEdKaUxnSUJBcE1pVmlOVHlDOWR0Y280QW44?= =?utf-8?B?cFRIYUJxamtJL2Q2ZTY5b0o1VVVidkJmNVVQc05PUzFuZTdDOHlJYkoxU1lJ?= =?utf-8?B?RGFuV0lUeDVqVFAxUUpoVGF5Sld0WHVDbUFuZFJyVU5qdzc3OGNreVppaUFn?= =?utf-8?B?cW92S2xMdzI5bThuU3RJQT09?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PSAPR03MB5605.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(376005)(1800799015)(366007)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bjcwWnV6RmtUZC90QXNGKzIyeGlLWVNVbEM1akovVFhRTzN4RndCZzF3QU5M?= =?utf-8?B?aGpMM25sUXJyTEFYTjh2bjljdFRGTkg2SGdDb2MyR0E0RUh0VU5pK0dFWUdz?= =?utf-8?B?MVBLNGdJSnFMUXE1elRPeGp4WllsWjVhU2pFRUwwTGlPZHdsRTNDajljTFRa?= =?utf-8?B?UlYyN2hDOEJXRFQ4QjJyUHNnY2ZKZE1VNlFtVmo5djJPSEVsRkVmTW9YbXdP?= =?utf-8?B?RzZmaCs2dUdla3c5ZTN4Njh6OFJndzQ2eGVYcGNmK3ZLSmZWTUNmcmtDNCtl?= =?utf-8?B?U1F3UENta3p1M0FlQlZraTZRZ3RKQ0pQbGU3Wk1EYUlpR3J4aWZWcWJSR2Z6?= =?utf-8?B?S2NSS0ptYnBlL3h1NG5DWjU3aDZ6OEIzc1oybTEzZkpyOXJrM2VpaUN3SnhL?= =?utf-8?B?U0k3UGovTWJzT2Vqc2g1bDI1dmxpdGVENUU2SzlSeWJvQ2RxN0VCaEZuMGgy?= =?utf-8?B?MWNqSWxnUHd2Uk94Nk5MUkFFYzdZUHlwL0NPaUhWTWo2Nmsyb3hUWW9YS3Z0?= =?utf-8?B?SEw0QzRwcHpxQXpzTytSVXAvZFIrNEpoNzBvaER3SEVTUU5NTDlEMmtVejNk?= =?utf-8?B?QWlXTmxERDNOdmMyVXBqYVY5amlVUDJraVIzNEc1L2toREIxVHFqeDIzWENQ?= =?utf-8?B?dlpvU01wcFQ0M1pIdEc1QW9KWXRkSFBiNjIwQTVSMXM2QlZKMmFTYTZaOXBK?= =?utf-8?B?WXhtR0c0YkRxSEdjWmR3UWc4UlZ1cHkvZG0xaStidU5MU0w5LzZWYUVjYUk1?= =?utf-8?B?NFY2a1J1Q3FDeExhRDQyUWtRWDBXajRmalFRZ0xUM2hPSlZZbHZneWk0UEdp?= =?utf-8?B?dTVqMWljd1VwOGJDTVJ2dXMwdVNUY2plb3VaK2U3RU9HaWdqWHVsUUVQWkJt?= =?utf-8?B?U08rTjM0WnZjRGZUQ1ZrNlVGSU11MlZjKy9heDNzbU9lRncyQlFxaGRPU0hQ?= =?utf-8?B?NzBXVnRpSFFFZXZBMytSc0UyUFRrY1BNSEVkZTVyOTNFN3lxQXE5RkhsS1dG?= =?utf-8?B?QlBIZHVuY2Jhc0dmRWlJRys3MCtYSVp3ZE85OW5QakhQd0RlNnFMQk1yUlFX?= =?utf-8?B?c1pCcHd4Wk5GUURSQWNJVVdvVEIwMUQ1dGMrM3c4djZYNllweEdnNGZBVzdx?= =?utf-8?B?NFNZeEIyMWNSNGFISlFOUnNTN2RIbklOK1ZIeFg4RFVlbzNYZ3lmZDk2YnJD?= =?utf-8?B?NUVMclh4TnVWdy9VdVl0dFJzSFc3dHRLdzJROUVyM0t6QXRRcDJjbG4rVTlR?= =?utf-8?B?R1YzbEY1TkEreVdNUzF2em9sQUlYd0FKYjIydlV6SEt2VG51OGNvcUhHMHF0?= =?utf-8?B?a09KU2JQT21tSDUxN1hZdnJlVXhMZmczRkdOZ2FQNVBza0prNDFNdmtDNEh0?= =?utf-8?B?dlpuQnNhUENKV1B1QmNKaVY4WjFrR215UkNmcnFDS0VwT0Y2NWllUnorR0xw?= =?utf-8?B?bU1LT2VNUHdQajA1ZXRrZUdxS25SZnNleG5Ebk9KWk1RVmIyTjdmR3FXbkZF?= =?utf-8?B?N29jTW81Z2d6aXNxVjlNd1ViRDhISEwreGsrV3ExczhTRVgzMXNSNVRxektB?= =?utf-8?B?bTJaUVhIWlVYaGp3eWFDb3dEYXJZRzVJcXFJYXIwaFQ5QlVBVnQzZXdhY3kx?= =?utf-8?B?NUxid3g1TWUyaHR5U3RONll3TWZoMUNtWmdjcFNabk9KTlJDVnpscnNVSnFJ?= =?utf-8?B?aVRxKzdwN1lvZzFCNUlWM2ZtYmp1bHVtN1JUaWROTnBZd2F5MEZ1SVVnMFpy?= =?utf-8?B?ZkVFQjEyUFRXbUowQ3dlSEVrQ1Q0a0gyeDZBbWVYMkw1ZWZQUWVPVUcwbHF5?= =?utf-8?B?NWt2UXNpOTRMeit5RGJqYVVCVGd0Y2tqMlhuR0tNTVFDZU5wUEhaN3JXdWlw?= =?utf-8?B?OU4zL3VnTjNoOTR6V09aRGZLbFd0ZTRaaHVmM24vVTRSSTBvakMwYnVKVmti?= =?utf-8?B?TDg4dWFFb01MYmhwbEl3Y2srWEJjUDRobVpoYlRleVNETlh1SlRrQnBtbzJS?= =?utf-8?B?bWp4MWVNOUh6U012U2dsOGttQTJ6Z1Z6TXBFK2NUaHNiQTYwN0tNOTNxbU16?= =?utf-8?B?RndLQTAyK0hSZVVwOXhtM1hFNnFlZUhIUmV5NlJkaTlOK1lWYldUclpESlV0?= =?utf-8?B?R2ZhNmF5V2cvQkZobVE5eGp6MFMyTFZyYml5MDBWK2pkL2RXajdTMnI5Zm9D?= =?utf-8?B?ZWc9PQ==?= Content-ID: <828E864B9647C445B6DA8D619EA2F0B5@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PSAPR03MB5605.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b7f0a9c-9101-415b-f351-08dc5de34792 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 07:03:11.9279 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZDOGsURNkbpQ2JoLAjB58QK2pPnr895axuBNoXWm41lhZ5yfKaKjXgzylaGW3gg0l457q/7i7+bgspS66vUG2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR03MB6452 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_000345_168689_4C2ADC2C X-CRM114-Status: GOOD ( 27.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2024-04-15 at 13:00 +0200, AngeloGioacchino Del Regno wrote: > There is no need to have a property that activates the inline crypto > boost feature, as this needs many things: a regulator, three clocks, > and the mediatek,boost-crypt-microvolt property to be set. > > If any one of these is missing, the feature won't be activated, > hence, it is useless to have yet one more property to enable that. > > While at it, also address another two issues: > 1. Give back the return value to the caller and make sure to fail > probing if we get an -EPROBE_DEFER or -ENOMEM; and > 2. Free the ufs_mtk_crypt_cfg structure allocated in the crypto > boost function if said functionality could not be enabled because > it's not supported, as that'd be only wasted memory. > > Last but not least, move the devm_kzalloc() call for > ufs_mtk_crypt_cfg > to after getting the dvfsrc-vcore regulator and the boost microvolt > property, as if those fail there's no reason to even allocate that. > > Fixes: ac8c2459091c ("scsi: ufs-mediatek: Decouple features from > platform bindings") > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/ufs/host/ufs-mediatek.c | 55 ++++++++++++++++++------------- > -- > 1 file changed, 30 insertions(+), 25 deletions(-) > > diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs- > mediatek.c > index 688d85909ad6..47f16e6720f4 100644 > --- a/drivers/ufs/host/ufs-mediatek.c > +++ b/drivers/ufs/host/ufs-mediatek.c > @@ -575,51 +575,55 @@ static int ufs_mtk_init_host_clk(struct ufs_hba > *hba, const char *name, > return ret; > } > > -static void ufs_mtk_init_boost_crypt(struct ufs_hba *hba) > +static int ufs_mtk_init_boost_crypt(struct ufs_hba *hba) > { > struct ufs_mtk_host *host = ufshcd_get_variant(hba); > struct ufs_mtk_crypt_cfg *cfg; > struct device *dev = hba->dev; > struct regulator *reg; > u32 volt; > - > - host->crypt = devm_kzalloc(dev, sizeof(*(host->crypt)), > - GFP_KERNEL); > - if (!host->crypt) > - goto disable_caps; > + int ret; > > reg = devm_regulator_get_optional(dev, "dvfsrc-vcore"); > if (IS_ERR(reg)) { > - dev_info(dev, "failed to get dvfsrc-vcore: %ld", > - PTR_ERR(reg)); > - goto disable_caps; > + ret = PTR_ERR(reg); > + if (ret == -EPROBE_DEFER) > + return ret; > + > + return 0; > } > > - if (of_property_read_u32(dev->of_node, "mediatek,boost-crypt- > microvolt", > - &volt)) { > + ret = of_property_read_u32(dev->of_node, "mediatek,boost-crypt- > microvolt", &volt); > + if (ret) { > dev_info(dev, "failed to get mediatek,boost-crypt- > microvolt"); > - goto disable_caps; > + return 0; > } > > + host->crypt = devm_kzalloc(dev, sizeof(*host->crypt), > GFP_KERNEL); > + if (!host->crypt) > + return -ENOMEM; > + > Hi Angelo, If retrun -ENOMEN, host will init fail. But previous is skip boost crypt feature only. It change the driver behavior. > cfg = host->crypt; > - if (ufs_mtk_init_host_clk(hba, "crypt_mux", > - &cfg->clk_crypt_mux)) > - goto disable_caps; > + ret = ufs_mtk_init_host_clk(hba, "crypt_mux", &cfg- > >clk_crypt_mux); > + if (ret) > + goto out; > > - if (ufs_mtk_init_host_clk(hba, "crypt_lp", > - &cfg->clk_crypt_lp)) > - goto disable_caps; > + ret = ufs_mtk_init_host_clk(hba, "crypt_lp", &cfg- > >clk_crypt_lp); > + if (ret) > + goto out; > > - if (ufs_mtk_init_host_clk(hba, "crypt_perf", > - &cfg->clk_crypt_perf)) > - goto disable_caps; > + ret = ufs_mtk_init_host_clk(hba, "crypt_perf", &cfg- > >clk_crypt_perf); > + if (ret) > + goto out; > > cfg->reg_vcore = reg; > cfg->vcore_volt = volt; > host->caps |= UFS_MTK_CAP_BOOST_CRYPT_ENGINE; > > -disable_caps: > - return; > +out: > + if (ret) > + devm_kfree(dev, host->crypt); > + return 0; > } > > static int ufs_mtk_init_va09_pwr_ctrl(struct ufs_hba *hba) > @@ -648,8 +652,9 @@ static int ufs_mtk_init_host_caps(struct ufs_hba > *hba) > struct device_node *np = hba->dev->of_node; > int ret; > > - if (of_property_read_bool(np, "mediatek,ufs-boost-crypt")) > - ufs_mtk_init_boost_crypt(hba); > + ret = ufs_mtk_init_boost_crypt(hba); > + if (ret) > + return ret; > Most ufs-mediatek platform dosen't need "mediatek,ufs-boost-crypt" Remove this property will casue most platform try error and add init latency. Thanks. Peter > ret = ufs_mtk_init_va09_pwr_ctrl(hba); > if (ret) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel