From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0C62D2069C for ; Wed, 16 Oct 2024 14:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3XoQGpvLTfLi0/g6YUJeL26pge1uY+/1NVcT43Kbq+4=; b=H7vqUU/Tpqk97U4Iv5Z+R789uY L+T/NfdXuPDkUru9LiPXiq1lIDO3Td+HUvwcTv1B1r+XseXo02f/cRdYvXFTXckHoD8M3y43AJssp 2Ft2BI7ZV/fuOigGxnxAP9selwkINH/0kDtVf5eRE/c4SR7vwvcqXikYfyJPiRmGpizSnvdmXixdV y+pq0GTgh8D9sMohj9cGXdpyyC3vW5Q3jy5Yrtd+SNwFVMjhJd0vm82ZIDktWDjPMibbwuX4onB+J 9qLx9U5e6rZdfaF1UZdVtcgKJXMh+vR8hVsuuGXUDGSh0H0602ssD1rv2ybwCJeTXHENhDFNu9WAW +nHf3Jqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t14st-0000000C3Vs-0KHq; Wed, 16 Oct 2024 14:20:19 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t14rM-0000000C33a-3gTM for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2024 14:18:46 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4311420b675so61702655e9.2 for ; Wed, 16 Oct 2024 07:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1729088322; x=1729693122; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3XoQGpvLTfLi0/g6YUJeL26pge1uY+/1NVcT43Kbq+4=; b=o6t0cO1c0l4bTf8UkekrRcQ8qUNI6vWBcSFbGrvZDPa2XL562qlW11mzAxtxdXCioM 6RD68EsM/aDclyp3Bp66jZ2C/N+Mx4KqpGwLFTK7hUWRsXcv4NC23HLtnqdAWgOEQbPy AO3tuNKx/I95QkdlcI9774B9je2Vwtldeog0TNcwCpryjFc0DF/Mtcafodli/dkmAiyP 3HHxJMUFF+vMO/7l5/+xC9xag3kth+/INRt4UP9m+AorSfmInvniNQuqL6ScGETpiLPq yFJT+yWzQ+8Z72FYad1KEieyqCCv31XburxyU2VyaYQ1TSdGiiLg/wfgN50lpqyOiBiy WB8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729088322; x=1729693122; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3XoQGpvLTfLi0/g6YUJeL26pge1uY+/1NVcT43Kbq+4=; b=G0t54iM3j9VCL2k3kdNjRFzcxxobBh96sVFoZouf8vbGsi3rfh8NTU+BR0/sKg2AXn vxq+DdMDIdxE6BUj+ZH8Y4jp3IBqky6vE7mciz0zTahZ7t+phGMCkLTjHLj9rP+h+keQ /weR1/ZOX75brWc1QMdkVL2Mi527FdaPvVBODDDtS7D6kcVZH3/GsNzwVR/EodPEooGg H63MoBsQWtawq/XUBPK6TivgWI494ron/2VSn3x+RCrujcfI+xNecjM3JiPQFrZkCs/E eOkyzVS9K5MrZilKQCRPjUkGiOtaFVVM/Q2zJWaBTrmDxjztJeMrLpcs9rBuhN4GZEj4 R0KA== X-Gm-Message-State: AOJu0YxcM8jDoa8Z9rG+pCoLzIreBJed9r/RRXYb3GuW3q0bbXeYVPK2 zb+XjCQkPpaLcirIvVYy1WUFb+9m/mxecFcw2mCWJR4mJ2h6gw17wRabhomOsVg= X-Google-Smtp-Source: AGHT+IEAfMKrn9wpk7nbCLL6ykIc+NzLxYsdeNcKIupA23puzEsIaJX9RrEu5Oe3VrdfX6gLSI8yvw== X-Received: by 2002:a05:600c:4f83:b0:42e:75a6:bb60 with SMTP id 5b1f17b1804b1-4314a322492mr32469155e9.19.1729088322293; Wed, 16 Oct 2024 07:18:42 -0700 (PDT) Received: from ?IPV6:2a05:6e02:10a5:e010:a9c0:1c6c:5427:e89d? ([2a05:6e02:10a5:e010:a9c0:1c6c:5427:e89d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d7faa4085sm4448154f8f.65.2024.10.16.07.18.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2024 07:18:41 -0700 (PDT) Message-ID: Date: Wed, 16 Oct 2024 16:18:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] irqchip: Kconfig: module build support for the TI interrupt router driver To: Andrew Davis , Catalin Marinas , Will Deacon , Thomas Gleixner , Nishanth Menon , Tero Kristo , Santosh Shilimkar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, vishalm@ti.com, Mattijs Korpershoek , Kevin Hilman , Nicolas Frayer References: <20241016-timodules-v3-0-fa71091ade98@baylibre.com> <20241016-timodules-v3-1-fa71091ade98@baylibre.com> <95b85e47-8554-430b-b878-e6045d8f6871@ti.com> Content-Language: en-US From: Guillaume LA ROQUE In-Reply-To: <95b85e47-8554-430b-b878-e6045d8f6871@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241016_071844_943081_95BEA388 X-CRM114-Status: GOOD ( 18.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, Le 16/10/2024 à 15:37, Andrew Davis a écrit : > On 10/16/24 4:41 AM, Guillaume La Roque wrote: >> From: Nicolas Frayer >> >> Added module build support in Kconfig for the TI SCI interrupt router >> driver >> >> Signed-off-by: Nicolas Frayer >> Signed-off-by: Guillaume La Roque >> --- >>   arch/arm64/Kconfig.platforms      | 1 - >>   drivers/irqchip/Kconfig           | 3 ++- >>   drivers/irqchip/irq-ti-sci-intr.c | 1 + >>   3 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >> index 6c6d11536b42..393845a3ae5c 100644 >> --- a/arch/arm64/Kconfig.platforms >> +++ b/arch/arm64/Kconfig.platforms >> @@ -135,7 +135,6 @@ config ARCH_K3 >>       select SOC_TI >>       select TI_MESSAGE_MANAGER >>       select TI_SCI_PROTOCOL >> -    select TI_SCI_INTR_IRQCHIP >>       select TI_SCI_INTA_IRQCHIP >>       select TI_K3_SOCINFO >>       help >> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig >> index 341cd9ca5a05..a958731404e9 100644 >> --- a/drivers/irqchip/Kconfig >> +++ b/drivers/irqchip/Kconfig >> @@ -533,9 +533,10 @@ config LS1X_IRQ >>         Support for the Loongson-1 platform Interrupt Controller. >>     config TI_SCI_INTR_IRQCHIP >> -    bool >> +    tristate "TI SCI INTR Interrupt Controller" > > Although not needed, might be good to gate this on ARCH_K3 > as it only makes sense to add when K3 is an enabled platform. Actually if ARCH_K3 is not selected it's not possible to enable TI IRQCHIP driver from menuconfig so depends look good or do you want to have when i select irqchip driver ARCH_K3 is enabled ? > Then add on compile test support: > > depends on ARCH_K3 || COMPILE_TEST > i will add in v4. thanks for review Guillaume > Andrew > >>       depends on TI_SCI_PROTOCOL >>       select IRQ_DOMAIN_HIERARCHY >> +    default ARCH_K3 >>       help >>         This enables the irqchip driver support for K3 Interrupt router >>         over TI System Control Interface available on some new TI's >> SoCs. >> diff --git a/drivers/irqchip/irq-ti-sci-intr.c >> b/drivers/irqchip/irq-ti-sci-intr.c >> index c027cd9e4a69..b49a73106c69 100644 >> --- a/drivers/irqchip/irq-ti-sci-intr.c >> +++ b/drivers/irqchip/irq-ti-sci-intr.c >> @@ -303,3 +303,4 @@ >> module_platform_driver(ti_sci_intr_irq_domain_driver); >>     MODULE_AUTHOR("Lokesh Vutla "); >>   MODULE_DESCRIPTION("K3 Interrupt Router driver over TI SCI protocol"); >> +MODULE_LICENSE("GPL"); >>