From: David Laight <David.Laight@ACULAB.COM>
To: 'Yunfeng Ye' <yeyunfeng@huawei.com>, Sudeep Holla <sudeep.holla@arm.com>
Cc: "kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"hushiyuan@huawei.com" <hushiyuan@huawei.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linfeilong@huawei.com" <linfeilong@huawei.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"wuyun.wu@huawei.com" <wuyun.wu@huawei.com>,
"will@kernel.org" <will@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH V2] arm64: psci: Reduce waiting time of cpu_psci_cpu_kill()
Date: Thu, 17 Oct 2019 14:00:42 +0000 [thread overview]
Message-ID: <c97c87b52f474463bc30ff8033a57e0c@AcuMS.aculab.com> (raw)
In-Reply-To: <0f550044-9ed2-5f72-1335-73417678ba45@huawei.com>
From: Yunfeng Ye
> Sent: 17 October 2019 14:26
...
> >> - for (i = 0; i < 10; i++) {
> >> + i = 0;
> >> + timeout = jiffies + msecs_to_jiffies(100);
> >> + do {
> >> err = psci_ops.affinity_info(cpu_logical_map(cpu), 0);
> >> if (err == PSCI_0_2_AFFINITY_LEVEL_OFF) {
> >> pr_info("CPU%d killed.\n", cpu);
> >> return 0;
> >> }
> >>
> >> - msleep(10);
> >> - pr_info("Retrying again to check for CPU kill\n");
> >
> > You dropped this message, any particular reason ?
> >
> When reduce the time interval to 1ms, the print message maybe increase 10 times.
> on the other hand, cpu_psci_cpu_kill() will print message on success or failure, which
> this retry log is not very necessary. of cource, I think use pr_info_once() instead of
> pr_info() is better.
Maybe you should print in on (say) the 10th time around the loop.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-17 14:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 11:21 [PATCH V2] arm64: psci: Reduce waiting time of cpu_psci_cpu_kill() Yunfeng Ye
2019-10-09 4:45 ` Yunfeng Ye
2019-10-16 15:32 ` Sudeep Holla
2019-10-17 13:26 ` Yunfeng Ye
2019-10-17 13:54 ` Sudeep Holla
2019-10-17 14:24 ` Yunfeng Ye
2019-10-17 14:00 ` David Laight [this message]
2019-10-17 14:19 ` Yunfeng Ye
2019-10-17 14:25 ` David Laight
2019-10-15 16:23 ` Will Deacon
2019-10-16 3:22 ` Yunfeng Ye
2019-10-16 10:25 ` Sudeep Holla
2019-10-16 11:29 ` Yunfeng Ye
2019-10-16 15:05 ` Sudeep Holla
2019-10-17 14:08 ` Yunfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c97c87b52f474463bc30ff8033a57e0c@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hushiyuan@huawei.com \
--cc=kstewart@linuxfoundation.org \
--cc=linfeilong@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=wuyun.wu@huawei.com \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).