From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A132C678D4 for ; Fri, 3 Mar 2023 10:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LEP0wpGyMgQJV62jUuEsqLFQnSpy6F4cjQLSxamt6yk=; b=EF0ib9wnKaSIt0 oX0q7nl5mVzFyASxTq5pHZS9YVMkdt7ZuwWLYCMbN+A5aIY2FnHg740zp1+DD2Kn3xmBHF7EBTTD+ tu1Gkfc1k+R8MJ08+n9a7md8VmDoALoCU2vrC/0tFfCA7tYGEpJ5B40Xp/mJPx/UU4V/aln9U2aJw jna+jYttWY7VkquR3w2N6uO+riFXu8/mlz3XiWnNmbjxWSNXnpf2vvracfGHwU8g8N6PuMGnF+hCW 7RW8wN5oevyHHnbm5zrWxda4D6AXU9luhm5sMbHinecGfFvXtPYXqFcuV5X0OQP9961LuVfGFnSmR 0zWvtGBYIbZZmPrhHP2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY2lX-006279-Tv; Fri, 03 Mar 2023 10:35:56 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY2lU-00626C-GU for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 10:35:53 +0000 Received: by mail-ed1-x535.google.com with SMTP id o15so8246862edr.13 for ; Fri, 03 Mar 2023 02:35:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677839750; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ze3EqNSXK099m87RCLoSDBMLakr/T6S1B5LWvJ2yAWs=; b=Sl6eBmlYVeo+www7Qqnrv+jZKj1mxXNNrnC3B933eeNdcY8vH288MHs3BC/shgvXoW rPqyNF0o9CUq+5Xp8d5AuFjCA+tDdhugohmyn54ZdLrynzd1TG9kTbxaHCQbXMbDoJXz vDL1FMReWmxo5tAi9pzmWVs9nVF+H1wUpfq6y2vogFa3ETw+6q7zsGPVr8XoEt3fnf3R YSn8K+zvFYf+ycv+aZ0MWpwtxiGOr1mnO3NyUVurvBQMQPM3mjdHrIvXfuMF1JQXCP4z 3PbT22gomJ5ZIttZTSQRZr/Gr7HI19zZPacncxzMQDKi3JY5sWEkPOIGJ/2M7LUMVw2m +vXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677839750; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ze3EqNSXK099m87RCLoSDBMLakr/T6S1B5LWvJ2yAWs=; b=HzeJNGbvL18becsG2KL4hzEOQtoLHkaAIn7px6gWT1ukNFRm/xbXP1I2V1iY1uTJBZ AOOHsNgnQRHBvBWlkEc3tuAGgJM1OleTXSiuZ4PDSCQenDWOV/1xOB7Z7rrPfzjc+G7T Kp2EQazynJULSSh7OsZYCMiUprUUoHj2EzQN9I1BQVRWhdNmTLrckHR+P3v3tvvyn664 TWoh4CbdbBHQCHGBI0sSLkLLzcCU6iN+wT/9c8buv8IfZ+3Jv/NLSP+vpkQWjxe4cMuf Kcn6ft5IXzmYXuVw4Wmg9Xcbfq828Jh4vEtc5/rLtqETrI0guylettl8YF4M1AsouuU2 M+1Q== X-Gm-Message-State: AO0yUKWLOUdK99PrpSVkNNrQ0TFAYVdGqQIzURuhC5EvXFg8VHt1XgFP K2zK2ibXOxtGEadjneh5jC/pRw== X-Google-Smtp-Source: AK7set+YW7hYpKA3lpcL/dUA/royLMxXd7p/cWUk/XidAXP9MdbG5CBb4pNf71EG4BgZRngyg8UbVQ== X-Received: by 2002:aa7:c2da:0:b0:4bf:33e8:21ff with SMTP id m26-20020aa7c2da000000b004bf33e821ffmr1240428edp.30.1677839749740; Fri, 03 Mar 2023 02:35:49 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id v12-20020a170906338c00b008ba9e67ea4asm802590eja.133.2023.03.03.02.35.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 02:35:49 -0800 (PST) Message-ID: Date: Fri, 3 Mar 2023 11:35:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 02/16] PCI: exynos: Rename Exynos PCIe driver to Samsung PCIe Content-Language: en-US To: Shradha Todi , lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com, jingoohan1@gmail.com, Sergey.Semin@baikalelectronics.ru, lukas.bulwahn@gmail.com, hongxing.zhu@nxp.com, tglx@linutronix.de, m.szyprowski@samsung.com, jh80.chung@samsung.co, pankaj.dubey@samsung.com Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230214121333.1837-1-shradha.t@samsung.com> <20230214121333.1837-3-shradha.t@samsung.com> <4e7f3fe5-3a5e-d4c3-d513-642184bbdb23@linaro.org> <139601d94d06$9bd85990$d3890cb0$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <139601d94d06$9bd85990$d3890cb0$@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_023552_602609_2F208FD4 X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/03/2023 13:57, Shradha Todi wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] >> Sent: 16 February 2023 16:29 >> To: Shradha Todi ; lpieralisi@kernel.org; >> kw@linux.com; robh@kernel.org; bhelgaas@google.com; >> krzysztof.kozlowski+dt@linaro.org; alim.akhtar@samsung.com; >> jingoohan1@gmail.com; Sergey.Semin@baikalelectronics.ru; >> lukas.bulwahn@gmail.com; hongxing.zhu@nxp.com; tglx@linutronix.de; >> m.szyprowski@samsung.com; jh80.chung@samsung.co; >> pankaj.dubey@samsung.com >> Cc: linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- >> kernel@vger.kernel.org >> Subject: Re: [PATCH 02/16] PCI: exynos: Rename Exynos PCIe driver to >> Samsung PCIe >> >> On 16/02/2023 11:55, Krzysztof Kozlowski wrote: >>> On 14/02/2023 13:13, Shradha Todi wrote: >>>> The current PCIe controller driver is being used for Exynos5433 SoC >>>> only. In order to extend this driver for all SoCs manufactured by >>>> Samsung using DWC PCIe controller, rename this driver and make it >>>> Samsung specific instead of any Samsung SoC name. >>>> >>>> Signed-off-by: Shradha Todi >>>> --- >>>> MAINTAINERS | 4 +- >>>> drivers/pci/controller/dwc/Kconfig | 6 +- >>>> drivers/pci/controller/dwc/Makefile | 2 +- >>>> drivers/pci/controller/dwc/pci-samsung.c | 443 >>>> +++++++++++++++++++++++ >>> >>> Rename missing. I am anyway not sure if this is good. What's wrong >>> with old name? >> >> OK, looking a bit at your further patches - doesn't it make sense to split a bit >> the driver? Maybe keep the core as pci-samsung, but some other parts in >> pci-exynso5433? >> > > Ok agreed. So here is what I am planning, keeping in mind the next set of platform support which I am planning to send out (say FSD, ARTPEC-v8): > 1: We will move samsung pci driver inside dwc/samsung/ I don't think we need one more directory... > 2: pci-samsung.c shall contain common APIs, helper functions, etc > 3: Platform specific driver will have their own files such as pcie-exynos.c, pcie-fsd.c, pcie-artpec-v8.c This sounds reasonable, although depends whether common driver part is more or less common. If it is more common, then you will need only one pci_driver and it should be in common object. > Let me know what you think of this. > I am not very keen on renaming Exynos SoC file as pcie-exyons5433.c as in future we may end up adding PCIe support for other Exynos which being > in same family (Exynos Series) will be very similar in design. Custom ASIC (manufactured by Samsung Foundry) is primarily driven by various > vendors and will have separate design in terms of integration of IPs in SoC and we need to have support for all such SoCs manufactured under Samsung umbrella. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel