From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEEBFCA9EC0 for ; Mon, 28 Oct 2019 14:28:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80E4721479 for ; Mon, 28 Oct 2019 14:28:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dNvg8XI1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80E4721479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yPqYvsmXYwPi4M3C1tsOjZmaNJcFg63bxVmbZKTC7MI=; b=dNvg8XI1e0QyuS jgbpBG7eogc3/IwQqSLJpjQXuCLritvfLZMVzteyAya9saInRJjCg+bk7wUdR44XH78HWkC1vWLHm DNWscBliG6MG4L9iYFXhBcb5TkDUNkV3aQJVk7Za/FXsixAXnV1ATpSOYXLSk0n0RSPTo48vmkEoM 5gqb+BbCJoxz6zOgERjxsiDoo5CdwQ9Wm/JjAJLA05xQHfITBsZ9FDQKVV+Kk0gRa6rq4G5c4/Gqh Tnx240Kk8eILWGGDanpdEvYNbczQkDHbmcUtpOf5Y67gPR0wa1h74Le3mCFoRYb9gANVI4+t1NNBX 15vCMVdpt2x2I7eAGtxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP60s-0005gg-Gq; Mon, 28 Oct 2019 14:28:54 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP60p-0005fz-JY for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2019 14:28:52 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1iP60k-0003zY-2k; Mon, 28 Oct 2019 15:28:46 +0100 Message-ID: Subject: Re: [PATCH 1/3] ARM: dts: imx6qdl: add TQMa6{S,Q,QP} SoM From: Philipp Zabel To: Shawn Guo Date: Mon, 28 Oct 2019 15:28:45 +0100 In-Reply-To: <20191026093356.GE14401@dragon> References: <20191011143651.6424-1-p.zabel@pengutronix.de> <20191026093356.GE14401@dragon> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_072851_642239_1629831F X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Rob Herring , kernel@pengutronix.de, Markus Niebel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shawn, On Sat, 2019-10-26 at 17:34 +0800, Shawn Guo wrote: > On Fri, Oct 11, 2019 at 04:36:49PM +0200, Philipp Zabel wrote: > > From: Markus Niebel > > > > Add device trees for TQMa6S, TQMa6Q, and TQMa6QP embedded modules. > > The A and B SoM variants are for hardware revisions that differ in > > how the I2C devices are connected. For details, see [1]. > > It looks like a perfect case to be handled by DT overlay. > Did you consider of using that? I don't think using DT overlays is feasible. The EEPROM that could tell us which variant we are running on is on the I2C bus that is different between the two variants. [...] > > +&ecspi1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_ecspi1>; > > + fsl,spi-num-chipselects = <1>; > > Obsolete property. > > > + cs-gpios = <&gpio3 19 0>; > > GPIO_ACTIVE_HIGH > > > + status = "okay"; > > + > > + flash: m25p80@0 { > > Node name should be generic, while label can be specific. > > > + status = "okay"; > > Not really needed. > [...] > > +&iomuxc { > > + tqma6 { > > Drop this container node. > [...] > > + pinctrl_i2c1_tqma6: i2c1-tqma6grp { > > The '_tqma6' suffix isn't really useful. > [...] > > +&pmic { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_pmic>; > > + interrupt-parent = <&gpio6>; > > + interrupts = <10 8>; > > IRQ_TYPE_LEVEL_LOW > [...] > > + pmic: pf0100@8 { > > Node name should be generic, while label can be specific. > > > + compatible = "fsl,pfuze100"; > > + reg = <0x08>; > > + }; > > + > > + sensor0: lm75@48 { > > Ditto > > > + compatible = "lm75"; > > + reg = <0x48>; > > + }; > > + > > + eeprom0: m24c64@50 { > > Ditto Thank you, I'll fix these. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel