From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49A81C43464 for ; Fri, 18 Sep 2020 16:57:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D326320848 for ; Fri, 18 Sep 2020 16:57:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YxU5yA/R"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="YKmu7ZR3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D326320848 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PXrOvEnPgR+E442JYySU9F2uXpHQAzC2RdCf4p7Q3kk=; b=YxU5yA/RRVJxXRb+gi2Q7VEka v9xi+7Xb+yaGTGsYG4dMLjZQJFwqd30VeJr4U8/D8vGzKaIWXFbzu4FEi6Hq4reT+2gCnesg0DeAb 44DOBdQ4vtVj+h+1xZhbrK3npMg6PPRiSrjvzUKx32txvjd0msuCWDHQAcyjyMf0WM7C+adJ4qfFn 9YXt3OyFK66IHB2bSGl2NHym3wTrOuAHHGRvztrecMJl9SHdVMDp0zOJZlAfVErYeDrEb1aysdCnh Ucyz+5dYDMhpU3KsPvrJWML2/a4SbaPnwpVcTqa5oCWykFv0xuOZBU1871V3gh0fAbixWgO0LWJdW pSo9DoDVQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJJeL-0001mf-GU; Fri, 18 Sep 2020 16:54:17 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJJbD-0008QW-Sm for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 16:51:05 +0000 Received: by mail-pg1-x543.google.com with SMTP id y1so3807186pgk.8 for ; Fri, 18 Sep 2020 09:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=i626wvoZabMUjQF03JmQZni3WGRHoiP51qRJmlnUzb0=; b=YKmu7ZR3YGw2pkUc7qAyLWNw1ToEY5uahh0b1nu5RQvb8S4pY4wcQ13TxT6CgW+j/R oj0K1BKhmkewY/6A75ltzB50km/zgemL/2F/PdATuq6vmOoX6n4qWeIg4UPMgL/pWA9p 9FYHn/c4Yr9+fcznMotxQqSKu59kwSATZgMMw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i626wvoZabMUjQF03JmQZni3WGRHoiP51qRJmlnUzb0=; b=FYhTIFc/fur7T75oLI48sq8IhMqVz1OK7+bQ44clhsSHdz43vjhyJvSGmJoSCTHVSi dUYI6HHzZgCHHRwW71xlXCBmEO7/9PPL0K+2h6+4aUsONftAXdjOg0qkApGhO0WujzDd PHJBniQMDgESsODyKsLSu5GeEYQjjPMlVWoJjKfvy/5f0g4Yn6G32p2B87KIl3xlFII6 2f8IEPGPMGTsp8YN+gR4WQPy0+iWcd00nu/LTzfCVwsysRfsaB6SmYSs1qNtjOInOiwI kci4+RAZONmf+HU3ASA/qG3Y6I4tEErYQefET5NvR2CangSRV3ubCH99b7YdVEDBvbjZ Ed7w== X-Gm-Message-State: AOAM532lhKIKcCNlqMLhJ+nfyotu1FFVR+UvAM40fvgmNUBpI629yAk1 imtLnQG5B95ocrcYXvq5eqHjhQ== X-Google-Smtp-Source: ABdhPJz3HEhhD/ld3oY53TTJk0XHUv+g7pkTSJgO1zGCpQBObxHFfuD8bItjZA2V95MR/YmpiFIoKQ== X-Received: by 2002:a65:4689:: with SMTP id h9mr27004067pgr.50.1600447859418; Fri, 18 Sep 2020 09:50:59 -0700 (PDT) Received: from [10.136.8.253] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id a14sm3274806pju.30.2020.09.18.09.50.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Sep 2020 09:50:58 -0700 (PDT) Subject: Re: [PATCH -next] PCI: iproc: use module_bcma_driver to simplify the code To: Liu Shixin , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com References: <20200918030829.3946025-1-liushixin2@huawei.com> From: Ray Jui Message-ID: Date: Fri, 18 Sep 2020 09:50:55 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200918030829.3946025-1-liushixin2@huawei.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_125104_010013_9576C5C3 X-CRM114-Status: GOOD ( 17.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/17/2020 8:08 PM, Liu Shixin wrote: > module_bcma_driver() makes the code simpler by eliminating > boilerplate code. > > Signed-off-by: Liu Shixin > --- > drivers/pci/controller/pcie-iproc-bcma.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/pci/controller/pcie-iproc-bcma.c b/drivers/pci/controller/pcie-iproc-bcma.c > index aa55b064f64d..56b8ee7bf330 100644 > --- a/drivers/pci/controller/pcie-iproc-bcma.c > +++ b/drivers/pci/controller/pcie-iproc-bcma.c > @@ -94,18 +94,7 @@ static struct bcma_driver iproc_pcie_bcma_driver = { > .probe = iproc_pcie_bcma_probe, > .remove = iproc_pcie_bcma_remove, > }; > - > -static int __init iproc_pcie_bcma_init(void) > -{ > - return bcma_driver_register(&iproc_pcie_bcma_driver); > -} > -module_init(iproc_pcie_bcma_init); > - > -static void __exit iproc_pcie_bcma_exit(void) > -{ > - bcma_driver_unregister(&iproc_pcie_bcma_driver); > -} > -module_exit(iproc_pcie_bcma_exit); > +module_bcma_driver(iproc_pcie_bcma_driver); > > MODULE_AUTHOR("Hauke Mehrtens"); > MODULE_DESCRIPTION("Broadcom iProc PCIe BCMA driver"); > Looks good to me. Thanks. Acked-by: Ray Jui _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel