From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DE28C7EE2E for ; Fri, 9 Jun 2023 10:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pn7Ud37MyRbcMoni0jf5OEfmcl8+d7+KNYnUQfgc0Hg=; b=QUUjJ6ws8AQpNp /4pQvbEjOt3qpPGF/4xdsQUXb28HXEQWyYpa7pfeDDoVhE1o8Ifsjz5eiJm+FfMD5b29/9J09tCF4 qg0xuHkHkASQCP3bVVaPDSSpDc7fBQVqSIliMxtYQuBivT/Zrnlheo8nCnGaUKuGaIxuTp8mxartP OYFvVvxir+5CbiN7dN8nK1cPAla7KMzPlqZ5xLCKQ9LeMzEhazM70fRyj7yOL1IjX6lKpNrIsslIU JXnTAvOtBUfqwWTYe5pZkk6TqHKqrcGAbwpglXwS5dt9jZG4NdQRibFDPQOCfhbKaQcXcjWIHqnbz u/3EJtzRXHEKuxpmFqfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7ZcW-00CgOj-1c; Fri, 09 Jun 2023 10:45:28 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7ZcT-00CgNd-11; Fri, 09 Jun 2023 10:45:26 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4f62b512fe2so2082700e87.1; Fri, 09 Jun 2023 03:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686307517; x=1688899517; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l264HfNhj+I1zkWrab2NzgSBNFP/DUaaconpEt52myg=; b=B6z+QsPVviwU5H+5LlhxbNDzDuEjDCO5y2yOazZM9y8hZ2YBIhMeLGFo3mT2GUR3vx lpDfAoaaa7u2g9v0GaB9sUQZZRNLxCJG16wZXZECGw/IzGe/g/y+aRaXm3xsf2p9dHvj NOhOEdmwYpQaHSTy5Hyfvcy1cng13Dygz8ZCKIVD57KtMsHARK2t0vbjfAK7SIQUnkPh 5GF2oPKx2rQLS5Y/z5FOa7dbTNk+7XVWsIeTDi+5w/ZlkQXR8ZfWj52eqQcJ7FnspHuh 7TSncW2Bc3RJee05S2DKXhqDxZ6uITZjI76yd18Hk0r75DT26iyGJmw7LMVJG2uCPC5K eO5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686307517; x=1688899517; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l264HfNhj+I1zkWrab2NzgSBNFP/DUaaconpEt52myg=; b=XOl+tQaOzM3DQpvUlhVLJSLOeSxJCy37DizHtDyJ3/X/rboOyWvD2G82sA7jWrtIZ+ z94Nqld10frm7JRxbgdcpYurYpaByiQESIjxw7v3Z+DFnJy1njoR7L7qQpGZxFRC8bRs BSGDiHQO5jpFjZVcT8d9vUdodtMMhpkDX1LW4RohXDRgUsE893c1k6HGQpVJvGltzPx6 1LwMilUQLw1AWodBbLRAC/brwkNifhkzQnlPjDY2ABPL5p7ZgbXl4642gpKAu9HyWn0U HWiVv+zlf2pfUb8LvEnB7g8Xc19XqoM8uZtCKHrM66vkU+bu5t7lZlaG8sFWHbmsHZOA SINg== X-Gm-Message-State: AC+VfDz5HCv608//gvyotebp1vv4ca6BBVxZi/Xo5f6eYd1KfcXEO8wO BxMv705yT10EKGtJZRQX9vE= X-Google-Smtp-Source: ACHHUZ5gL87Vi6C0CY5jFyU11r4cHGkTP6mC/+vKp5n+FdG92YKf9JPAWxZP4tlsu9T3j2oGzwYBHQ== X-Received: by 2002:a19:8c0d:0:b0:4f4:c973:c97f with SMTP id o13-20020a198c0d000000b004f4c973c97fmr645304lfd.49.1686307516870; Fri, 09 Jun 2023 03:45:16 -0700 (PDT) Received: from ?IPV6:2001:14ba:16f8:1500::1? (dc78bmyyyyyyyyyyyyyyt-3.rev.dnainternet.fi. [2001:14ba:16f8:1500::1]) by smtp.gmail.com with ESMTPSA id q29-20020ac2515d000000b004f39868bef1sm506966lfd.209.2023.06.09.03.45.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 03:45:16 -0700 (PDT) Message-ID: Date: Fri, 9 Jun 2023 13:45:15 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] regulator: Use bitfield values for range selectors Content-Language: en-US, en-GB To: Chen-Yu Tsai , Mark Brown , Liam Girdwood , Manivannan Sadhasivam , Cristian Ciocaltea Cc: linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230608075651.3214540-1-wenst@chromium.org> From: Matti Vaittinen In-Reply-To: <20230608075651.3214540-1-wenst@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230609_034525_379908_7F8F33F7 X-CRM114-Status: GOOD ( 10.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/8/23 10:56, Chen-Yu Tsai wrote: > Right now the regulator helpers expect raw register values for the range > selectors. This is different from the voltage selectors, which are > normalized as bitfield values. This leads to a bit of confusion. Also, > raw values are harder to copy from datasheets or match up with them, > as datasheets will typically have bitfield values. > > Make the helpers expect bitfield values, and convert existing users. > Include bitops.h explicitly for ffs(), and reorder the header include > statements. While at it, also replace module.h with export.h, since the > only use is EXPORT_SYMBOL_GPL. > > Signed-off-by: Chen-Yu Tsai For the helpers.c and bd718x7 Reviewed-by: Matti Vaittinen Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel