From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFA7FEEE245 for ; Fri, 13 Sep 2024 07:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Subject:References:In-Reply-To:Message-Id:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NGR5qqH9BPt1jFdj+yIMRlQVEYpFagFg+5zP2bRkTnQ=; b=PWKSjS3zqvJnIfXU1XP+g+ZV05 7+Ir+BSbK/c7p7xZuEWrQRatkFHo++v1O1nm63rnFBKRFS6yFfZDptvN/kRp2irqgVf62dy1oZyxH YDc2NdS4bPR5ccyWFNWiOGQFI24CaWUQ+jvXcnRaxmY9wn7WqorTyYwjNbcAQq7wrL+hZCo66nrK4 LyBpc7NkZuUibzkX603+FVy4GyXEyBxi2xEbd/R6ICT8k2zjDXM57GcepZwAwh20TsH7OGP9TCHol twftm5BZ0vgHFWgHmhLqawOyXyMnM6C0tv/q4AUSW+gPjtRVPnfGsPrVkEYjHlK42vvu51E1j2g7a 6VLSM5Tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sp0re-0000000FAoj-2K9C; Fri, 13 Sep 2024 07:37:10 +0000 Received: from fout6-smtp.messagingengine.com ([103.168.172.149]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sp0qS-0000000FAgW-0V6I for linux-arm-kernel@lists.infradead.org; Fri, 13 Sep 2024 07:35:57 +0000 Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id E93A913805FC; Fri, 13 Sep 2024 03:35:54 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Fri, 13 Sep 2024 03:35:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1726212954; x=1726299354; bh=NGR5qqH9BPt1jFdj+yIMRlQVEYpFagFg+5zP2bRkTnQ=; b= mQXEeYxDf/GtHBQszb6qw4r5IV0XefG8dumxARrXOIekoQ0xJ1TYVpIaaR6h9WMH 1+oP77fOJJrUMojiWTvxnWupW14Wx6EDR/W/1QzHQsDqTsLk+INT9xSoBKSJYn4h /ZMgTdfIBZZ4gq2goKoI226kdBO0sm+SIrX+jAdVjoBTf7x/h2kJ/m5UFdOwLKo2 rn3iun8TP5APG/1FU0+7Mde6lYbSlPyA0mmFHTvWArjMx0yknUDjQZHUVzVPNBfY cWwBF6mihz0ZqVALfNACOyOU0olNNoVNIsjH9QHpkY27QvOwc2pD2EvpBKiR1MGm t9u3whrugopy8Bf1SeL0ZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1726212954; x= 1726299354; bh=NGR5qqH9BPt1jFdj+yIMRlQVEYpFagFg+5zP2bRkTnQ=; b=N PXTN6mGjaX0AkN834hN0TRaL3yuuFmcvUNjWUvLlSqfpVwU8kbQIAQUNR4M7lOXn bZ5lYdFKdkWc0Q99Vi/5g1EefWq9z9zAx38kvsdavfp9HlKxch3+ui2/bHUY0c8U jJFS2iqpFNBLQbAw0cSS1lOeknWAvzhJOfhpTDIZtmZQwDWAIX4cHlPkRrqazxx7 aiPGCCbFlqBE2hgCB2jTUO4liCwtcFFy6HfDk0NvDXb7UcQdmweNX5tfbD2/LqHX r6Nef8AGrrZkoJ2fQhAAaYpy/BT5f8DETY6GdlBUp6NCsroP6TPY54/D1F50Qe74 LjzhrmWSH1HNvdFmwL6Tw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejiedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefg gfevudegudevledvkefhvdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepvdek pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehuthhsrghvrdgrghgrrhifrghlse grnhgrlhhoghdrtghomhdprhgtphhtthhopegrughsphdqlhhinhhugiesrghnrghlohhg rdgtohhmpdhrtghpthhtoheprghrthhurhhsrdgrrhhtrghmohhnohhvshesrghnrghloh hgrdgtohhmpdhrtghpthhtoheptggrthgrlhhinhdrmhgrrhhinhgrshesrghrmhdrtgho mhdprhgtphhtthhopehmthhurhhquhgvthhtvgessggrhihlihgsrhgvrdgtohhmpdhrtg hpthhtohepsghrghhlsegsghguvghvrdhplhdprhgtphhtthhopegrnhguihdrshhhhiht iheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheptghonhhorhdoughtsehkvghrnhgvlh drohhrghdprhgtphhtthhopehjihhrihhslhgrsgihsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id D76B7222006F; Fri, 13 Sep 2024 03:35:53 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Fri, 13 Sep 2024 07:35:33 +0000 From: "Arnd Bergmann" To: arturs.artamonovs@analog.com, "Catalin Marinas" , "Will Deacon" , "Greg Malysa" , "Philipp Zabel" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Utsav Agarwal" , "Michael Turquette" , "Stephen Boyd" , "Linus Walleij" , "Bartosz Golaszewski" , "Thomas Gleixner" , "Andi Shyti" , "Greg Kroah-Hartman" , "Jiri Slaby" , "Olof Johansson" , soc@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, adsp-linux@analog.com, "Nathan Barrett-Morrison" Message-Id: In-Reply-To: <20240912-test-v1-6-458fa57c8ccf@analog.com> References: <20240912-test-v1-0-458fa57c8ccf@analog.com> <20240912-test-v1-6-458fa57c8ccf@analog.com> Subject: Re: [PATCH 06/21] include: dt-binding: clock: add adi clock header file Content-Type: text/plain Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240913_003556_300938_FB9B86C1 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 12, 2024, at 18:24, Arturs Artamonovs via B4 Relay wrote: > From: Arturs Artamonovs > > Add adi clock driver header file Are you sure this is necessary? If the clk controller follows a logical structure, it's usually easier to identify individual clks by the way the hardware is laid out. > +#ifndef DT_BINDINGS_CLOCK_ADI_SC5XX_CLOCK_H > +#define DT_BINDINGS_CLOCK_ADI_SC5XX_CLOCK_H > + > +#define ADSP_SC598_CLK_DUMMY 0 > +#define ADSP_SC598_CLK_SYS_CLKIN0 1 > +#define ADSP_SC598_CLK_SYS_CLKIN1 2 > +#define ADSP_SC598_CLK_CGU0_PLL_IN 3 > +#define ADSP_SC598_CLK_CGU0_VCO_OUT 4 Unlike the DT compatible strings, these #defines don't have to be specific to a particular SoC, you could just reuse them for a family of chips even if they each use a slightly different subset. Maybe name them "ADSP_CLK_*" or "ADSP_SC5XX_CLK_*"? > +#define ADSP_SC598_CLK_END 80 This should not be part of the binding, in particular you probably want to be able to extend this in order to support additional chips. Arnd