From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09216CDB46E for ; Thu, 12 Oct 2023 12:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IArYOPrgQ5uqseX3n3yz8nTISfU0h5ud9aJ/kLDeZgw=; b=NziW1SGkgjS1YW 0F19MzPPn+bu0QoDISVP63In+U9jmlyoTYa39lpUTmhpJkW73falPV8/+EFIGLA6zTjVLbgJchoGq 3tX6cBCXg2epTDb9C318ib+3ElpPwpEnDws+y3G801LFdaFO8PPD/eVlP0k3bIE0kTnbmPNMi4pP8 53pH312+EW6iUa/WmBEtZAjkV5PXdLquYzA80gBaGrIbrqjIH5NZEGPvlFXk67CXLXM+h0Jgy2D/K T09WdCaWnJUtolgEn3RdSIXmCmykOPueXAozA9GQiN6uOfEqLVR0p+xqSypQIBN0eousVRLA3v6zw 21tfeaVuZpi8xc7jPDfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qquWb-000w4P-0b; Thu, 12 Oct 2023 12:10:45 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qquWV-000w1j-0Q for linux-arm-kernel@lists.infradead.org; Thu, 12 Oct 2023 12:10:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697112638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e0nmqy59jy/rGMIg2W3+5Ft0g6PXLLlnoefzeVrsrTs=; b=GblLer0KfW+bTtOxd8VXrai/3nQHHuqhZ1IvWeF9B9g3d9uErk/ccKVFHHouOsnV8yK5qm kldTHi/EDQAidjQetHiwJH5bHFi+f6f4KIVhrOhO2axbd3bjzUb4wymtTJnioXnuO+KztM TYI/uQGXpWHVMQk/LEZeHXV96oNNo2M= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-185-gcWwyAuCO56F22pBBOUDzw-1; Thu, 12 Oct 2023 08:10:26 -0400 X-MC-Unique: gcWwyAuCO56F22pBBOUDzw-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-9bd86510329so68660266b.0 for ; Thu, 12 Oct 2023 05:10:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697112626; x=1697717426; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e0nmqy59jy/rGMIg2W3+5Ft0g6PXLLlnoefzeVrsrTs=; b=BifZMrns0x9qJ7pb50MyS+T16G+aRRsByLn4BdgtUIHOF/za9tR4JdVGsLnE0+d5ov Vr/NyAMnauMYbNNiAbTVIDW5fWWm/yNWZJ02BBokrnax3pWiJaxToiA27ITEBHMvqj/p O3CaOc6lGqVZu/7JzM5FjS+qwkrSv9ohfSbkxWRE4LYFRyLnPLMMM73qxoyFWHyr7RL4 sHp7AKGyC9UiQwOywdFgr7six3wUSCPlxBEZDmMU/UKglfq8qlr199nTtudVptcnZCXU HIA0ISSoUESWbUeaaJM9W88xpT0VMNi09iLCzeIKCAfZ6NuydLKOqlTOVy3EZ/kuXc7S DFXw== X-Gm-Message-State: AOJu0YwnT9uXnCB3f0gWQ56HaDkVRqcTC9lLlsRm3+51uo6J67CmdfmZ Mtx3Mao0zqEN9abtYY1RQuPvfbEp5I7BuE3346D1VLNrbXaRcqIQUFdzxaOjpRCPjA3Ki/qbqgw pEBYfUC7tnOVuPUnVRnxkaR8xHADjwAHzOxA= X-Received: by 2002:a17:906:cc13:b0:9b6:50d3:2a75 with SMTP id ml19-20020a170906cc1300b009b650d32a75mr19703358ejb.48.1697112625896; Thu, 12 Oct 2023 05:10:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjvJVtD0uQR8XMo2cR7XmHJlpYVc+HmbN4viv4pGPb6gmHPLLfBWOiJNvTCRNd4xhqfQomHg== X-Received: by 2002:a17:906:cc13:b0:9b6:50d3:2a75 with SMTP id ml19-20020a170906cc1300b009b650d32a75mr19703329ejb.48.1697112625566; Thu, 12 Oct 2023 05:10:25 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id x26-20020a170906711a00b0099329b3ab67sm11000199ejj.71.2023.10.12.05.10.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Oct 2023 05:10:25 -0700 (PDT) Message-ID: Date: Thu, 12 Oct 2023 14:10:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v11 17/56] media: atomisp: Stop direct calls to queue num_buffers field To: Benjamin Gaignard , mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, ming.qian@nxp.com, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, nicolas.dufresne@collabora.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, kernel@collabora.com, Sakari Ailus References: <20231012114642.19040-1-benjamin.gaignard@collabora.com> <20231012114642.19040-18-benjamin.gaignard@collabora.com> From: Hans de Goede In-Reply-To: <20231012114642.19040-18-benjamin.gaignard@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231012_051039_238315_5FAEF36D X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 10/12/23 13:46, Benjamin Gaignard wrote: > Use vb2_get_num_buffers() to avoid using queue num_buffers field directly. > > Signed-off-by: Benjamin Gaignard > CC: Hans de Goede > CC: Sakari Ailus Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > index a8a964b2f1a8..09c0091b920f 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > @@ -1028,7 +1028,7 @@ static int atomisp_qbuf_wrapper(struct file *file, void *fh, struct v4l2_buffer > struct atomisp_device *isp = video_get_drvdata(vdev); > struct atomisp_video_pipe *pipe = atomisp_to_video_pipe(vdev); > > - if (buf->index >= vdev->queue->num_buffers) > + if (buf->index >= vb2_get_num_buffers(vdev->queue)) > return -EINVAL; > > if (buf->reserved2 & ATOMISP_BUFFER_HAS_PER_FRAME_SETTING) { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel