From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BC5FC4332F for ; Tue, 7 Dec 2021 07:52:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=XCq05vdILcC2LfPnjxPnmRA4eebUqC6rZ+PS3vJG9EY=; b=KTTNSVWQ+alhfptqEnnotx1Gi0 jKioK5apUNY5r+yCl5ovz7WZ1ELQY51ySEnKjCSJ2EuINCsgvhISRGQFreTKFvlzfSG9m9E8jgVgM jt2rExArvFj/mbrqEabuTUmXSBl903wDYpBN8NR1GoRAFS2MyDRDPJazjCIek9D8f/RGbVfZPLbrF qcNCmYgMMEuA8fa9ygDgd+nSA8+oaNrR/T25RrGL+SZClC6dzXKgRlCwoUjb+X9WtNQmYci3Hk5Jx 1tM4dDPXXwe+BSk+0SlsIiPi8mXDtiz+smp6mJC/0vp/GeMK+OmKNrdC4Fb3jCYuJeNkwnAoIKdSB enAL2XMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muVFc-007HrF-09; Tue, 07 Dec 2021 07:51:00 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muVFV-007HoI-DE for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 07:50:56 +0000 Received: from dggpeml500023.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4J7XXX5JpszcbTn; Tue, 7 Dec 2021 15:50:36 +0800 (CST) Received: from [10.67.77.175] (10.67.77.175) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 7 Dec 2021 15:50:48 +0800 Subject: Re: [PATCH v13 0/2] drivers/perf: hisi: Add support for PCIe PMU To: Qi Liu , , , CC: , , , References: <20211202080633.2919-1-liuqi115@huawei.com> From: Shaokun Zhang Message-ID: Date: Tue, 7 Dec 2021 15:50:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20211202080633.2919-1-liuqi115@huawei.com> Content-Language: en-US X-Originating-IP: [10.67.77.175] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500023.china.huawei.com (7.185.36.114) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_235053_849273_5F306BCB X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Qi, Thanks for your continuous and nice work, please free to add if it is necessary: Reviewed-by: Shaokun Zhang Thanks, Shaokun On 2021/12/2 16:06, Qi Liu wrote: > This patchset adds support for HiSilicon PCIe Performance Monitoring > Unit(PMU). It is a PCIe Root Complex integrated End Point(RCiEP) device > added on Hip09. Each PCIe Core has a PMU RCiEP to monitor multi root > ports and all Endpoints downstream these root ports. > > HiSilicon PCIe PMU is supported to collect performance data of PCIe bus, > such as: bandwidth, latency etc. > > Example usage of counting PCIe rx memory write latency:: > > $# perf stat -e hisi_pcie0_core0/rx_mwr_latency/ > $# perf stat -e hisi_pcie0_core0/rx_mwr_cnt/ > $# perf stat -g -e hisi_pcie0_core0/rx_mwr_latency/ -e hisi_pcie0_core0/rx_mwr_cnt/ > > average rx memory write latency can be calculated like this: > latency = rx_mwr_latency / rx_mwr_cnt. > > Common PMU events and metrics will be described in JSON file, and will be add > in userspace perf tool latter. > > Changes since v12: > - Modify the printout message of cpuhotplug to standard. > - Link: https://lore.kernel.org/linux-arm-kernel/20211130120450.2747-1-liuqi115@huawei.com/ > > Changes since v11: > - Address the comments from Krzysztof, drop all the final dot and change bdf in comment to BDF. > - Link: https://lore.kernel.org/linux-arm-kernel/20211029093632.4350-1-liuqi115@huawei.com/ > > Changes since v10: > - Drop the out of date comment according to Jonathan's review. > - Link: https://lore.kernel.org/linux-arm-kernel/20210915074524.18040-1-liuqi115@huawei.com/ > > Changes since v9: > - Add check in hisi_pcie_pmu_validate_event_group to count counters accurently . > - Link: https://lore.kernel.org/linux-arm-kernel/20210818051246.29545-1-liuqi115@huawei.com/ > > Changes since v8: > - Remove subevent parameter in attr->config. > - Check the counter scheduling constraints when accepting an event group. > - Link: https://lore.kernel.org/linux-arm-kernel/20210728080932.72515-1-liuqi115@huawei.com/ > > Changes since v7: > - Drop headerfile cpumask.h and cpuhotplug.h. > - Rename events in perf list: bw->flux, lat->delay, as driver doesn't > process bandwidth and average latency data. > - Link: https://lore.kernel.org/linux-arm-kernel/1624532384-43002-1-git-send-email-liuqi115@huawei.com/ > > Changes since v6: > - Move the driver to drivers/perf/hisilicon. > - Treat content in PMU counter and ext_counter as different PMU events, and > export them separately. > - Address the comments from Will and Krzysztof. > - Link: https://lore.kernel.org/linux-arm-kernel/1622467951-32114-1-git-send-email-liuqi115@huawei.com/ > > Changes since v5: > - Fix some errors when build under ARCH=xtensa. > - Link: https://lore.kernel.org/linux-arm-kernel/1621946795-14046-1-git-send-email-liuqi115@huawei.com/ > > Changes since v4: > - Replace irq_set_affinity_hint() with irq_set_affinity(). > - Link: https://lore.kernel.org/linux-arm-kernel/1621417741-5229-1-git-send-email-liuqi115@huawei.com/ > > Changes since v3: > - Fix some warnings when build under 32bits architecture. > - Address the comments from John. > - Link: https://lore.kernel.org/linux-arm-kernel/1618490885-44612-1-git-send-email-liuqi115@huawei.com/ > > Changes since v2: > - Address the comments from John. > - Link: https://lore.kernel.org/linux-arm-kernel/1617959157-22956-1-git-send-email-liuqi115@huawei.com/ > > Changes since v1: > - Drop the internal Reviewed-by tag. > - Fix some build warnings when W=1. > - Link: https://lore.kernel.org/linux-arm-kernel/1617788943-52722-1-git-send-email-liuqi115@huawei.com/ > Qi Liu (2): > docs: perf: Add description for HiSilicon PCIe PMU driver > drivers/perf: hisi: Add driver for HiSilicon PCIe PMU > > .../admin-guide/perf/hisi-pcie-pmu.rst | 106 ++ > MAINTAINERS | 2 + > drivers/perf/hisilicon/Kconfig | 9 + > drivers/perf/hisilicon/Makefile | 2 + > drivers/perf/hisilicon/hisi_pcie_pmu.c | 948 ++++++++++++++++++ > include/linux/cpuhotplug.h | 1 + > 6 files changed, 1068 insertions(+) > create mode 100644 Documentation/admin-guide/perf/hisi-pcie-pmu.rst > create mode 100644 drivers/perf/hisilicon/hisi_pcie_pmu.c > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel