From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jai Luthra <jai.luthra@ideasonboard.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>,
bcm-kernel-feedback-list@broadcom.com
Cc: "Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Phil Elwell" <phil@raspberrypi.com>,
"Stefan Wahren" <wahrenst@gmx.net>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Dave Stevenson" <dave.stevenson@raspberrypi.org>
Subject: Re: [PATCH 07/13] platform/raspberrypi: vchiq-mmal: Free the event context for control ports
Date: Sun, 2 Nov 2025 10:20:57 +0100 [thread overview]
Message-ID: <ca0c3c87-b703-4d97-a9fb-d55ec29725fa@kernel.org> (raw)
In-Reply-To: <20251031-b4-vc-sm-cma-v1-7-0dd5c0ec3f5c@ideasonboard.com>
On 31/10/2025 18:27, Jai Luthra wrote:
> From: Dave Stevenson <dave.stevenson@raspberrypi.org>
>
> vchiq_mmal_component_init calls init_event_context for the
> control port, but vchiq_mmal_component_finalise didn't free
> it, causing a memory leak..
>
> Add the free call.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
Missing fixes tag, Cc stable. Also fixes should not be mixed up with
regular patchset (at all) and for sure not in the middle of the patchset.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-02 9:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 17:27 [PATCH 00/13] platform/raspberrypi: Add Broadcom Videocore shared memory support Jai Luthra
2025-10-31 17:27 ` [PATCH 01/13] platform/raspberrypi: vchiq-mmal: Avoid use of bool in structures Jai Luthra
2025-11-02 9:20 ` Krzysztof Kozlowski
2025-11-03 11:09 ` Christian König
2025-11-03 13:22 ` Jai Luthra
2025-10-31 17:27 ` [PATCH 02/13] platform/raspberrypi: vchiq-mmal: Add support for event callbacks Jai Luthra
2025-11-01 14:03 ` Stefan Wahren
2025-10-31 17:27 ` [PATCH 03/13] platform/raspberrypi: vchiq-mmal: Support sending data to MMAL ports Jai Luthra
2025-10-31 17:27 ` [PATCH 04/13] platform/raspberrypi: vchiq-mmal: Fix client_component for 64 bit kernel Jai Luthra
2025-10-31 17:27 ` [PATCH 05/13] platform/raspberrypi: vchiq-mmal: Add in the bayer and gray formats Jai Luthra
2025-10-31 17:27 ` [PATCH 06/13] platform/raspberrypi: vchiq-mmal: Update video parameters Jai Luthra
2025-10-31 17:27 ` [PATCH 07/13] platform/raspberrypi: vchiq-mmal: Free the event context for control ports Jai Luthra
2025-11-02 9:20 ` Krzysztof Kozlowski [this message]
2025-10-31 17:27 ` [PATCH 08/13] platform/raspberrypi: vchiq-mmal: Fix memory leak in error path Jai Luthra
2025-10-31 17:27 ` [PATCH 09/13] platform/raspberrypi: Add new vc-sm-cma driver Jai Luthra
2025-11-02 9:30 ` Krzysztof Kozlowski
2025-11-03 13:49 ` Jai Luthra
2025-11-03 14:00 ` Krzysztof Kozlowski
2025-10-31 17:27 ` [PATCH 10/13] platform/raspberrypi: vchiq-mmal: Use vc-sm-cma to support zero copy Jai Luthra
2025-10-31 17:27 ` [PATCH 11/13] platform/raspberrypi: vchiq-mmal: Reset buffers_with_vpu on port_enable Jai Luthra
2025-10-31 17:27 ` [PATCH 12/13] platform/raspberrypi: vchiq-mmal: Add defines for mmal_es_format flags Jai Luthra
2025-11-02 9:33 ` Krzysztof Kozlowski
2025-10-31 17:27 ` [PATCH 13/13] platform/raspberrypi: vchiq: Register vc-sm-cma as a platform driver Jai Luthra
2025-11-02 9:33 ` Krzysztof Kozlowski
2025-11-03 13:57 ` Jai Luthra
2025-11-03 14:01 ` Krzysztof Kozlowski
2025-11-03 14:07 ` Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca0c3c87-b703-4d97-a9fb-d55ec29725fa@kernel.org \
--to=krzk@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christian.koenig@amd.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dave.stevenson@raspberrypi.org \
--cc=florian.fainelli@broadcom.com \
--cc=jai.luthra@ideasonboard.com \
--cc=kernel-list@raspberrypi.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@raspberrypi.com \
--cc=sumit.semwal@linaro.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).