From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9779ECAC5B8 for ; Mon, 6 Oct 2025 16:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ygug8+cF9r/CjSHjQ6eFGDARziGIKPc/GQ1PbW1jXLw=; b=Zfv7RDLyy7wK0cG8kVg7m1D5U9 Uj5ysI+8yx4TOvsZcnoZ9OoZ1f04bUKWe3dALF+jm6KZn67iiInb9hheaKL1IMeiQk/T4UB0/gdtZ 5uqJJ7iqaHmidtNWtxe84NCBtj97gOkJkUOX1GtGHKPMz7YXh33j9xprlwjojrC/oJ1xl3QYOu6rW NCQplPRbUL+T/4eLu/ogwKU7+JqvVjU7KV+zWqg8WpSjWXA2++WgqyC2pYGVso7pZa98PVvFknr9x tSTILytW3+lg9QJQwgXNN0o+/8CkQMaIfThPPo/TMiPkpTa+lpUoSmC5Spn2vQCdtKMecFJuBQx1+ n59k3RDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v5ndy-00000000LEp-2jI8; Mon, 06 Oct 2025 16:00:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v5ndw-00000000LDt-2DHa for linux-arm-kernel@lists.infradead.org; Mon, 06 Oct 2025 16:00:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CDEA11516; Mon, 6 Oct 2025 09:00:47 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BDB993F738; Mon, 6 Oct 2025 09:00:50 -0700 (PDT) Message-ID: Date: Mon, 6 Oct 2025 17:00:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 23/29] arm_mpam: Add mpam_msmon_read() to read monitor value To: Ben Horgan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Cc: D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-24-james.morse@arm.com> <1344b395-66aa-4714-b1fc-9c970c0fd0bf@arm.com> <842edca0-11c7-43ac-ba4b-ab40678034e2@arm.com> Content-Language: en-GB From: James Morse In-Reply-To: <842edca0-11c7-43ac-ba4b-ab40678034e2@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251006_090056_610216_7C3FF218 X-CRM114-Status: GOOD ( 11.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ben, On 12/09/2025 16:08, Ben Horgan wrote: > On 9/11/25 16:46, Ben Horgan wrote: >> On 9/10/25 21:43, James Morse wrote: >>> Reading a monitor involves configuring what you want to monitor, and >>> reading the value. Components made up of multiple MSC may need values >>> from each MSC. MSCs may take time to configure, returning 'not ready'. >>> The maximum 'not ready' time should have been provided by firmware. >>> >>> Add mpam_msmon_read() to hide all this. If (one of) the MSC returns >>> not ready, then wait the full timeout value before trying again. >>> diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c >>> index cf190f896de1..1543c33c5d6a 100644 >>> --- a/drivers/resctrl/mpam_devices.c >>> +++ b/drivers/resctrl/mpam_devices.c >>> + >>> +static void gen_msmon_ctl_flt_vals(struct mon_read *m, u32 *ctl_val, >>> + u32 *flt_val) >>> +{ >>> + struct mon_cfg *ctx = m->ctx; >>> + >>> + /* >>> + * For CSU counters its implementation-defined what happens when not >>> + * filtering by partid. >>> + */ >>> + *ctl_val |= MSMON_CFG_x_CTL_MATCH_PARTID; >>> + >>> + *flt_val = FIELD_PREP(MSMON_CFG_x_FLT_PARTID, ctx->partid); >>> + if (m->ctx->match_pmg) { >>> + *ctl_val |= MSMON_CFG_x_CTL_MATCH_PMG; >>> + *flt_val |= FIELD_PREP(MSMON_CFG_x_FLT_PMG, ctx->pmg); >>> + } >>> + >>> + switch (m->type) { >>> + case mpam_feat_msmon_csu: >>> + *ctl_val = MSMON_CFG_CSU_CTL_TYPE_CSU; >>> + >>> + if (mpam_has_feature(mpam_feat_msmon_csu_xcl, &m->ris->props)) >>> + *flt_val |= FIELD_PREP(MSMON_CFG_CSU_FLT_XCL, >>> + ctx->csu_exclude_clean); >>> + >>> + break; >>> + case mpam_feat_msmon_mbwu: >>> + *ctl_val = MSMON_CFG_MBWU_CTL_TYPE_MBWU; > > As you mentioned offline, this zeroes the other bits in *ctl_val. Yes - a bug introduced during a late night, I've fixed this up. Thanks, James