From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 379F4C432C2 for ; Wed, 25 Sep 2019 19:37:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06DF721D7A for ; Wed, 25 Sep 2019 19:37:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r39YLzJ6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="g/W0J48R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06DF721D7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=khgDVmWwMRXUQVAEqrL6AzgQhBuUhkQ50hZuh2woZnA=; b=r39YLzJ6lo8uzrM3vTXsgHLoi U9OVUHVBpQQbBqBmY4gIJWmG66jXJzvwlixB3DJIdnX/OEbSViEdQM2Gc7KAdQP7sCO2jb5a1lC2e /xucUfv1m9FDaRqODlNufGMSslIVdA8vPxg44CIXOp2m9vrIc6i5LZyKp7uUSpX6itXSP/kHglZgG AIrw/al3CVpFmUtsYcfkXe5jsDTT+jd2R21Oz65SdsevSo4tbPlMefhDRhALDwTJMBp/QRGU+EZjU C0/N9oZ9aaZzsLj/233AtgTFlqNHizv2jwY//EJax55fHV4vIKJmL7OmDr/FEzE1A2vqAqcK5dr7k G/wk6v28Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDD5z-00036p-EK; Wed, 25 Sep 2019 19:37:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDD5g-0002q9-La for linux-arm-kernel@lists.infradead.org; Wed, 25 Sep 2019 19:36:47 +0000 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 096CF21D7A; Wed, 25 Sep 2019 19:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569440204; bh=5Gm1h33RuHVX6DX/tp8dYOGoNk7nNRxZvLsX8xAjiEs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=g/W0J48ReDDn0f5ap0TBcejsFoEq5uE4KOq9RcgbdS6bW5GjlIhhr4cl3ILlNEhKA Mv4aWCMhOSxQHTwoneDcE4pm7/7W3F5e1J5jGCINyLsxfbpYBLD9L9yE9+yQfdpmHT QP19hWhnnLIcHBynngLmRdgaY8//nOKvd1oG+ubY= Subject: Re: [PATCH 2/2] kselftest: exclude failed TARGETS from runlist To: Cristian Marussi , linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20190925132421.23572-1-cristian.marussi@arm.com> <20190925132421.23572-2-cristian.marussi@arm.com> From: shuah Message-ID: Date: Wed, 25 Sep 2019 13:36:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190925132421.23572-2-cristian.marussi@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190925_123644_866029_9A979968 X-CRM114-Status: GOOD ( 18.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shuah , dave.martin@arm.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/25/19 7:24 AM, Cristian Marussi wrote: > A TARGET which failed to be built/installed should not be included in the > runlist generated inside the run_kselftest.sh script. > > Signed-off-by: Cristian Marussi > --- > As an example, here BPF failed to compile but was included in the runlist > and attempted to run anyway: > > ... > ./KSFT_LAST_2/run_kselftest.sh: 37: cd: can't cd to bpf > TAP version 13 > 1..49 > \# selftests: KSFT_LAST_2: test_verifier > \# Warning: file test_verifier is missing! > not ok 1 selftests: KSFT_LAST_2: test_verifier > \# selftests: KSFT_LAST_2: test_tag > \# Warning: file test_tag is missing! > --- > tools/testing/selftests/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile > index 103936faa46d..e11ace11b07c 100644 > --- a/tools/testing/selftests/Makefile > +++ b/tools/testing/selftests/Makefile > @@ -202,8 +202,12 @@ ifdef INSTALL_PATH > echo " cat /dev/null > \$$logfile" >> $(ALL_SCRIPT) > echo "fi" >> $(ALL_SCRIPT) > > + @# While building run_kselftest.sh skip also non-existent TARGET dirs: > + @# they could be the result of a build failure and should NOT be > + @# included in the generated runlist. > for TARGET in $(TARGETS); do \ > BUILD_TARGET=$$BUILD/$$TARGET; \ > + [ ! -d $$INSTALL_PATH/$$TARGET ] && echo "Skipping non-existent dir: $$TARGET" && continue; \ > echo "[ -w /dev/kmsg ] && echo \"kselftest: Running tests in $$TARGET\" >> /dev/kmsg" >> $(ALL_SCRIPT); \ > echo "cd $$TARGET" >> $(ALL_SCRIPT); \ > echo -n "run_many" >> $(ALL_SCRIPT); \ > This is great. Thanks for the patch. -- Shuah _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel