From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Willie Thai <wthai@nvidia.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
joel@jms.id.au, kees@kernel.org, tony.luck@intel.com,
gpiccoli@igalia.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, openbmc@lists.ozlabs.org
Cc: leohu@nvidia.com, tingkaic@nvidia.com, dkodihalli@nvidia.com,
Mars Yang <maryang@nvidia.com>
Subject: Re: [PATCH v5 1/2] dt-bindings: arm: aspeed: add Nvidia's GB200NVL BMC
Date: Thu, 03 Apr 2025 16:26:11 +1030 [thread overview]
Message-ID: <ca1f5dc3d0dd53dfe6abd9d6bea98838980f0840.camel@codeconstruct.com.au> (raw)
In-Reply-To: <f563b33e-f552-4a3c-bb45-6b7add876fdd@kernel.org>
On Tue, 2025-04-01 at 17:51 +0200, Krzysztof Kozlowski wrote:
> On 01/04/2025 17:39, Willie Thai wrote:
> > Add Nvidia's GB200NVL BMC board compatible.
> >
> > Co-developed-by: Mars Yang <maryang@nvidia.com>
> > Signed-off-by: Mars Yang <maryang@nvidia.com>
> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Why are you faking tags/email addresses? Read carefully submitting
> patches. I really suggest using b4 instead of manually editing
> things.
> And if you decide for manual way, you must never, *never* edit
> people's
> tag. You can only copy and paste it.
I've applied the series, fixing the tag in the process, along with the
line-wrapping of the commit message in the second patch.
Willie: scripts/checkpatch.pl warns of some of these things. Please
make sure to use it in the future, or if you adopt b4 as Krzysztof
suggests, use `b4 prep --check`.
Andrew
next prev parent reply other threads:[~2025-04-03 5:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 15:39 [PATCH v5 0/2] Add device tree for Nvidia's GB200NVL BMC Willie Thai
2025-04-01 15:39 ` [PATCH v5 1/2] dt-bindings: arm: aspeed: add " Willie Thai
2025-04-01 15:51 ` Krzysztof Kozlowski
2025-04-01 16:05 ` Willie Thai
2025-04-03 5:56 ` Andrew Jeffery [this message]
2025-04-07 13:23 ` Willie Thai
2025-04-01 15:39 ` [PATCH v5 2/2] ARM: dts: aspeed: Add device tree for " Willie Thai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca1f5dc3d0dd53dfe6abd9d6bea98838980f0840.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dkodihalli@nvidia.com \
--cc=gpiccoli@igalia.com \
--cc=joel@jms.id.au \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=leohu@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maryang@nvidia.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh@kernel.org \
--cc=tingkaic@nvidia.com \
--cc=tony.luck@intel.com \
--cc=wthai@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox