Re: [PATCH] clk: Switch back to struct platform_driver::remove()

Re: [PATCH] clk: Switch back to struct platform_driver::remove()

[Geert Uytterhoeven]

On Mon, Sep 9, 2024 at 4:40 PM Uwe Kleine-König
<u.kleine-koenig@baylibre.com> wrote:
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
>
> Convert all clk drivers to use .remove(), with the eventual goal to drop
> struct platform_driver::remove_new(). As .remove() and .remove_new() have
> the same prototypes, conversion is done by just changing the structure
> member name in the driver initializer.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

>  drivers/clk/renesas/rcar-usb2-clock-sel.c       | 2 +-

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> # renesas

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] clk: Switch back to struct platform_driver::remove()

[Stephen Boyd]

Quoting Uwe Kleine-König (2024-09-09 07:40:25)
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
> 
> Convert all clk drivers to use .remove(), with the eventual goal to drop
> struct platform_driver::remove_new(). As .remove() and .remove_new() have
> the same prototypes, conversion is done by just changing the structure
> member name in the driver initializer.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
> 
> I was lazy and created a single patch for all of clk. Please tell me if
> I should split per vendor (or per-driver). Given that touches so many
> drivers, I also stripped the individual maintainers and just kept the
> mailing lists. I hope this doesn't prevent people to give feedback, but
> otherwise the Cc: list gets Huge.
> 

I'll apply it on top of clk-next right before sending the main clk PR to
Linus.

Re: [PATCH] clk: Switch back to struct platform_driver::remove()

[Stephen Boyd]

Quoting Uwe Kleine-König (2024-09-09 07:40:25)
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
> 
> Convert all clk drivers to use .remove(), with the eventual goal to drop
> struct platform_driver::remove_new(). As .remove() and .remove_new() have
> the same prototypes, conversion is done by just changing the structure
> member name in the driver initializer.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---

Applied to clk-next