From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A90BC4332F for ; Wed, 2 Nov 2022 10:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GveMgPiX/deyVcb2oxdj67dJlrGxN9sfQPBwG7rej44=; b=FnQ7AwzmChQK+K jk+ultZN6a6TVmZTJAftX8HcXJSShWTChmgm+059SM569MkYKJ8JIWIkBSfJ3AEUBcXL7rB7sEvWL 7vJ9kpY5HhlRtdSXcsd1/HY6/L86yRC0YhbZ1+oKeRepBP/bv3D1eoOWtNvWKDW2htLkSXql6iMGO Pu8RF62Psw0ZtDuHDvC0HOZvSJDFjwVNbAt7EkiyuZ38s+Bick6Hy4piJizeO9WBfvS0eNMMeaKWx pWlVNBHB76NOjoA0eAnyBU+1KvkBdX9YhwYFHJtFWJ27UmSasOjbUTNX+NJ0PQGmozjnh0m87g7PQ rqWiDSWpTgdLM90uU+Wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqBHr-00Aaa4-8Y; Wed, 02 Nov 2022 10:47:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqBHm-00AaY9-TS for linux-arm-kernel@lists.infradead.org; Wed, 02 Nov 2022 10:47:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 420A51FB; Wed, 2 Nov 2022 03:48:00 -0700 (PDT) Received: from [10.57.68.155] (unknown [10.57.68.155]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 252BB3F5A1; Wed, 2 Nov 2022 03:47:53 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 10:47:51 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2] arm64: cpufeature: Fix the visibility of compat hwcaps To: Amit Daniel Kachhap , linux-arm-kernel@lists.infradead.org Cc: Catalin Marinas , Will Deacon , James Morse References: <20221102102143.19617-1-amit.kachhap@arm.com> From: Suzuki K Poulose In-Reply-To: <20221102102143.19617-1-amit.kachhap@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221102_034755_024673_F2469403 X-CRM114-Status: GOOD ( 11.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Amit On 02/11/2022 10:21, Amit Daniel Kachhap wrote: > Commit 237405ebef58 ("arm64: cpufeature: Force HWCAP to be based on the > sysreg visible to user-space") forced the hwcaps to use sanitised > user-space view of the id registers. However, the ID register structures > used to select few compat cpufeatures (vfp, crc32, ...) are masked and > hence such hwcaps do not appear in /proc/cpuinfo anymore for PER_LINUX32 > personality. > > Add the ID register structures explicitly and set the relevant entry as > visible for compat hwcaps. > > While at it, update the comment for structure ftr_generic_32bits[] which > lists the ID register that use it. > Minor nit: With this change, we expose mvfr*_el1 and the following document needs an update to reflect the change. Documentation/arm64/cpu-feature-registers.rst Otherwise, looks good to me. Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel