From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20CD4C3DA49 for ; Tue, 16 Jul 2024 10:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Mof2BdF2wgfCJ/YWOkULfKwz54FH4Y2OtCLn5w3iO4A=; b=FURWl7qFyC2+/SP/pRryYF86yw uqvVRsR5Lom2M1+FzDpjg1nCScKLARlToWowDT/rxSLFWxcsY38Q+62bjpj9ASjUHVqwSG04whyzn 18lF+ZVyxzBmGa0JAeGuROSz4aB4Y7AjBmeP8GMbpeVROB2/wG5t65/MB/fZjGHaayMuHpoSumvzy PLSve4gTbQvpUhIvPAwO9rZuP/Qt9dOUHwHensCCX+Feyrn9qrpjlEH10Wb4lvDtfMYy9/kuh3wXL EyymhIdtwHms9hbBm0/BIJaGUCr9QK4bRtrmBH6nUg+b8YLBOspktp3IMp5g25V11j37wVhZVB87Z tmVkESng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTfKS-0000000A1Gn-1M8B; Tue, 16 Jul 2024 10:22:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTfK6-0000000A1C9-1j6i for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2024 10:22:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78BB31063; Tue, 16 Jul 2024 03:22:32 -0700 (PDT) Received: from [10.163.52.225] (unknown [10.163.52.225]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 012EF3F762; Tue, 16 Jul 2024 03:21:58 -0700 (PDT) Message-ID: Date: Tue, 16 Jul 2024 15:51:55 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 16/29] arm64: add pte_access_permitted_no_overlay() To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-17-joey.gouly@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20240503130147.1154804-17-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_032219_464067_119CE33F X-CRM114-Status: GOOD ( 14.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/3/24 18:31, Joey Gouly wrote: > We do not want take POE into account when clearing the MTE tags. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon Reviewed-by: Anshuman Khandual > --- > arch/arm64/include/asm/pgtable.h | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 5c970a9cca67..2449e4e27ea6 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -160,8 +160,10 @@ static inline pteval_t __phys_to_pte_val(phys_addr_t phys) > * not set) must return false. PROT_NONE mappings do not have the > * PTE_VALID bit set. > */ > -#define pte_access_permitted(pte, write) \ > +#define pte_access_permitted_no_overlay(pte, write) \ > (((pte_val(pte) & (PTE_VALID | PTE_USER)) == (PTE_VALID | PTE_USER)) && (!(write) || pte_write(pte))) > +#define pte_access_permitted(pte, write) \ > + pte_access_permitted_no_overlay(pte, write) > #define pmd_access_permitted(pmd, write) \ > (pte_access_permitted(pmd_pte(pmd), (write))) > #define pud_access_permitted(pud, write) \ > @@ -348,10 +350,11 @@ static inline void __sync_cache_and_tags(pte_t pte, unsigned int nr_pages) > /* > * If the PTE would provide user space access to the tags associated > * with it then ensure that the MTE tags are synchronised. Although > - * pte_access_permitted() returns false for exec only mappings, they > - * don't expose tags (instruction fetches don't check tags). > + * pte_access_permitted_no_overlay() returns false for exec only > + * mappings, they don't expose tags (instruction fetches don't check > + * tags). > */ > - if (system_supports_mte() && pte_access_permitted(pte, false) && > + if (system_supports_mte() && pte_access_permitted_no_overlay(pte, false) && > !pte_special(pte) && pte_tagged(pte)) > mte_sync_tags(pte, nr_pages); > }