From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2DB0CD11C2 for ; Sun, 7 Apr 2024 08:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v4WaAmpb40kWWxhIDMzMxiPiwGi8MJe3983dgjuJOOA=; b=Fs4FnC6pb3ogx7 1AKUdnR7S4A4CE5+Vj5f9YPmpeNmea755Bemr9gc6l5WFr1asw9sWYW9xLjfZsdYw/Bjhv0b9pBiC +pyo1KC3RaJlvZWGpnXpt4qwDPL2lsik23j8JGrxHCg9bJiCvve2HslTEWoPmRNExJCOmkCUXvkLS TRhrXA5ePvvdLGDoIZcOimmH+xwRCABV4vj3JVwwSmM9WRVz/IsJRM7WhBXM9FjQwfLHW2kQnBKS7 bJH89F2DgGwzUZV1LUWCjS9+C0PsctZ7dJvMhM+vlFL6tjApma5WpPMiVIwNeFGrGPRycjdQh9Cdd XHBKv9WJjw5llR5GAAnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtOKt-0000000C9rf-0O9u; Sun, 07 Apr 2024 08:57:11 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtOKp-0000000C9qi-3u3Y for linux-arm-kernel@lists.infradead.org; Sun, 07 Apr 2024 08:57:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E720060C17; Sun, 7 Apr 2024 08:57:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FEABC433F1; Sun, 7 Apr 2024 08:57:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712480226; bh=1UmJRBIshTbsNwOgZA2SDcfXRmjyJJJe+7oDBNgAf30=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=i9n3FMDooGJnPJbxeHPBkUwJYKIArbiPKkYdJ+i4VzW3zkHL7/gh9OS4kVfo7E8vA TcFSFEbzZp1RNt7/5hiHsTE+5SHb254FcBCWLASA+czYxiTK4oP2GRoAHXo8+nS12F rmThpFWbRfbGneYzJRN+Jm3TflUS9CRuD1LpSW15M0vMTpi4iA6I23aoeoU4LB5D38 QGXcX7/iGBQ0pcHr3DpVpE7mtYU4fNENIixnITwRlujbSg6+Hr08F7ab+HzGO0lEVn ro0EumLzfOqhbgaXMDjlUdacBxg1+iHe/Idz+WMtdsb0tX0T0sI+m/GNevGrVkcFBI 3HrU8pRFFA5/w== Message-ID: Date: Sun, 7 Apr 2024 10:57:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI Extension protocol To: Peng Fan , "Peng Fan (OSS)" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sudeep Holla , Cristian Marussi Cc: "devicetree@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20240405-imx95-bbm-misc-v2-v2-0-9fc9186856c2@nxp.com> <20240405-imx95-bbm-misc-v2-v2-2-9fc9186856c2@nxp.com> <9aab8dab-27c4-40b6-b1d5-0a2babe0700d@kernel.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240407_015708_162451_081BB727 X-CRM114-Status: GOOD ( 23.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/04/2024 02:51, Peng Fan wrote: >> Subject: Re: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI Extension >> protocol >> >> On 05/04/2024 14:39, Peng Fan (OSS) wrote: >>> From: Peng Fan >>> >>> Add i.MX SCMI Extension protocols bindings for: >>> - Battery Backed Secure Module(BBSM) >> >> Which is what? > > I should say BBM(BBSM + BBNSM), BBM has RTC and ON/OFF > key features, but BBM is managed by SCMI firmware and exported > to agent by BBM protocol. So add bindings for i.MX BBM protocol. > > Is this ok? No, I still don't know what is BBSM, BBNSM and BBM. > >> >>> - MISC settings such as General Purpose Registers settings. >>> >>> Signed-off-by: Peng Fan >>> --- >>> .../devicetree/bindings/firmware/imx,scmi.yaml | 80 >> ++++++++++++++++++++++ >>> 1 file changed, 80 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/firmware/imx,scmi.yaml >>> b/Documentation/devicetree/bindings/firmware/imx,scmi.yaml >>> new file mode 100644 >>> index 000000000000..7ee19a661d83 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/firmware/imx,scmi.yaml >>> @@ -0,0 +1,80 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) # Copyright 2024 >>> +NXP %YAML 1.2 >>> +--- >>> +$id: >>> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi >>> >> +cetree.org%2Fschemas%2Ffirmware%2Fimx%2Cscmi.yaml%23&data=05%7 >> C02%7Cp >>> >> +eng.fan%40nxp.com%7C5d16781d3eca425a342508dc562910b7%7C686ea >> 1d3bc2b4c >>> >> +6fa92cd99c5c301635%7C0%7C0%7C638479981570959816%7CUnknown% >> 7CTWFpbGZsb >>> >> +3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn >> 0%3D >>> >> +%7C0%7C%7C%7C&sdata=mWNwPvu2eyF18MroVOBHb%2Fjeo%2BIHfV5V >> h%2F9ebdx65MM >>> +%3D&reserved=0 >>> +$schema: >>> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi >>> +cetree.org%2Fmeta- >> schemas%2Fcore.yaml%23&data=05%7C02%7Cpeng.fan%40nx >>> >> +p.com%7C5d16781d3eca425a342508dc562910b7%7C686ea1d3bc2b4c6fa >> 92cd99c5c >>> >> +301635%7C0%7C0%7C638479981570971949%7CUnknown%7CTWFpbGZs >> b3d8eyJWIjoiM >>> >> +C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7 >> C%7C%7 >>> >> +C&sdata=v4XnGG00D4I8j5MJvDUVYMRTm7yRrvz0V3fUyc5KAAA%3D&reser >> ved=0 >>> + >>> +title: i.MX System Control and Management Interface(SCMI) Vendor >>> +Protocols Extension >>> + >>> +maintainers: >>> + - Peng Fan >>> + >>> +allOf: >>> + - $ref: arm,scmi.yaml# >> >> Sorry, but arm,scmi is a final schema. Is your plan to define some common >> part? > > No. I just wanna add vendor extension per SCMI spec. > > 0x80-0xFF: > Reserved for vendor or platform-specific extensions to this interface > > Each vendor may have different usage saying id 0x81, so I add > i.MX dt-schema file. > >> >>> + >>> +properties: >>> + protocol@81: >>> + $ref: 'arm,scmi.yaml#/$defs/protocol-node' >>> + unevaluatedProperties: false >>> + description: >>> + The BBM Protocol is for managing Battery Backed Secure Module >> (BBSM) RTC >>> + and the ON/OFF Key >>> + >>> + properties: >>> + reg: >>> + const: 0x81 >>> + >>> + required: >>> + - reg >>> + >>> + protocol@84: >>> + $ref: 'arm,scmi.yaml#/$defs/protocol-node' >>> + unevaluatedProperties: false >>> + description: >>> + The MISC Protocol is for managing SoC Misc settings, such as >>> + GPR settings >> >> Genera register is not a setting... this is a pleonasm. Please be more specific >> what is the GPR, MISC protocol etc. > > The MISC Protocol is for managing SoC Misc settings, such as SAI MCLK/MQS in > Always On domain BLK CTRL, SAI_CLK_SEL in WAKEUP BLK CTRL, gpio > expanders which is under control of SCMI firmware. So like a bag for everything which you do not want to call something specific? No, be specific... > >>> + >>> + properties: >>> + reg: >>> + const: 0x84 >>> + >>> + wakeup-sources: >>> + description: >>> + Each entry consists of 2 integers, represents the source >>> + and electric signal edge >> >> Can you answer questions from reviewers? > > Sorry. Is this ok? > minItems: 1 > maxItems: 32 No. Does it answers Rob's question? I see zero correlation to his question. Do not ignore emails from reviewers but respond to them. > >> >>> + items: >>> + items: >>> + - description: the wakeup source >>> + - description: the wakeup electric signal edge >>> + $ref: /schemas/types.yaml#/definitions/uint32-matrix >>> + >>> + required: >>> + - reg >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + firmware { >>> + scmi { >>> + compatible = "arm,scmi"; >> >>> + mboxes = <&mu2 5 0>, <&mu2 3 0>, <&mu2 3 1>; >>> + shmem = <&scmi_buf0>, <&scmi_buf1>; >>> + >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + protocol@81 { >>> + reg = <0x81>; >>> + }; >>> + >>> + protocol@84 { >>> + reg = <0x84>; >>> + wakeup-sources = <0x8000 1 >>> + 0x8001 1 >>> + 0x8002 1 >>> + 0x8003 1 >>> + 0x8004 1>; >> >> Nothing improved... If you are going to ignore reviews, then you will only get >> NAKed. > > Sorry, you mean the examples, or the whole dt-schema? *Read comments and respond to them*. Regardless where they are. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel