From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C01AFC05027 for ; Wed, 8 Feb 2023 15:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1fTcjPCGHaa08ot5qlzu6euC0y9yaeq4Ck/3hd6LXQA=; b=QAd6A1OClXgRRl t7jxR59wUa4rCGVj6kVeCs5AGqrEF4Y6njsZn6QQZRd/z9XOtvOz1E0z/nPJwcXG9zbebwtJI3Cea CT5Zbs15nsV74OU3SMehv6HXkzog5l+AsoydMFrpNxWubT8ij98wIjEvudMhOcU+Zl7RF14SOQZOg YW1vpQztz3OW3PkvPKqSl29zWhgRhe32ardvlVMeYKeIx7r4im5ubZDlk21mkoyXP3nC2yAjNtL1H 3YudrapK/P8uD+zw9WchVaf/vOrYHvrmh8qS5XExcH/BCTaaJDFWQLD44GTY9qFGgrDj/vIDtC7TE 5CpYywanIg4VMFCpx2gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPmI4-00G4Xp-L5; Wed, 08 Feb 2023 15:23:20 +0000 Received: from mga05.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPmI1-00G4Wd-L5 for linux-arm-kernel@lists.infradead.org; Wed, 08 Feb 2023 15:23:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675869797; x=1707405797; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+6lc2JZe7pOZJ+ZEzzeo5NMYX3WZ0aaZEmIs4Fc6h+c=; b=QimJUARlwFZyQQUD3OZTx+HNNO0UVwIMHQxqbj0CU5m4d7XiVh50vwse jYaNTYGkDBp610g9EW1bajRD/s2ZZ3C+bbX0EK5uPl+ha0YxTLhCS200p oqBYMqb4wXQlkEhuxEnoNNuFZqGXmcg8B2vAyD9/BOZ0W5K1GdwfuIrOM xunKT6yHDLtzCQ9RskLjnCVO5Y2mDKqxzf+Vb2wyYvEoBF+pg+eeff4bq jcpM2RqfVqYbzOAs0SZSUgU5h0sFyDkkF/IZn+5tajhALMve0E/EMJLAy EAgNmOhrpHGwEoM+6CHfEb6mx1G/PqOb/qrRS9QVXcBqaaEBoU8lqfyj3 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="416045859" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="416045859" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 07:17:16 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="669224186" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="669224186" Received: from tbacklun-mobl.amr.corp.intel.com (HELO [10.209.14.225]) ([10.209.14.225]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 07:17:16 -0800 Message-ID: Date: Wed, 8 Feb 2023 07:17:15 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 3/3] efi: x86: Wire up IBT annotation in memory attributes table Content-Language: en-US To: Ard Biesheuvel , linux-efi@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Kees Cook , Mark Rutland , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen References: <20230206124938.272988-1-ardb@kernel.org> <20230206124938.272988-4-ardb@kernel.org> From: Dave Hansen In-Reply-To: <20230206124938.272988-4-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230208_072317_736603_EF281B53 X-CRM114-Status: UNSURE ( 9.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/6/23 04:49, Ard Biesheuvel wrote: > --- a/arch/x86/kernel/apm_32.c > +++ b/arch/x86/kernel/apm_32.c > @@ -609,7 +609,7 @@ static long __apm_bios_call(void *_call) > > apm_irq_save(flags); > firmware_restrict_branch_speculation_start(); > - ibt = ibt_save(); > + ibt = ibt_save(true); My only nit with these is the bare use of 'true'/'false'. It's impossible to tell at the call-site what the 'true' means. So, if you happen to respin these and see a nice way to remedy this I'd appreciate it. But they're still OK as-is. For the x86 bits: Acked-by: Dave Hansen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel