linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: chripell@fsfe.org (christian pellegrin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] Fix GPIOs bank H and J not being preserved during suspend
Date: Mon, 8 Mar 2010 17:14:05 +0100	[thread overview]
Message-ID: <cabda6421003080814j2e17b664x1806a418928e09d4@mail.gmail.com> (raw)
In-Reply-To: <20100308155522.GE24864@trinity.fluff.org>

On Mon, Mar 8, 2010 at 4:55 PM, Ben Dooks <ben-linux@fluff.org> wrote:
>
> Still not getting why you're changing this from x, to x - 1.
>

ok: the reason is that gpio_nr is already incremented by one in the
for instruction. So gpio_nr is not pointing to the first pin of a bank
after the first iteration. Of course this doesn't matter because we
don't have 32 banks of gpio pins and s3c_gpiolib_getchip works even if
we point to a pin in the middle of a bank. But if we get a s3c device
with more than 32 banks the 33rd will be skipped. Or at least this is
the reason why I did this, maybe I'm mistaken.

Anyway this is a minor point, I fixed it when catching why bank H was
not preserved (and so my serial console ttyS1 was dead).

-- 
Christian Pellegrin, see http://www.evolware.org/chri/
"Real Programmers don't play tennis, or any other sport which requires
you to change clothes. Mountain climbing is OK, and Real Programmers
wear their climbing boots to work in case a mountain should suddenly
spring up in the middle of the computer room."

  reply	other threads:[~2010-03-08 16:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-02 16:05 [PATCH] This patch adds support for GPIO bank J present on S3C244X CPUs. It Christian Pellegrin
2010-03-02 16:11 ` christian pellegrin
2010-03-02 16:11   ` [PATCH resend v2.6.33] Fix support for banks H and J on S3C244X CPUs Christian Pellegrin
2010-03-02 21:54 ` [PATCH] This patch adds support for GPIO bank J present on S3C244X CPUs. It Ben Dooks
2010-03-03  6:58   ` christian pellegrin
2010-03-03  7:00     ` [PATCH] Adds support for banks H and J on S3C244X CPUs Christian Pellegrin
2010-03-03  8:24       ` omap gpio help doron
2010-03-03  7:00     ` [PATCH] Fix GPIOs bank H and J not being preserved during suspend Christian Pellegrin
2010-03-04 23:21       ` Ben Dooks
2010-03-08 11:17         ` christian pellegrin
2010-03-08 11:21           ` [PATCH v2] " Christian Pellegrin
2010-03-08 15:55             ` Ben Dooks
2010-03-08 16:14               ` christian pellegrin [this message]
2010-03-08 16:16                 ` Ben Dooks
2010-03-12  7:25                   ` christian pellegrin
2010-03-12  7:28                     ` [PATCH v2] Fix GPIOs banks " Christian Pellegrin
2010-03-12  7:29                     ` [PATCH v2] Fix one-too-much bug when building list of regs to be preserved on PM Christian Pellegrin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cabda6421003080814j2e17b664x1806a418928e09d4@mail.gmail.com \
    --to=chripell@fsfe.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).