From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF82DC2BA4C for ; Tue, 30 Nov 2021 11:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M4LCXxbpTCkk6Wh5katOa+GFHjv3RkDZwHCswbazues=; b=FVPE9ercFg7sX7 yKrB0TPwmva/sJwB34KVieN+Vb2LLDa5R529OFrUQnOwAPUg9uP3LkUJlN1AAcepcDsRGC2Ac0ZwY z0RfDjgrGJZyvahDDTnp5HIBmTm9RppGVh1QyHNCnK9NUyUZZ6HVCYN6ITHe2EoHbjNom1cTPcs+w smoPPlD62iLJHgXaEIH3KW5TbOIZiI/6NdRrLqTxjFjf21KwrVY36dLFy/12acBV1G3dRwP3lTPba 9oC93DLZShDdrrhG9+SCrI/nNktDWWANMVZXtPKBrr2N/CGFFi4q0NJBrNS8EJEKhc9tEefiMTiUf z/Jup14y8vWTEY4rBx1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms1aH-004vEZ-CK; Tue, 30 Nov 2021 11:46:05 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms1aC-004vAt-A2; Tue, 30 Nov 2021 11:46:02 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 89D33B81853; Tue, 30 Nov 2021 11:45:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B290C53FD2; Tue, 30 Nov 2021 11:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638272758; bh=NaJPt5ZfhcOqGwPuUoJxkdXpkvIfXMuvm1EjiLlhrA8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=l6SVrj96Z9TEcxscLwygYJqGqnP8XY6ccBjU5L1bUR0Xu+aCdPbem7raqQp1lWlj3 zyjudDEyIVFZ4AggYGgiY3bT1/KgrszWwdWGwY6ifHsyaOm3Ojxrmc0o7GfOflxJ/U zcU6cu6hqs1uyOJraEnZKJiu3bI/j/7EKsJXAEBCWcuW32wNZfq1jUq7Y6Xfl+jrA+ rEfivr+GXb8t0jthTGX8x5nfZxPGd8oKGba6Bv6gh1U3fO8L1asf8sNAPIUX9Zgwlv GZ2wlmvH/taqmPK+IxH90TobtHa1yWSSdiOmOoj565egkY0sgto89YFvVuFXIYWfv4 kblF0b/QpOLaQ== Message-ID: Subject: Re: [PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline From: nicolas saenz julienne To: Maxime Ripard , Scott Branden , Rob Herring , Frank Rowand , Ray Jui , Florian Fainelli , Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann Cc: linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Date: Tue, 30 Nov 2021 12:45:49 +0100 In-Reply-To: <20211117145040.334827-1-maxime@cerno.tech> References: <20211117145040.334827-1-maxime@cerno.tech> User-Agent: Evolution 3.42.1 (3.42.1-1.fc35) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_034600_556711_B86E644A X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, On Wed, 2021-11-17 at 15:50 +0100, Maxime Ripard wrote: > Hi, > > The VC4 driver has had limited support to disable the HDMI controllers and > pixelvalves at boot if the firmware has enabled them. > > However, this proved to be limited, and a bit unreliable so a new firmware > command has been introduced some time ago to make it free all its resources and > disable any display output it might have enabled. > > This series takes advantage of that command to call it once the transition from > simplefb to the KMS driver has been done. I think it would make sense to integrate this funtionality into 'reset/reset-raspberrypi.c' and pass it to VC4 as a reset controller. It fits the same startup situation as the one we have with the USB controller. Also, it would contain the firmware weirdness in a single spot. Otherwise, please use 'devm_rpi_firmware_get()'. Regards, Nicolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel