From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00E9EC433DB for ; Wed, 23 Dec 2020 04:58:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72F37223C8 for ; Wed, 23 Dec 2020 04:58:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72F37223C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vBFqHTE2zguOQ07hR3Y77IM0fFfAxlF2g630k3R4ADY=; b=23kjCTL6p4aSD4J1zq3gcXnIe f+RzcCAZ7LvVFNyDxyGB/X7lfi0Yh5+adqVhxzv/wDxqldhOScRh1OGFPfj+cPJ7QEDPedr/Ch7Pb JOhWaBq32mZH922/cnyDXlS7ptOJfP432TH+hpnSVe6rAkdV+PjqXfEIW3j9KHGPsMmM52RitxBiq UNB0XNmOIROkwmQq+UX5Eja5ja1F34jHAQrcYmi72UAcKGasoixxFY41ExveSPA+/gmx36VxcgaXX u6C/gguvQctMkV1Zl2X9jWfdNdSuCxBEERiYXvJfTSLwAMSaSysGPOQyZ8Z4jLuI5GCGyAqORD+0u ZTR4jFuSw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krwCi-0007MN-Lj; Wed, 23 Dec 2020 04:56:52 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krwCe-0007M3-DL for linux-arm-kernel@lists.infradead.org; Wed, 23 Dec 2020 04:56:49 +0000 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id BD2E520B7192; Tue, 22 Dec 2020 20:56:45 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BD2E520B7192 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1608699406; bh=XGD1UGZ6RZjC4xpp5KtSuriQKt2Ml3utmTd4kuwn/SE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=WrWIEPk23qk6GDC6v9DLLAM7WGqBG2c+BJWDZg0LRo3Azp7AVj9K3Bx7F/t5Wb8Xx UoGdCX5PxPaBaBWFUz/bTcPDju+dcNjrYC+dZ2cR5h/2S2qK/qiF1LuOwq0eMY6tqJ 9ck7wm9S4v8Tbqh22HOo2ttRSwuC/4+ye9E6MwG4= Subject: Re: [PATCH v13 2/6] powerpc: Move arch independent ima kexec functions to drivers/of/kexec.c To: Thiago Jung Bauermann References: <20201219175713.18888-1-nramas@linux.microsoft.com> <20201219175713.18888-3-nramas@linux.microsoft.com> <875z4tl54t.fsf@manicouagan.localdomain> From: Lakshmi Ramasubramanian Message-ID: Date: Tue, 22 Dec 2020 20:56:45 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <875z4tl54t.fsf@manicouagan.localdomain> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201222_235649_064166_D27588A2 X-CRM114-Status: GOOD ( 15.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, benh@kernel.crashing.org, bhsharma@redhat.com, tao.li@vivo.com, zohar@linux.ibm.com, paulus@samba.org, vincenzo.frascino@arm.com, frowand.list@gmail.com, sashal@kernel.org, mpe@ellerman.id.au, masahiroy@kernel.org, jmorris@namei.org, takahiro.akashi@linaro.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, serge@hallyn.com, devicetree@vger.kernel.org, pasha.tatashin@soleen.com, will@kernel.org, prsriva@linux.microsoft.com, hsinyi@chromium.org, allison@lohutok.net, christophe.leroy@c-s.fr, mbrugger@suse.com, balajib@linux.microsoft.com, dmitry.kasatkin@gmail.com, linux-kernel@vger.kernel.org, james.morse@arm.com, gregkh@linuxfoundation.org, linux-integrity@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/22/20 4:48 PM, Thiago Jung Bauermann wrote: > > Actually, I have one more comment on this patch: > > Lakshmi Ramasubramanian writes: > >> diff --git a/arch/powerpc/kexec/file_load.c b/arch/powerpc/kexec/file_load.c >> index 956bcb2d1ec2..9f3ec0b239ef 100644 >> --- a/arch/powerpc/kexec/file_load.c >> +++ b/arch/powerpc/kexec/file_load.c >> @@ -20,7 +20,6 @@ >> #include >> #include >> #include >> -#include >> >> #define SLAVE_CODE_SIZE 256 /* First 0x100 bytes */ >> >> @@ -163,12 +162,6 @@ int setup_new_fdt(const struct kimage *image, void *fdt, >> if (ret) >> goto err; >> >> - ret = setup_ima_buffer(image, fdt, fdt_path_offset(fdt, "/chosen")); >> - if (ret) { >> - pr_err("Error setting up the new device tree.\n"); >> - return ret; >> - } >> - >> return 0; >> >> err: > > With this change, setup_new_fdt() is nothing more than a call to > of_kexec_setup_new_fdt(). It should be removed, and its caller should > call of_kexec_setup_new_fdt() directly. > > This change could be done in patch 4 of this series, to keep this patch > simpler. > Sure Thiago - I will make that change. thanks, -lakshmi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel