From: Dawid Glazik <dawid.glazik@linux.intel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
linux-aspeed@lists.ozlabs.org, linux-i3c@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Frank Li <Frank.Li@nxp.com>,
Maciej Lawniczak <maciej.lawniczak@intel.com>
Subject: Re: [PATCH v3 3/3] dt-bindings: i3c: Add AST2600 I3C global registers
Date: Wed, 15 Apr 2026 20:21:48 +0200 [thread overview]
Message-ID: <cb0d16bf-988d-403e-8a8e-c85bf2a208d0@linux.intel.com> (raw)
In-Reply-To: <d74e7aa8-1110-469a-ac7e-3829c2458852@kernel.org>
On 4/9/2026 9:30 AM, Krzysztof Kozlowski wrote:
> On 09/04/2026 09:28, Krzysztof Kozlowski wrote:
>> On Wed, Apr 08, 2026 at 10:34:35PM +0200, Dawid Glazik wrote:
>>> Introduce the device-tree bindings for I3C global registers found on
>>> AST2600 SoCs.
>>>
>>> Signed-off-by: Dawid Glazik <dawid.glazik@linux.intel.com>
>>> ---
>>> I wasn't sure if I should add newline at the end of the
>>> file or not so I took
>>> https://github.com/torvalds/linux/tree/master/Documentation/devicetree/bindings/i3c
>>> as an example.
>>
>> Answer is: you cannot have patch warnings.
>>
>> Documentation/devicetree/bindings/i3c does not have patch warning, does
>> it?
>
> And if you tested this code with standard tools, you would see that...
>
> Best regards,
> Krzysztof
Thank you for the review and feedback. This is my first contribution to
Linux kernel so I'm still learning the process and toolchain. I
apologize for the rookie mistakes. I will address all the issues you've
pointed out and resubmit the series.
Best regards,
Dawid
next prev parent reply other threads:[~2026-04-15 18:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 20:34 [PATCH v3 0/3] ARM: dts: aspeed-g6: add AST2600 I3C nodes and bindings Dawid Glazik
2026-04-08 20:34 ` [PATCH v3 1/3] ARM: dts: aspeed-g6: move i2c controllers directly into apb node Dawid Glazik
2026-04-08 20:34 ` [PATCH v3 2/3] ARM: dts: aspeed-g6: Add nodes for i3c controllers Dawid Glazik
2026-04-09 7:30 ` Krzysztof Kozlowski
2026-04-09 7:31 ` Krzysztof Kozlowski
2026-04-08 20:34 ` [PATCH v3 3/3] dt-bindings: i3c: Add AST2600 I3C global registers Dawid Glazik
2026-04-08 21:35 ` Rob Herring (Arm)
2026-04-09 7:28 ` Krzysztof Kozlowski
2026-04-09 7:30 ` Krzysztof Kozlowski
2026-04-15 18:21 ` Dawid Glazik [this message]
2026-04-16 6:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb0d16bf-988d-403e-8a8e-c85bf2a208d0@linux.intel.com \
--to=dawid.glazik@linux.intel.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i3c@lists.infradead.org \
--cc=maciej.lawniczak@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox