From: Krzysztof Kozlowski <krzk@kernel.org>
To: David Leonard <David.Leonard@digi.com>,
linux-arm-kernel@lists.infradead.org
Cc: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] arm64: dts: ls1046a: add pinctrl node
Date: Tue, 27 Aug 2024 15:32:44 +0200 [thread overview]
Message-ID: <cb126c54-1cc5-4dbf-9d52-bed50834fa3b@kernel.org> (raw)
In-Reply-To: <1d7da01e-4f61-df0d-1795-5fbd78ae14b7@digi.com>
On 27/08/2024 04:13, David Leonard wrote:
>
You messages have weird blank line in front.
> Add a node for the LS1046A's pinmux controller and related pinctrl
> properties for the nodes using the gpio and i2c functions it controls.
>
> Signed-off-by: David Leonard <David.Leonard@digi.com>
> ---
> .../arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 36 +++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 200e52622f99..d2286fd6f972 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -350,6 +350,29 @@ extirq: interrupt-controller@1ac {
> };
> };
>
> + pinmux: pinmux@157040c {
pinctrl@
Keep your code consistent.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-27 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 2:13 [PATCH 5/6] arm64: dts: ls1046a: add pinctrl node David Leonard
2024-08-27 13:32 ` Krzysztof Kozlowski [this message]
2024-08-27 15:11 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb126c54-1cc5-4dbf-9d52-bed50834fa3b@kernel.org \
--to=krzk@kernel.org \
--cc=David.Leonard@digi.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).