From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B47A5C4332F for ; Wed, 13 Dec 2023 08:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PMLYb+n0xSp1RNT8+FlwnGOWTBWOYzhGBiYccLoe8HA=; b=SFCf1MOoJUcefF fOOv12Q5xCzNc7aaEHhqKmX+hkLjhlI0Cy/ULJvXVfjJ+2sILvoNNURtXq+bTq3WJS/ycBYh1Yk+D Vyl6wbOV46zV9AFKrDjvdubXxN/19zMi7blPqq8IkTBzFAKxba6pd/u3rSTHAq0qbL6s9W8QpZRj9 djp4RE2/WSR/zfZTVs0v8S4L1lRaeAfY3o84A3XFwt3+LR9z1J1ET6/bNBb2HGPPB1Ar/ol9kEWxQ Wy7Qez7n6Md84JX8R5LuP0oSP6CF3NGUgEGJY2mbs690WldStSBw/N7QXg0lHhJ06i4gqWdBixBzu kbw/sAZ2fork5d4AKoKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDKeL-00E20J-30; Wed, 13 Dec 2023 08:31:25 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDJZF-00Dulg-2d for linux-arm-kernel@bombadil.infradead.org; Wed, 13 Dec 2023 07:22:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RBgfcgQyAM0ZH2e9t97pZtF0A7py8/HaZt62MojergQ=; b=Rm50mwa8TZAYVmSA/4KC3S/GAE sGJiacGDvG86hHIBwEWfPnkIQS4P2Mhog9R2NWpgFlaAG82EK1mvL7UrW8lEvA9RvB5DhgCJLDePJ 5UR3Qekz+BI3xvPDB2iqU0kKSipPGgPJUWvX/DufTtX9SOE9ozvaZXvnOHMcHali5ljhIz8n5ZeXb 82UaJ9jJNr4DTOIAdNAoK1xhxR9FoNpo5DHSBllymwFrEqpJJYb84UfVHmqrKp5eFWjm/Tl3GCOGx +C43LwhuN5y77GoOwyA6mFATX8vcWnM0fYZ3QO6jtB6PsxFyL1tcac6efrlkaAT0LcYMkl9YCe3We 2EXpT7eA==; Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDJZB-0092XB-25 for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 07:22:04 +0000 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a1d2f89ddabso786860666b.1 for ; Tue, 12 Dec 2023 23:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702452116; x=1703056916; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RBgfcgQyAM0ZH2e9t97pZtF0A7py8/HaZt62MojergQ=; b=XngdJL0Ob6UQ6q02CN7v9UmuTyB7UUlWIbvCiKomkPZefnsuIIattnjTPb0O0ulpKU jfdr05/ZIuNMXQnRDHeUMYFqFlh6n9LEjQSwcR/yr2+FhwjuNPCV9DkSoiwecbnd6Nst C9srEuXhLc7KTv58Z3s/qrWXnnUUE5BeuN9Yis5xm65MGOBKHtIO8Z5Pv44sAETAIZfz xv+CWlateteye1MgfS7/B7fO7RuKtfDx7/FEWX7vx5FXzAOZQmGOmrV57Fcq1w1TpWDX 3sMaIrFYhp8Tp7B77MrxY8uyRWAw3nBZTAlkPl+yeUWWdaq5CO5R4FFahsUH/aWdURlA g6zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702452116; x=1703056916; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RBgfcgQyAM0ZH2e9t97pZtF0A7py8/HaZt62MojergQ=; b=nCK91lW2/xhKFaf/k0x5RLcLZNlLGOhDdQku8inywit1NYt2Xe6WZK7KDxgDo7LR4i 9H5xxmF4OrZikGjGS7NX1d6lu2XCLWRLd0QCxNoAQO2Pvv3wRdf6nab+1OFFErCOczZu 1iiwNlgiRVtewYrC6vcgCw+XYYs9vxmhThepd2S09topsp7Gfos3SD684Ua+cz/2Ht5M ne09EEwOWHbnWu4MG/MVG0rdMh4vE7XoUaWgFv94rkp4DRKFfK7G6aw0NXe1WQATPLHS eBtKRSmr68A4SXjhJzjfUa7vcUfq3N96wEbvTGJOaxK8jfUGP6R4kxIM9ON38YNCAmEc qP9A== X-Gm-Message-State: AOJu0YxmglYEdxmPniga1jZcklpE/pa2hvhpbznVS5szbviFox0wWu/l FGWVN/1a1X74jWCjRfl3fDDyVw== X-Google-Smtp-Source: AGHT+IH1OjwtFoJO2AZU9jEj+yASotY0eU0/XYtVgOtVA7CV5IX+jiPRAVK4pDGYJ0jZ4AjQCvHHPg== X-Received: by 2002:a17:906:1359:b0:a04:a274:2a0a with SMTP id x25-20020a170906135900b00a04a2742a0amr4337206ejb.73.1702452116628; Tue, 12 Dec 2023 23:21:56 -0800 (PST) Received: from localhost (h3220.n1.ips.mtn.co.ug. [41.210.178.32]) by smtp.gmail.com with ESMTPSA id si10-20020a170906ceca00b00a1e377ea789sm7187848ejb.203.2023.12.12.23.21.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 23:21:56 -0800 (PST) Date: Wed, 13 Dec 2023 10:21:52 +0300 From: Dan Carpenter To: Ryan Roberts Cc: Andrew Morton , Matthew Wilcox , Yin Fengwei , David Hildenbrand , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 04/10] mm: thp: Support allocation of anonymous multi-size THP Message-ID: References: <20231207161211.2374093-1-ryan.roberts@arm.com> <20231207161211.2374093-5-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231207161211.2374093-5-ryan.roberts@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_072202_187368_A0319A7D X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 07, 2023 at 04:12:05PM +0000, Ryan Roberts wrote: > @@ -4176,10 +4260,15 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) > /* Allocate our own private page. */ > if (unlikely(anon_vma_prepare(vma))) > goto oom; > - folio = vma_alloc_zeroed_movable_folio(vma, vmf->address); > + folio = alloc_anon_folio(vmf); > + if (IS_ERR(folio)) > + return 0; > if (!folio) > goto oom; Returning zero is weird. I think it should be a vm_fault_t code. This mixing of error pointers and NULL is going to cause problems. Normally when we have a mix of error pointers and NULL then the NULL is not an error but instead means that the feature has been deliberately turned off. I'm unable to figure out what the meaning is here. It should return one or the other, or if it's a mix then add a giant comment explaining what they mean. regards, dan carpenter > > + nr_pages = folio_nr_pages(folio); > + addr = ALIGN_DOWN(vmf->address, nr_pages * PAGE_SIZE); > + > if (mem_cgroup_charge(folio, vma->vm_mm, GFP_KERNEL)) > goto oom_free_page; > folio_throttle_swaprate(folio, GFP_KERNEL); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel