From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CFF1C3DA63 for ; Tue, 23 Jul 2024 09:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/337/xk/rcSjqNECLRfDGzePFZMdtUwX6w0PwJIMVNY=; b=Mni5frjrVtFCyMxKulwWEr+wMR 73nBDUYt6eAyzj1uHIjEqRjZ1erLQj5x8wgwx1scZiUVRuqZ3lI+atwZTd/1nZmq/405vvLJLwmoc 4Jm6E9jdm54sHT27UdqcGJYcKUWYU+kPHKd9IkbFKFPcsMGpMmf8ljJgyOuwpQM15FlLjgcsAddUB bIzZOWUp1D0UHaR3oSQYnI8ZR6j8+4Xqwx9oGCfSlp2tMbn1TRFG/rt+UyGlt3JDNMLVtLWjSA6hJ p4JcSxi7wKb5Rq/pXnUg2ALSTyLKkQ7P0prPmsm7+12Tlv1J8eX/zkM9s+fhZKbpU0f3li1Slvecw w6xBZ9Zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWBXY-0000000BwM0-2NdW; Tue, 23 Jul 2024 09:10:36 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWBXD-0000000BwKN-1gY3 for linux-arm-kernel@bombadil.infradead.org; Tue, 23 Jul 2024 09:10:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=/337/xk/rcSjqNECLRfDGzePFZMdtUwX6w0PwJIMVNY=; b=dczIp3FjPI0AwUB7I3AJEO5p4S dw6AswjuJ3l+ZcS0fdfbL8DDpsSHNXyVTShI+uMZ49uxK+sFeayvA7CFpUFK9GvBNrSc0qnO23RTh bJ75O3XsFi2MUIwPFMz9t0+0JoxFT1c9D1J0TsYHrDo+xXwQ33kF3aBqQhMlr/eCgWw+U7xsR1O1a kC3BpJi39v1+pvg1hQW07g4a/B2y5IaCCXYpaoC6NIz1FApkbaeuJ+vSm0jjzNxOsfrWtFM0dktY9 nNBIvgMeeFQf5/LaXnkRe39LL7uUyCbdVbSF3xjQJXxIetdtETSLfodCHi2oHC7bPUCGnbQB9XVO+ 7lRQ1gEw==; Received: from mgamail.intel.com ([192.198.163.15]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWBX9-00000003eTi-0mcX for linux-arm-kernel@lists.infradead.org; Tue, 23 Jul 2024 09:10:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721725811; x=1753261811; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=GUUm9SKdRyPJTlfF5XVO3Y0D5mrSIAzlwLYe2VuSGmk=; b=Xd3yBdlUkZg+RcW1l5z8ksF5vwWUDfWznvOXspt0HFPuh01OC7ufbD3e ga/xmN7I4Tf2UXzO9OSJldJ/cHgfDyAEgKxVdeZ2AjIdP6SbcGnSiXmuV f4vMc4grUdGj/kpkicXlIHZnV8G/9KMXOc0mD/d3rVmKDFgm9IVatisls oj4iWVXL6GrjGhjpNcXECz1S1tkC5S8Yng8ssfd2L9CEKjpqjAaai294D rP2G+9sg3pJNGdr0Paw7TiM+UR7q89mGS1Eku3R/NEpYaSS9s2D2qHyJb hLo9QN2k4iV0kLX5BNGk1tc1ZJz31Dqr27YG1l/msBAbJbPuYJo2Vq+7F A==; X-CSE-ConnectionGUID: e/6LsmQcQ+eneOva3BSaCw== X-CSE-MsgGUID: CR1LYS0TT/+PUKwCtXabHg== X-IronPort-AV: E=McAfee;i="6700,10204,11141"; a="19488022" X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208";a="19488022" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2024 02:09:59 -0700 X-CSE-ConnectionGUID: f55IJ0ZORHiJGO3vm5OjHQ== X-CSE-MsgGUID: Vt2JV7n6TqWgHV/eVj+m/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208";a="52172573" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.94.249.84]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2024 02:09:52 -0700 Message-ID: Date: Tue, 23 Jul 2024 12:09:46 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V9 06/13] perf tools: Enable evsel__is_aux_event() to work for S390_CPUMSF To: Arnaldo Carvalho de Melo , Namhyung Kim Cc: Ingo Molnar , Mark Rutland , Alexander Shishkin , Heiko Carstens , Thomas Richter , Hendrik Brueckner , Suzuki K Poulose , Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Yicong Yang , Jonathan Cameron , Will Deacon , Jiri Olsa , Ian Rogers , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Leo Yan , Peter Zijlstra References: <20240715160712.127117-1-adrian.hunter@intel.com> <20240715160712.127117-7-adrian.hunter@intel.com> Content-Language: en-US From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240723_101011_967696_8DF72A59 X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/07/24 11:26, Leo Yan wrote: > On 7/15/2024 5:07 PM, Adrian Hunter wrote: >> >> evsel__is_aux_event() identifies AUX area tracing selected events. >> >> S390_CPUMSF uses a raw event type (PERF_TYPE_RAW - refer >> s390_cpumsf_evsel_is_auxtrace()) not a PMU type value that could be checked >> in evsel__is_aux_event(). However it sets needs_auxtrace_mmap (refer >> auxtrace_record__init()), so check that first. >> >> Currently, the features that use evsel__is_aux_event() are used only by >> Intel PT, but that may change in the future. >> >> Signed-off-by: Adrian Hunter >> Acked-by: Ian Rogers >> Reviewed-by: Andi Kleen > > Reviewed-by: Leo Yan Namhyung, could we get patches 5 and 6 from this series applied? They are independent and Leo's new patch set is dependent on patch 5. > >> --- >> tools/perf/util/pmu.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c >> index 986166bc7c78..0b38c51bd6eb 100644 >> --- a/tools/perf/util/pmu.c >> +++ b/tools/perf/util/pmu.c >> @@ -1199,8 +1199,12 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu *pmu) >> >> bool evsel__is_aux_event(const struct evsel *evsel) >> { >> - struct perf_pmu *pmu = evsel__find_pmu(evsel); >> + struct perf_pmu *pmu; >> >> + if (evsel->needs_auxtrace_mmap) >> + return true; >> + >> + pmu = evsel__find_pmu(evsel); >> return pmu && pmu->auxtrace; >> } >> >> -- >> 2.34.1 >> >>