From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06AAECD342C for ; Wed, 6 May 2026 14:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lqwubmezLdUWi5nwdGm9inEyQvRDdNL1kdWWslX4DTM=; b=Y4mA+u8qqVd2XBA6k8mowBb0jQ OJtX18BT5qt70hWkdEZmIVwPjxYN5l9LkmuVCgTMsudcYzFgR0qQfHHKLn8Q1qdz4bgAAvXmIlwWB L5wJ0waJ3XLpSGyJGgmy/1M4r+QVOzSUZdOqnImUnBJRwaNojGzs+mfF2YPi2yMb+a4rKc9fwirO0 uYaSXdH9SBMm9GGEKv+lkwJtXNmwKgvxPOAzfm7lRFOfFnE0ePybsSAQ0JCHfevLyAAPCWIBi1eOq zH2z+l+IQzvfLvAHZXgoxq/eEHF+SGEs+ic98snfhbcD/Ukk+TFCsUpVjrZRDg1VnziD2lgsSG/E8 zB1CZ+7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKdfk-00000001CL4-37dV; Wed, 06 May 2026 14:56:24 +0000 Received: from mail-oa1-x2e.google.com ([2001:4860:4864:20::2e]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKdfi-00000001CIx-0MCj for linux-arm-kernel@lists.infradead.org; Wed, 06 May 2026 14:56:23 +0000 Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-4350cd5b97fso282970fac.0 for ; Wed, 06 May 2026 07:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778079381; x=1778684181; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=lqwubmezLdUWi5nwdGm9inEyQvRDdNL1kdWWslX4DTM=; b=HuSHiR3U6W28JpcXZ0eSs5Px+PBzHq3j6a8sA1meJ6r5gxKLdiFUwV+EIAFOLJj1er GhWxjTDQidgp+TK5jwHw5KhodbFVnfFXsDYCBCQk3b1SnupRMD3IGsMIXUrTIA/KH832 5PGJOTLR3HQ+iQNlRVb154dYHabtE0WHHtBJkfEjI425twvPWpi9pC29r17hOL/oxE0u d/DmumXqnNB5m/vjuiTbjFRLJ9V/O6x7kPwOdfmBDXtWl2MS5GhW77mt2hsvU2/+DPu8 iONeNukpi65EM+auyBhZ+3iqYSYUSB9uHkSnn9TjoAcjF4BdvjVletdHLglo0YLzGdDO VdDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778079381; x=1778684181; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lqwubmezLdUWi5nwdGm9inEyQvRDdNL1kdWWslX4DTM=; b=DKpkcPbYvLaK2PpZvIPU9IbGmXz4+Ugh04oN/N7S3WTYa1ukCSSFdp6R7YibZaWp1k IZPaJspYiTjf0VYy2S+5Ts2eYject9XKnW6VhWZwhjMgRAQQ2fEqCeVN3OTmSb2PLDd3 LQ1bPUUvZwY/PaEMfQk6kk9XRCQhYsFmxelfW9oHQqTPSX8TXODJktA0tRm+rYG1pG2y dGCI8lxE3fIVQQQozZMCNKJAXbEgdw2+IZc/PU9uWf1Bk6rHJud+Zun9pdcPvNkV+LJa XEVYLBtqF/NKW9nQ4nwBmzqhv5UmUGiQ706M+pRTBXO29sPE0fgQQWXESYcmuU1XHULx HzIw== X-Forwarded-Encrypted: i=1; AFNElJ+LB6sgB1DmO1RCVou1cvrHfWoOGQkf6Z7hEh5UoLvsZvHnbhWbBvF0RpawIrEe3FRN73HS8c9DgCAw5rURhQO4@lists.infradead.org X-Gm-Message-State: AOJu0Ywivr2SeYrwEbcj9vibtgKG5g8i4KZiOKUVcDiHalql1+bB3N9k OYzS7cHqeewBvfnYUkJmxdsGgiGnS31KSGVJxDEOT+aTm6Y7jXpJEfsKgfgsmnRi0yU= X-Gm-Gg: AeBDieuu4IXo361/YyHrHd//syYphlA8I80TFUqXZfrIG0lGSultdIuZiJE2jkqh/lQ WZTuBSJa5xswEkt0kaRDa1s6togr4QJEGXbca5K1AVSopeVRXO3uSmGtlUdwjQTr3In/ynXoW1d 6AGEAwdqB2sN/DJDsoITpWTFOyMfUKJL1o64ThPjqOJXkJhL3LqTxMXBFhoBNc7IMqqITPUgLzK 06l1rIRjun2LW6DNkD2/l6uo9kcg1PXly/7N9shmX35JqUqDPhXhf5jiAemsO7Wd8gdMwjklkTu AueTqMSSiK6UIiJ6LkDe9Po2WtP9QkHrS8m6yigPr0U9niPCHeZISCXjvFWBYu0zI2LpuJh7NPc P9yBNOYyvGNXkIRGhJcx/mK3oX+GAhPe3F6ELfkF/gSrtjCUs3k1dQVozQG7LJJh+a6e5qjg/47 94pDZDSsWL4kuYVpiabvIwrwSzpoDx3pNAItSNOl1BP2zlBNZ9pnOFb5clvjjdLwibeB+x6PLun UeQqs8bwa+TaLIlyvJuz9hjLRbJ X-Received: by 2002:a05:6871:e48b:b0:417:6237:cf7e with SMTP id 586e51a60fabf-434f5cd2ed9mr2538133fac.8.1778079380535; Wed, 06 May 2026 07:56:20 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:5798:67fd:c866:b378? ([2a01:e0a:106d:1080:5798:67fd:c866:b378]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43454d8ed0dsm15613477fac.17.2026.05.06.07.56.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 07:56:20 -0700 (PDT) Message-ID: Date: Wed, 6 May 2026 16:56:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v4 11/16] phy: rockchip: usbdp: Register DP aux bridge To: Sebastian Reichel , Vinod Koul , Heiko Stuebner , Frank Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Yan , Dmitry Baryshkov , Yubing Zhang , Alexey Charkov , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, devicetree@vger.kernel.org References: <20260428-rockchip-usbdp-cleanup-v4-0-7775671ece22@collabora.com> <20260428-rockchip-usbdp-cleanup-v4-11-7775671ece22@collabora.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260428-rockchip-usbdp-cleanup-v4-11-7775671ece22@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260506_075623_271925_3B9F5C47 X-CRM114-Status: GOOD ( 22.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/28/26 18:13, Sebastian Reichel wrote: > Add support to use USB-C connectors with the DP altmode helper code on > devicetree based platforms. To get this working there must be a DRM > bridge chain from the DisplayPort controller to the USB-C connector. > E.g. on Rockchip RK3576: > > root@rk3576 # cat /sys/kernel/debug/dri/0/encoder-0/bridges > bridge[0]: dw_dp_bridge_funcs > refcount: 7 > type: [10] DP > OF: /soc/dp@27e40000:rockchip,rk3576-dp > ops: [0x47] detect edid hpd > bridge[1]: drm_aux_bridge_funcs > refcount: 4 > type: [0] Unknown > OF: /soc/phy@2b010000:rockchip,rk3576-usbdp-phy > ops: [0x0] > bridge[2]: drm_aux_hpd_bridge_funcs > refcount: 5 > type: [10] DP > OF: /soc/i2c@2ac50000/typec-portc@22/connector:usb-c-connector > ops: [0x4] hpd > > Signed-off-by: Sebastian Reichel > --- > drivers/phy/rockchip/Kconfig | 2 ++ > drivers/phy/rockchip/phy-rockchip-usbdp.c | 14 ++++++++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig > index 14698571b607..39759bb2fa1d 100644 > --- a/drivers/phy/rockchip/Kconfig > +++ b/drivers/phy/rockchip/Kconfig > @@ -136,8 +136,10 @@ config PHY_ROCKCHIP_USBDP > tristate "Rockchip USBDP COMBO PHY Driver" > depends on ARCH_ROCKCHIP && OF > depends on TYPEC > + depends on DRM || DRM=n > select GENERIC_PHY > select USB_COMMON > + select DRM_AUX_BRIDGE if DRM_BRIDGE > help > Enable this to support the Rockchip USB3.0/DP combo PHY with > Samsung IP block. This is required for USB3 support on RK3588. > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c > index beab20e4c512..77ad2a89d4f2 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -6,6 +6,7 @@ > * Copyright (C) 2024 Collabora Ltd > */ > > +#include > #include > #include > #include > @@ -1434,6 +1435,7 @@ static int rk_udphy_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct phy_provider *phy_provider; > + struct fwnode_handle *dp_aux_ep; > struct resource *res; > struct rk_udphy *udphy; > void __iomem *base; > @@ -1492,6 +1494,18 @@ static int rk_udphy_probe(struct platform_device *pdev) > return ret; > } > > + /* > + * Only register the DRM bridge, if the DP aux channel is connected. > + * Some boards use the USBDP PHY only for its USB3 capabilities. > + */ > + dp_aux_ep = fwnode_graph_get_endpoint_by_id(dev_fwnode(dev), 3, 0, 0); > + if (dp_aux_ep) { > + ret = drm_aux_bridge_register(dev); > + fwnode_handle_put(dp_aux_ep); > + if (ret) > + return ret; > + } > + > udphy->phy_u3 = devm_phy_create(dev, dev->of_node, &rk_udphy_usb3_phy_ops); > if (IS_ERR(udphy->phy_u3)) { > ret = PTR_ERR(udphy->phy_u3); > Reviewed-by: Neil Armstrong Thanks, Neil