From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: socionext: uniphier-ld20: Add default PCI interrup controller address cells
Date: Mon, 25 Aug 2025 13:36:28 +0900 [thread overview]
Message-ID: <cb453b09-4aa0-45f4-8cf6-abcf5c625007@socionext.com> (raw)
In-Reply-To: <20250822133318.312232-3-krzysztof.kozlowski@linaro.org>
Hi Krzysztof,
On 2025/08/22 22:33, Krzysztof Kozlowski wrote:
> Add missing address-cells 0 to the PCI interrupt node to silence W=1
> warning:
>
> uniphier-ld20.dtsi:941.4-944.29: Warning (interrupt_map):
> /soc@0/pcie@66000000:interrupt-map:
> Missing property '#address-cells' in node
> /soc@0/pcie@66000000/legacy-interrupt-controller, using 0 as fallback
>
> Value '0' is correct because:
> 1. GIC interrupt controller does not have children,
> 2. interrupt-map property (in PCI node) consists of five components and
> the fourth component "parent unit address", which size is defined by
> '#address-cells' of the node pointed to by the interrupt-parent
> component, is not used (=0)
I understand that "parent unit address" is omitted, and according to
the devicetree specification, "#address-cells" define the the size of
the address. However, GIC doesn't specify the address, so this line
is needed to indicate it.
For both patches,
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
There is no tree to manage the SoC-specified commits, so please apply
this series into the DT tree.
Thank you,
---
Best Regards
Kunihiko Hayashi
next prev parent reply other threads:[~2025-08-25 4:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 13:33 [PATCH 1/2] arm64: dts: socionext: uniphier-ld20: Add default PCI interrup controller address cells Krzysztof Kozlowski
2025-08-22 13:33 ` [PATCH 2/2] arm64: dts: socionext: uniphier-pxs3: " Krzysztof Kozlowski
2025-08-25 4:36 ` Kunihiko Hayashi [this message]
2025-08-31 10:59 ` [PATCH 1/2] arm64: dts: socionext: uniphier-ld20: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb453b09-4aa0-45f4-8cf6-abcf5c625007@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).