From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CAB3C25B74 for ; Thu, 30 May 2024 13:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IhKLtQ4cvTg53q4jzQ3wpOXuJwYEJg2ahCAYTLFxwNI=; b=ZaGA3WsbXXlEoy XW+RZ7eW5n6w7Bl4VOCytuWRll/Z8nNdjhWKJz+OO8rpz9UppPHEKOf4elENMZTuRZ0J1e++OncUM 3yTovQ8hzsYtaxrnRQGBULWe4H0ibm5ZA3j0B08qs9OTHNOJx4/48NRGizdnCcoyncsBwQ7ib3y1a wkBa3ivYiGUQLVftY9bLcj3Kd1LF/+4LpKcJek1G0DAzChauAEOKjCO1KhIXe+Hk8BvtQ1rSQWuyJ rEhC364BOwItV1t/Kz0a/J6bG7Dk8PHCzJQ5fTik71G8Rgmfhz6o3m/GMgKhzrqc8n2lCSzv6P3Yt 9QMBcPL89hASdX+/29kA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCfUC-00000007JSs-0rJO; Thu, 30 May 2024 13:06:28 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCfU9-00000007JSE-2taT for linux-arm-kernel@lists.infradead.org; Thu, 30 May 2024 13:06:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717074383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jvA0ryzzUt3roYMRqzP5tcnOVKXZ+dglyNSsf/+sPrc=; b=UP3UPwLudj12oJ+Ip8IAoy3ZcXc6RcPrrRJD9j9rVSRb+ojOZq3yk85FLtVsLcPQNIRkA4 MC7h00lKU02keir95Whtn7TWxQICEW9TynE9qyDTrHSI3rj1iaioh4vpc31Gtr2aPHtufs fWeg2r5u8+UDZNJOZjCnuLq3xfUft/E= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-VDNStCIZOICKv8-ySDl_oQ-1; Thu, 30 May 2024 09:06:21 -0400 X-MC-Unique: VDNStCIZOICKv8-ySDl_oQ-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6ad75327e0cso7936796d6.1 for ; Thu, 30 May 2024 06:06:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717074380; x=1717679180; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jvA0ryzzUt3roYMRqzP5tcnOVKXZ+dglyNSsf/+sPrc=; b=Bne4h7eTdilPaEO3yXHWhdFBZa+gdolDwzglawJtVbaBzRi09WbSbs5iDMKWm2/MPC 5jmBPzbhrlbgP90WpHUvR0mpxvVlmDLES1lpVo1Q5GjJO9wIKwAed7I349rhn3g1LvG2 okKcBh0E3o442MgWfwCxTka6K4Oqk+F0YNKrwH8KkZhIdgI4NrIDbttqqyeVahvZ/1Cp gdobZHd1QBwoUxHav14No+ATiFe/NhIPNBEz1JQTujn/wP2hY/vQ/S+b9w1/eZfMPTov PF0oC98RabVfEfy0BnBixksEE56kvNbkH8RF7T5f9ahLLjz9AaCXrzrczG3aQQphoDhB Bo6g== X-Gm-Message-State: AOJu0Yw42YitFxwKbWHVVlOy4jaOf7nVFBP8BBYRGPXolqcuSGsIjqo3 ZIW0MM93M5+ULsnLF9MpWpiP+cy7Q5gDfd2bsSYpElR6MkIHLicEa+oZftrbLm0nWBLeUm4AxNd 56tk3Y1hIvrc+d+PST/pnc6yOSXOcqwt87D99wUCIIoRnUYdY85dPrYHqPds9cjxix1BL4Xh8dY hqt8cV X-Received: by 2002:a05:6214:328e:b0:6ae:aa5:7f6b with SMTP id 6a1803df08f44-6ae0cb37645mr22842566d6.34.1717074379965; Thu, 30 May 2024 06:06:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgjLeINZAgLWz2gTTl6s/+ViKd4/Ddlih3N/x2boBgxfykUZQvC57xL0+8+w6vA4N0jLzi3w== X-Received: by 2002:a05:6214:328e:b0:6ae:aa5:7f6b with SMTP id 6a1803df08f44-6ae0cb37645mr22842176d6.34.1717074379443; Thu, 30 May 2024 06:06:19 -0700 (PDT) Received: from [10.26.1.93] ([66.187.232.136]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ac16308238sm63418416d6.119.2024.05.30.06.06.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 May 2024 06:06:18 -0700 (PDT) Message-ID: Date: Thu, 30 May 2024 09:06:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ACPI: Do not enable ACPI SPCR console by default on arm64 To: Liu Wei , catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, liuwei09.cestc.cn@cecloud.com References: <20240530015332.7305-1-liuwei09@cestc.cn> From: Prarit Bhargava In-Reply-To: <20240530015332.7305-1-liuwei09@cestc.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240530_060625_848358_20025076 X-CRM114-Status: GOOD ( 17.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/29/24 21:53, Liu Wei wrote: > Consistency with x86 and loongarch, don't enable ACPI SPCR console > by default on arm64 > > Signed-off-by: Liu Wei > --- > arch/arm64/kernel/acpi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c > index dba8fcec7f33..1deda3e5a0d2 100644 > --- a/arch/arm64/kernel/acpi.c > +++ b/arch/arm64/kernel/acpi.c > @@ -227,7 +227,8 @@ void __init acpi_boot_table_init(void) > if (earlycon_acpi_spcr_enable) > early_init_dt_scan_chosen_stdout(); > } else { > - acpi_parse_spcr(earlycon_acpi_spcr_enable, true); > + /* Do not enable ACPI SPCR console by default */ > + acpi_parse_spcr(earlycon_acpi_spcr_enable, false); > if (IS_ENABLED(CONFIG_ACPI_BGRT)) > acpi_table_parse(ACPI_SIG_BGRT, acpi_parse_bgrt); > } It's been a while, and the status of arm hardware may have changed. IIRC the choice to force enable this is that most arm hardware is headless and this was a _required_ option for booting. I'm not sure if that's still the case as it's been a long time. Can anyone from the ARM community provide an approval here? P. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C72ACC25B74 for ; Fri, 31 May 2024 01:52:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4NpB9umDhJH4uvoeZjp9pbEephMzqrrtWSf8wr7+ERA=; b=Vu8NG93slLZA2O OHytkijn51Cao1NEEvOQbfhrThJJ6MB22h9cew46oqSj3JOR00ZpQl8pju1gqZ9oaun5eklNv2+P+ IvRPUp4uuH0X8KXn7W+pEUEjf+wXRKLqFgn1jXCDaToiT/sMZr5DwcsF+prAJOtwcDKwddFTTnGjs obBdgAro8ZRqXG+89OtJHCWjUoxVkiUMd3GYNFyV1Rfd4wLGZH9E0t2u0KR/HSB6MJEMuedw2Fa+f x5YWlwyr4laSp6gI+Lcdwr4J7DED5/YW40Ev7z/EmWy04LlCOirgZv2kJhLSHj40xhHFUU0tSXuf4 SPR5GCGaL4vCe9mKWlOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCrRi-00000008y4X-06Ka; Fri, 31 May 2024 01:52:42 +0000 Received: from [1.203.97.240] (helo=smtp.cecloud.com) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCrRZ-00000008y3T-3K4C for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2024 01:52:38 +0000 Received: from localhost (localhost [127.0.0.1]) by smtp.cecloud.com (Postfix) with ESMTP id 8C10E90011B; Fri, 31 May 2024 09:52:23 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ANTISPAM-LEVEL: 2 X-ABS-CHECKED: 0 Received: from localhost.localdomain (unknown [111.48.58.12]) by smtp.cecloud.com (postfix) whith ESMTP id P894637T281472896332144S1717120342486087_; Fri, 31 May 2024 09:52:23 +0800 (CST) X-IP-DOMAINF: 1 X-RL-SENDER: liuwei09@cestc.cn X-SENDER: liuwei09@cestc.cn X-LOGIN-NAME: liuwei09@cestc.cn X-FST-TO: prarit@redhat.com X-RCPT-COUNT: 6 X-LOCAL-RCPT-COUNT: 1 X-MUTI-DOMAIN-COUNT: 0 X-SENDER-IP: 111.48.58.12 X-ATTACHMENT-NUM: 0 X-UNIQUE-TAG: <666a897c7f365ab69d3846c267c805c7> X-System-Flag: 0 From: Liu Wei To: prarit@redhat.com, Liu Wei , catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI: Do not enable ACPI SPCR console by default on arm64 Date: Fri, 31 May 2024 09:52:08 +0800 Message-ID: (raw) X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240530015332.7305-1-liuwei09@cestc.cn> References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240530_185234_032370_4E8B4980 X-CRM114-Status: GOOD ( 23.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Message-ID: <20240531015208.P3G15KQ6cwzdRomaeSOEM_3c6xeGDXLrV5ftzBngnIA@z> From: Prarit Bhargava On 5/29/24 21:53, Liu Wei wrote: > > Consistency with x86 and loongarch, don't enable ACPI SPCR console > > by default on arm64 > > > > Signed-off-by: Liu Wei > > --- > > arch/arm64/kernel/acpi.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c > > index dba8fcec7f33..1deda3e5a0d2 100644 > > --- a/arch/arm64/kernel/acpi.c > > +++ b/arch/arm64/kernel/acpi.c > > @@ -227,7 +227,8 @@ void __init acpi_boot_table_init(void) > > if (earlycon_acpi_spcr_enable) > > early_init_dt_scan_chosen_stdout(); > > } else { > > - acpi_parse_spcr(earlycon_acpi_spcr_enable, true); > > + /* Do not enable ACPI SPCR console by default */ > > + acpi_parse_spcr(earlycon_acpi_spcr_enable, false); > > if (IS_ENABLED(CONFIG_ACPI_BGRT)) > > acpi_table_parse(ACPI_SIG_BGRT, acpi_parse_bgrt); > > } > > It's been a while, and the status of arm hardware may have changed. > IIRC the choice to force enable this is that most arm hardware is > headless and this was a _required_ option for booting. > > I'm not sure if that's still the case as it's been a long time. > > Can anyone from the ARM community provide an approval here? > > P. Though most ARM devices are headless, with the increasing number of ARM servers or desktops, if the SPCR table from ACPI is still used as the default console on ARM, the console behavior on ARM architecture will differ from other architecture servers. A similar effect can be achieved by adding console=tty0 in kernel cmdline, but I think it is important to ensure consistency among different architecture strategies as much as possible. Thanks for your patient explanation. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel