From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8CB2C2BA18 for ; Fri, 21 Jun 2024 00:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h5dRVJQy35axM2JOoP1ujWmkMFeh76MXxL7uKyuYIiQ=; b=Dga3if8+BRJFPTtfdFOgs71c3X gwD9HtbQKJJSqsT6wzQEK+j34Md5X7IXXSjY0t3sWtqc71mJFPaAuYo5KntZDmfEKMiGq4O1Hi/zP TKn0E5AFUC1xPz3Jpr3+5wnnlc5i6lhOxWqk+NIKepTa0FhtDb/QdihiUeIjrl5y7Z/8s318l7wRz zoy/uujv0SprhlxXbSThgw6iFvwrxE/SkhyiJoVFGs+g87+NDjLMvtXoMi9WGRlG9Ac8QMURcrUG6 vSHGAMjA23+GPw/VDLD7wt+wXHGRa6iNdmPW4CQSA6Qr8aIsP/Tktx/bbTXUSSeP4LxWaj8Uttk4w YEQHO8pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKSPz-00000007GUe-27zW; Fri, 21 Jun 2024 00:46:19 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKSPv-00000007GTt-2LTc for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 00:46:17 +0000 Received: from [192.168.68.112] (ppp118-210-79-194.adl-adc-lon-bras32.tpg.internode.on.net [118.210.79.194]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 2CAFB200DD; Fri, 21 Jun 2024 08:46:05 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1718930767; bh=h5dRVJQy35axM2JOoP1ujWmkMFeh76MXxL7uKyuYIiQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=NcKP2jFDsy3aMiuCUjlJitK0s9yShifLgb5vm28MeUlTnqmsgIp2/PB/VucMSCcam rahb68dvUNUlRGuJLadUjLmlZyg5/xoUVx5+1fonqn74wt+ZNf6Pv4cC6jg+SbFsG0 9tBbVGebycFgyuWCj8qS7N+BEDOXWYM2ZaLNjWxFcmQRnED1f90H7bjWCtby4463L5 wYLVxi8+FCcI31bL1vNMRorlVeZUg1cO4UskuRdTP6KT/0dN6oWOM267KRvzkQ25C6 bTBAbXaNEcm60jQWPg7NbyZJ+twyZH+VQZrw6MBmjZAMWhhagHHjZqNQbMtlT5xrbC JuOc4S7LikPEA== Message-ID: Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: aspeed,ast2600-pinctrl: add NCSI group From: Andrew Jeffery To: Potin Lai , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Patrick Williams , Cosmo Chou , Potin Lai , Krzysztof Kozlowski Date: Fri, 21 Jun 2024 10:16:04 +0930 In-Reply-To: <20240620084337.3525690-2-potin.lai.pt@gmail.com> References: <20240620084337.3525690-1-potin.lai.pt@gmail.com> <20240620084337.3525690-2-potin.lai.pt@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_174615_939897_22315874 X-CRM114-Status: GOOD ( 18.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Potin, On Thu, 2024-06-20 at 16:43 +0800, Potin Lai wrote: > In the NCSI pin table, the reference clock output pin (RMIIXRCLKO) is not > needed on the management controller side. >=20 > Add NCSI group to distinguish the pin group between RMII and NCSI. >=20 > - RMII pins: > - RMIIXRCLKI > - RMIIXRXD0 > - RMIIXRXD1 > - RMIIXCRSDV > - RMIIXRXER > - RMIIXRCLKO > - RMIIXTXEN > - RMIIXTXD0 > - RMIIXTXD1 >=20 > - NCSI pins: > - RMIIXRCLKI > - RMIIXRXD0 > - RMIIXRXD1 > - RMIIXCRSDV > - RMIIXRXER > - RMIIXTXEN > - RMIIXTXD0 > - RMIIXTXD1 I think listing all the pins for both groups obscures the fact that there aren't more changes than removing RMIIXRCLKO. Can we instead drop these lists and replace > Add NCSI group to distinguish the pin group between RMII and NCSI. With: > Add "NCSI" pin groups that are equivalent to the RMII pin groups, > but without the RMIIXRCLKO pin ? >=20 > Acked-by: Krzysztof Kozlowski > Signed-off-by: Potin Lai > --- > .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pin= ctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctr= l.yaml > index 00b6974a5ed3d..3f02dc94a7ce2 100644 > --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.ya= ml > +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.ya= ml > @@ -337,6 +337,8 @@ additionalProperties: > - MDIO2 > - MDIO3 > - MDIO4 > + - NCSI3 > + - NCSI4 Can we also do this for RMII{1,2}RCLKO (and in the driver patch as well)? > - NCTS1 > - NCTS2 > - NCTS3 Overall, what I was hoping for with the comment on the earlier patch was that you would add the discussion in the commit message to the "description" entry in the binding YAML. Can you please do so? That way the information is always present for people reading the binding without them having to look at the binding's change history. Thanks, Andrew