* [PATCH] arm64: defconfig: Enable CONFIG_PHY_RCAR_GEN3_PCIE
@ 2018-11-13 15:22 Geert Uytterhoeven
2018-11-14 15:32 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2018-11-13 15:22 UTC (permalink / raw)
To: linux-arm-kernel
Enable R-Car Gen3 PCIe PHY support, which is needed for PCIe to function
on the Renesas Condor board.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 9d0b42d96f03156e..77f98a7e860b8850 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -657,6 +657,7 @@ CONFIG_PHY_HISI_INNO_USB2=y
CONFIG_PHY_MVEBU_CP110_COMPHY=y
CONFIG_PHY_QCOM_QMP=m
CONFIG_PHY_QCOM_USB_HS=y
+CONFIG_PHY_RCAR_GEN3_PCIE=y
CONFIG_PHY_RCAR_GEN3_USB2=y
CONFIG_PHY_RCAR_GEN3_USB3=m
CONFIG_PHY_ROCKCHIP_EMMC=y
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] arm64: defconfig: Enable CONFIG_PHY_RCAR_GEN3_PCIE
2018-11-13 15:22 [PATCH] arm64: defconfig: Enable CONFIG_PHY_RCAR_GEN3_PCIE Geert Uytterhoeven
@ 2018-11-14 15:32 ` Marek Vasut
2018-11-15 14:33 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2018-11-14 15:32 UTC (permalink / raw)
To: linux-arm-kernel
On 11/13/2018 04:22 PM, Geert Uytterhoeven wrote:
> Enable R-Car Gen3 PCIe PHY support, which is needed for PCIe to function
> on the Renesas Condor board.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
This helps
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 9d0b42d96f03156e..77f98a7e860b8850 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -657,6 +657,7 @@ CONFIG_PHY_HISI_INNO_USB2=y
> CONFIG_PHY_MVEBU_CP110_COMPHY=y
> CONFIG_PHY_QCOM_QMP=m
> CONFIG_PHY_QCOM_USB_HS=y
> +CONFIG_PHY_RCAR_GEN3_PCIE=y
> CONFIG_PHY_RCAR_GEN3_USB2=y
> CONFIG_PHY_RCAR_GEN3_USB3=m
> CONFIG_PHY_ROCKCHIP_EMMC=y
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: defconfig: Enable CONFIG_PHY_RCAR_GEN3_PCIE
2018-11-14 15:32 ` Marek Vasut
@ 2018-11-15 14:33 ` Simon Horman
2018-11-15 14:47 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2018-11-15 14:33 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 14, 2018 at 04:32:05PM +0100, Marek Vasut wrote:
> On 11/13/2018 04:22 PM, Geert Uytterhoeven wrote:
> > Enable R-Car Gen3 PCIe PHY support, which is needed for PCIe to function
> > on the Renesas Condor board.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> This helps
>
> Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
Thanks, would it be better to use enable this driver as a module rather
than a built-in?
>
> > ---
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 9d0b42d96f03156e..77f98a7e860b8850 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -657,6 +657,7 @@ CONFIG_PHY_HISI_INNO_USB2=y
> > CONFIG_PHY_MVEBU_CP110_COMPHY=y
> > CONFIG_PHY_QCOM_QMP=m
> > CONFIG_PHY_QCOM_USB_HS=y
> > +CONFIG_PHY_RCAR_GEN3_PCIE=y
> > CONFIG_PHY_RCAR_GEN3_USB2=y
> > CONFIG_PHY_RCAR_GEN3_USB3=m
> > CONFIG_PHY_ROCKCHIP_EMMC=y
> >
>
>
> --
> Best regards,
> Marek Vasut
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: defconfig: Enable CONFIG_PHY_RCAR_GEN3_PCIE
2018-11-15 14:33 ` Simon Horman
@ 2018-11-15 14:47 ` Marek Vasut
2018-11-16 14:57 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2018-11-15 14:47 UTC (permalink / raw)
To: linux-arm-kernel
On 11/15/2018 03:33 PM, Simon Horman wrote:
> On Wed, Nov 14, 2018 at 04:32:05PM +0100, Marek Vasut wrote:
>> On 11/13/2018 04:22 PM, Geert Uytterhoeven wrote:
>>> Enable R-Car Gen3 PCIe PHY support, which is needed for PCIe to function
>>> on the Renesas Condor board.
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> This helps
>>
>> Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
>
> Thanks, would it be better to use enable this driver as a module rather
> than a built-in?
I think not, since the pcie-rcar cannot be compiled in as module, so the
associated phy driver shouldn't be compiled in as module either.
>>> ---
>>> arch/arm64/configs/defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 9d0b42d96f03156e..77f98a7e860b8850 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -657,6 +657,7 @@ CONFIG_PHY_HISI_INNO_USB2=y
>>> CONFIG_PHY_MVEBU_CP110_COMPHY=y
>>> CONFIG_PHY_QCOM_QMP=m
>>> CONFIG_PHY_QCOM_USB_HS=y
>>> +CONFIG_PHY_RCAR_GEN3_PCIE=y
>>> CONFIG_PHY_RCAR_GEN3_USB2=y
>>> CONFIG_PHY_RCAR_GEN3_USB3=m
>>> CONFIG_PHY_ROCKCHIP_EMMC=y
>>>
>>
>>
>> --
>> Best regards,
>> Marek Vasut
>>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: defconfig: Enable CONFIG_PHY_RCAR_GEN3_PCIE
2018-11-15 14:47 ` Marek Vasut
@ 2018-11-16 14:57 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2018-11-16 14:57 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 15, 2018 at 03:47:10PM +0100, Marek Vasut wrote:
> On 11/15/2018 03:33 PM, Simon Horman wrote:
> > On Wed, Nov 14, 2018 at 04:32:05PM +0100, Marek Vasut wrote:
> >> On 11/13/2018 04:22 PM, Geert Uytterhoeven wrote:
> >>> Enable R-Car Gen3 PCIe PHY support, which is needed for PCIe to function
> >>> on the Renesas Condor board.
> >>>
> >>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>
> >> This helps
> >>
> >> Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> >
> > Thanks, would it be better to use enable this driver as a module rather
> > than a built-in?
>
> I think not, since the pcie-rcar cannot be compiled in as module, so the
> associated phy driver shouldn't be compiled in as module either.
Thanks Marek,
applied for v4.21.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-16 14:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-13 15:22 [PATCH] arm64: defconfig: Enable CONFIG_PHY_RCAR_GEN3_PCIE Geert Uytterhoeven
2018-11-14 15:32 ` Marek Vasut
2018-11-15 14:33 ` Simon Horman
2018-11-15 14:47 ` Marek Vasut
2018-11-16 14:57 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).