From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A3ECC433B4 for ; Fri, 2 Apr 2021 17:40:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF45F61103 for ; Fri, 2 Apr 2021 17:40:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF45F61103 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FOs+cMdyAklGEqWOlpJYTgFijM0Qjxp+9wfbQ1p4EaY=; b=lMUsGYBzgAjOmz4IU4FzL3zA6 TRlzsGWu5Y/YEZEqTu6zgbZGclIl5bzuGHX/KVP8JJE2Tm47XN5k6vBW91hi4v0gl31DToeSlMSsw FZ7h9TanbKz9CFawp4uKmuz+gYjsnQKATeola+1kQMpKablqA7KIFtiI/8UfcVl8nFqjJjmdiNMUY Xg68moWEcIWniLP4d/AsY/cBFJoViGso3Bx/3zmWrPiV4b6wmnOD/zWpS/0lpinmX3UKjHEIprl/0 plUVqkigO0NCyzgL8YvSaPaefYfOhTQxCG2uPXeQ+uXxtCKLRUbbQdWdKuTpbC7oUWxLHbeAemqQb suYQq1RQg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lSNl0-00DVrh-Ej; Fri, 02 Apr 2021 17:38:55 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lSNkw-00DVr0-GN for linux-arm-kernel@lists.infradead.org; Fri, 02 Apr 2021 17:38:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617385128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TKDRlulogoRtKYWAUF1pyaqEOli9TuwMVFnHg7gDyqg=; b=jPjmwW4Maiw5/Wr96xRRg2D2wYRBXmYwSyF53aMGmYCU1E9H+kaPc10HbRHe9L/ygygc4D dCo2Wx7wiaBbcFY7xYwLsA+BTUSdpzX2/tK0kJmk/LLjv4KffJ+udD8QzGN1rHHa4uh5Uk 3mXRZKMHPTPIWZrupsIGJK4jFmhbmCw= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-76-zu59M4HKNKG9ylNkbOUBYQ-1; Fri, 02 Apr 2021 13:38:44 -0400 X-MC-Unique: zu59M4HKNKG9ylNkbOUBYQ-1 Received: by mail-ej1-f70.google.com with SMTP id gv58so3349330ejc.6 for ; Fri, 02 Apr 2021 10:38:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TKDRlulogoRtKYWAUF1pyaqEOli9TuwMVFnHg7gDyqg=; b=er9GJl+sC3fd5vv1S5dp/uK01N/ArBMw56znnJEnTMOcq8iseg5r0sol0WTpnTrOTN ll3ezpxUVmg9pv/cHDvbVpHhFr0yTGYUrf/Tw6szK4m0xxwGqAKEArUhWZVua81FYft9 y0y8OWX77TJBuqNWnY1xS1snLzpSwrBnPSu2MIj3EbpfY8rKmRQr7KNu8oKf1GC0jIei yLTBKPgqsyJY9E+igCJpLKRUG+4lyZrT1ng3M0ZsgDFCqva6Kg8TSMvDot7+/vrh47Hm AHyTsXGygj9FI7AxrMTT4ow7o66+L/JOwt2cZ7WtLRi+mYzLYPF3L3QmSg26FnFbGAUj mnAA== X-Gm-Message-State: AOAM531dsBeiH6i2aB7KaxfaY0txZX2xRBQyvMllI0Oht5V/Tm97QgTA XCsFroATXxx7AOQICL5geVp7LnsIVbzBBOLfZGhilFeOAiH0wm7Rs8OpIZ5xcEXcHqlwq4KW8ID 9WFr7vHYZslWzlkTO9oCFUuLkZKQ6Y7+2i6Y= X-Received: by 2002:a17:907:3f10:: with SMTP id hq16mr2635477ejc.181.1617385123130; Fri, 02 Apr 2021 10:38:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAS7ZbtJVwnzUWnA/6X0McPrVes3ar3lqem09HSmYxMrqLZW+HviZElaAarzltynI2Jr8wwA== X-Received: by 2002:a17:907:3f10:: with SMTP id hq16mr2635443ejc.181.1617385122924; Fri, 02 Apr 2021 10:38:42 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id y17sm4462135ejf.116.2021.04.02.10.38.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Apr 2021 10:38:42 -0700 (PDT) Subject: Re: [PATCH v2 0/9] KVM: my debug patch queue To: Maxim Levitsky , kvm@vger.kernel.org Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Ingo Molnar , Andrew Morton , Thomas Gleixner , Sean Christopherson , Marc Zyngier , Catalin Marinas , open list , Julien Thierry , Stefano Garzarella , Borislav Petkov , Suzuki K Poulose , Jonathan Corbet , Jessica Yu , "H. Peter Anvin" , Jan Kiszka , Will Deacon , "open list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , Vitaly Kuznetsov , Vasily Gorbik , Joerg Roedel , Claudio Imbrenda , Jim Mattson , Cornelia Huck , David Hildenbrand , Wanpeng Li , Janosch Frank , Christian Borntraeger , "open list:S390" , Heiko Carstens , Kieran Bingham , "open list:DOCUMENTATION" , "moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , James Morse References: <20210401135451.1004564-1-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: Date: Fri, 2 Apr 2021 19:38:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210401135451.1004564-1-mlevitsk@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210402_183850_701064_A3E60A2A X-CRM114-Status: GOOD ( 31.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/04/21 15:54, Maxim Levitsky wrote: > Hi! > > I would like to publish two debug features which were needed for other stuff > I work on. > > One is the reworked lx-symbols script which now actually works on at least > gdb 9.1 (gdb 9.2 was reported to fail to load the debug symbols from the kernel > for some reason, not related to this patch) and upstream qemu. Queued patches 2-5 for now. 6 is okay but it needs a selftest. (e.g. using KVM_VCPU_SET_EVENTS) and the correct name for the constant. Paolo > The other feature is the ability to trap all guest exceptions (on SVM for now) > and see them in kvmtrace prior to potential merge to double/triple fault. > > This can be very useful and I already had to manually patch KVM a few > times for this. > I will, once time permits, implement this feature on Intel as well. > > V2: > > * Some more refactoring and workarounds for lx-symbols script > > * added KVM_GUESTDBG_BLOCKEVENTS flag to enable 'block interrupts on > single step' together with KVM_CAP_SET_GUEST_DEBUG2 capability > to indicate which guest debug flags are supported. > > This is a replacement for unconditional block of interrupts on single > step that was done in previous version of this patch set. > Patches to qemu to use that feature will be sent soon. > > * Reworked the the 'intercept all exceptions for debug' feature according > to the review feedback: > > - renamed the parameter that enables the feature and > moved it to common kvm module. > (only SVM part is currently implemented though) > > - disable the feature for SEV guests as was suggested during the review > - made the vmexit table const again, as was suggested in the review as well. > > Best regards, > Maxim Levitsky > > Maxim Levitsky (9): > scripts/gdb: rework lx-symbols gdb script > KVM: introduce KVM_CAP_SET_GUEST_DEBUG2 > KVM: x86: implement KVM_CAP_SET_GUEST_DEBUG2 > KVM: aarch64: implement KVM_CAP_SET_GUEST_DEBUG2 > KVM: s390x: implement KVM_CAP_SET_GUEST_DEBUG2 > KVM: x86: implement KVM_GUESTDBG_BLOCKEVENTS > KVM: SVM: split svm_handle_invalid_exit > KVM: x86: add force_intercept_exceptions_mask > KVM: SVM: implement force_intercept_exceptions_mask > > Documentation/virt/kvm/api.rst | 4 + > arch/arm64/include/asm/kvm_host.h | 4 + > arch/arm64/kvm/arm.c | 2 + > arch/arm64/kvm/guest.c | 5 - > arch/s390/include/asm/kvm_host.h | 4 + > arch/s390/kvm/kvm-s390.c | 3 + > arch/x86/include/asm/kvm_host.h | 12 ++ > arch/x86/include/uapi/asm/kvm.h | 1 + > arch/x86/kvm/svm/svm.c | 87 +++++++++++-- > arch/x86/kvm/svm/svm.h | 6 +- > arch/x86/kvm/x86.c | 14 ++- > arch/x86/kvm/x86.h | 2 + > include/uapi/linux/kvm.h | 1 + > kernel/module.c | 8 +- > scripts/gdb/linux/symbols.py | 203 ++++++++++++++++++++---------- > 15 files changed, 272 insertions(+), 84 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel