From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02272C04FFE for ; Tue, 23 Apr 2024 15:19:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pOAmkQ2KCtQQ6pFDxCi5q3q/xwp1S61Za3xKOx4MMWs=; b=tyAt8ypX0OnvfM mcXUSP5EWNMXl/0j2YR4M759I9WEuklj7pBC76iZ/kbsYrEsivk75ROrKzXu9MFyyKhNirpAoqAeS KKBcB1s+XP26Ks/snbQkPjaTtW35dhj7kLNe3fNXngpXh771zWJD70hVitL6wNjCJqLpL89qA7+Uk /zbTJYmKcm6sZ/LqPLg7yDQB7rLtEBDuSFNAEMWlNyjxd8ikwJa0VNPuxmdTufMnUnuhkG+s50FTw 74o42dQajL+ja/z9zG3aShMXginYTE+6yqEr2BaMSEGLezBh5BCVsNH5haHMiy+XVtXOEZbBS4zie pqgRZdOhiM7noEu+ypMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzHva-00000000V8s-0O1q; Tue, 23 Apr 2024 15:19:26 +0000 Received: from out-179.mta0.migadu.com ([2001:41d0:1004:224b::b3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzHut-00000000UmZ-0AUU for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 15:18:46 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1713885519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CGvSIl1osJHCOXh6CXAvpDqVr+q8BgO5ZKZGPwPjjn0=; b=goGdSdfpsSWeQFMqZHmnSvmvOXJtmcErujWRs38CJsP+nyuQbbK+eRjw9n/xWYUUvhn3oc 7xmu9HV8BSB1uq15d7HBp6IeZa1e4vr6CI4HP05EIACkbYuiotPOQu99d+Nzsvw5RZRY1v RH7uW2gAdkQxI2zD896KtU07qEvaUo0= Date: Tue, 23 Apr 2024 11:18:34 -0400 MIME-Version: 1.0 Subject: Re: [PATCH 1/7] dt-bindings: pci: xilinx-nwl: Add phys To: Rob Herring Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thippeswamy Havalige , Michal Simek , Bjorn Helgaas , Conor Dooley , Krzysztof Kozlowski , devicetree@vger.kernel.org References: <20240422195904.3591683-1-sean.anderson@linux.dev> <20240422195904.3591683-2-sean.anderson@linux.dev> <20240423124456.GB4105016-robh@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240423124456.GB4105016-robh@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_081843_488066_13A047BB X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/23/24 08:44, Rob Herring wrote: > On Mon, Apr 22, 2024 at 03:58:58PM -0400, Sean Anderson wrote: >> Add phys properties so Linux can power-on/configure the GTR >> transcievers. >> >> Signed-off-by: Sean Anderson >> --- >> >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> index 426f90a47f35..02315669b831 100644 >> --- a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> @@ -61,6 +61,14 @@ properties: >> interrupt-map: >> maxItems: 4 >> >> + phys: >> + maxItems: 4 >> + >> + phy-names: >> + maxItems: 4 >> + items: >> + - pattern: '^pcie-phy[0-3]$' > > The names here are pointless and redundant. Names are local to the > device, so 'pcie' is redundant. They only refer to PHYs, so 'phy' is > redundant too. All you are left with is the index of the entry. > > Now if PCIe can work on only lanes 2 and 3 or similar, then maybe > -names becomes useful. OK, I'll just remove them... --Sean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel