From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B7CEC2D0A3 for ; Thu, 12 Nov 2020 09:37:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7B7F21D40 for ; Thu, 12 Nov 2020 09:37:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YdHqzPrI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7B7F21D40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VNXVaJr8FU141DQIc+klzuicpu8O0jlLjN4z0pHd+oU=; b=YdHqzPrIi6spkETyfGt0TRoRx g0MBGsZ+LxIOwPyXeu6IWcj9ZuUzXWioTdFGjeOKWOGSYnIhJ3fUJ5ag1oYYPHkN/bpdJ5Bx0n1Vn K5CSwBMz0cvQ18nZkxYQE3fuKSEaIYvRZSShKI7VTUFXpiM/zcVsz2ozSG14WZ9O+VqUZsl2f3Rpg V/8npRlxFD1XFf4ZSSGQsDNUPDiT0stFHaMG1FW7fLc82MpdZ4ffjl0YDu5DLS1lSCHyO2Vsm+4WC W8aG/Gv1+Y2F32dTtP9A4oAi/X5Hn+bQhZ0BOb8coyijn9iSkHdAHY+lBr46bIkJNtFXLQ8PSBt97 Ub0PUqMwA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd92P-0004Xd-Ei; Thu, 12 Nov 2020 09:37:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd92M-0004W7-DA for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 09:37:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 932FD139F; Thu, 12 Nov 2020 01:36:58 -0800 (PST) Received: from [10.37.12.33] (unknown [10.37.12.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7C3EF3F73C; Thu, 12 Nov 2020 01:36:55 -0800 (PST) Subject: Re: [PATCH v9 28/44] arm64: mte: Reset the page tag in page->flags To: Catalin Marinas , Andrey Konovalov References: <4a7819f8942922451e8075d7003f7df357919dfc.1605046192.git.andreyknvl@google.com> <20201112093130.GD29613@gaia> From: Vincenzo Frascino Message-ID: Date: Thu, 12 Nov 2020 09:39:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201112093130.GD29613@gaia> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_043702_568010_36B3CA53 X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/12/20 9:31 AM, Catalin Marinas wrote: > On Tue, Nov 10, 2020 at 11:10:25PM +0100, Andrey Konovalov wrote: >> diff --git a/arch/arm64/mm/copypage.c b/arch/arm64/mm/copypage.c >> index 70a71f38b6a9..f0efa4847e2f 100644 >> --- a/arch/arm64/mm/copypage.c >> +++ b/arch/arm64/mm/copypage.c >> @@ -23,6 +23,7 @@ void copy_highpage(struct page *to, struct page *from) >> >> if (system_supports_mte() && test_bit(PG_mte_tagged, &from->flags)) { >> set_bit(PG_mte_tagged, &to->flags); >> + page_kasan_tag_reset(to); >> mte_copy_page_tags(kto, kfrom); > > Any reason why this doesn't have an smp_wmb() between resetting the tags > and copying them into kto? > Yes, the reason is I am not sure why it disappeared from the submitted patch ;) I am going to respin the patch. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel