From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D683C10F16 for ; Mon, 6 May 2024 06:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R3O4nZD+8kWTWkhgNpd8HJzuhoySm0N/50dhcZLehj0=; b=CV13Tuj9lteywv 5+pVUgCG/IKykkXPYbdowHbSzab3zg05SFN6nif1zWqHYJYZ1vAs57dyOQ9wGiEWUx7VuQxy3GCD9 QdVe+lu6fyWevGmrU4ZvBR3xMnX7KLnF8hzKJNoVvDjIwWtRiZCvuCXrH1NTnM7bcPxcqIKxbCA1h ZcvpZdPMtYLuSCxFc7bet3OHxdmiHDH19OhUs3UBvbGccQLe8X7PTqUwKBzlOmUPvJd7+hp2ZTYq4 vusuXRBnGT8M/kpK5yDSUIZbcVEg12T3gD/bFMMSunwUcftzvUs8vGX74UvgA21nVwIEQcLL67gWN mmV1MrQRG8br7PagAWQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3rYT-00000006G55-0R06; Mon, 06 May 2024 06:10:29 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3rYP-00000006G42-2alN for linux-arm-kernel@lists.infradead.org; Mon, 06 May 2024 06:10:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8BC8C1007; Sun, 5 May 2024 23:10:47 -0700 (PDT) Received: from [10.163.35.238] (unknown [10.163.35.238]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B5173F762; Sun, 5 May 2024 23:10:17 -0700 (PDT) Message-ID: Date: Mon, 6 May 2024 11:40:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] arm64/arch_timer: include To: Puranjay Mohan , Catalin Marinas , Will Deacon , Sumit Garg , Stephen Boyd , Douglas Anderson , "Peter Zijlstra (Intel)" , Thomas Gleixner , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org References: <20240502123449.2690-1-puranjay@kernel.org> <7008cd0c-5b65-4289-9015-434cbe3d7e21@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240505_231025_734381_347896BC X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/3/24 15:14, Puranjay Mohan wrote: > Anshuman Khandual writes: > >> On 5/2/24 18:04, Puranjay Mohan wrote: >>> arch_timer.h includes linux/smp.h to use DEFINE_PER_CPU() and it works >>> because smp.h includes percpu.h. The next commit will remove percpu.h >>> from smp.h and it will break this usage. >>> >>> Explicitly include percpu.h and remove smp.h >> >> But this particular change does not seem to be necessary for changing >> raw_smp_processor_id() as current_thread_info()->cpu being done in the >> later patch ? You might still leave header inclusion in >> arch/arm64/include/asm/smp.h while dropping the per cpu cpu_number ? > > commit 57c82954e77f ("arm64: make cpu number a percpu variable") > created this percpu variable and included in > > Now we are removing the percpu variable cpu_number from smp.h, so there > is no need to keep percpu.h in smp.h Fair enough. > > I feel users of DECLARE_PER_CPU_[...], etc. should include percpu.h and > not smp.h as it makes reading the code more easier and can thwart build > issues in the future, when headers are changed. Right, makes sense, hope there is no more such cases using smp.h to pull in DECLARE_PER_CPU_[...]. A quick build on defconfig is successful after this patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel