From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C71A3C4332F for ; Thu, 20 Oct 2022 07:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2A0/9SMW6KejpdBOsrcpD+DemhXNHQO7xRigKRtgxlQ=; b=bGh16dUt+hV8Qc lyYMMJeDuqa1tDyMZQ/NhzQRWs5rRZ9k3BFB99jJtyEWq8bXT9T461DehR6Ws9D7eAxdWevtlfeNr TDoKCdf5GfFUj3sh/FqHxiVOSsBh4RHczxlazM0DK6cPlyqom8OjIMvpR/DBavZRNjJQVXudonAX1 pDk3HhYtwspzT006XacLcOO3crdcKXEUoXee/CJ/EZZnXiVPeFzkb6KI630iw68dv1QE8mR4kGH2i 3uR3hdwA5zBDHpyK3bgXYejUAVnwqJFdbdR7UD/36EquTWihtJTaX0DCtF9LWn4vvdZoL2cc8p+jN uKqmu3p0bdiMV9011IVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olPhH-00BUik-2i; Thu, 20 Oct 2022 07:10:32 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olPhD-00BUZd-DV for linux-arm-kernel@lists.infradead.org; Thu, 20 Oct 2022 07:10:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1666249827; x=1697785827; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=I7hOIkUzY2e+TSu7u+4dhxfirakw3dFh/YHd5X3pOyQ=; b=I2IE/bYK9sdGutxjQpphqsKdgmPpFESjwq/DrzJHxU6p5DvKFStiAocd LsUfnDVrwf/Xp9F4E8b07V1BMXSsmjnikAix0MFtxHDZJ0FeUTWQkuCTM mzkIp3HENVYqmlL1TfhaUA+opcsV2aieufAIKVbPgZdW/NJzjwvjhBlUG De18VcHIs4ZGzIK+KtE0tEf5NGTxa2Pr7VdBe0CEhf6MrW7jdpmPQKpAa hT+008d49MTwbIDvfuOc/GctehozPtg5W1RdEvr8hzqm10t1gn7ceh/zK b3hVxIdusB/EaNUdEVbkZk1aMgWIBA/fvpQONl8IPYEgyiqdEA0Rg6C9R g==; X-IronPort-AV: E=Sophos;i="5.95,198,1661842800"; d="scan'208";a="183092684" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 20 Oct 2022 00:10:26 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 20 Oct 2022 00:10:26 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Thu, 20 Oct 2022 00:10:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h5EUet3nxVU7MgT60ZOLG9vb5FMIAOmQyHmAk/9PCsBE5tKJ0iQsbo+RrGE/2HhWQg41A1ibGehNkZ8Y5pelnCgZulMlDsoJVtDbfT8lNM7GZbRWSItm/Lx7asjHfh4V58VWwKbMl4JaE6lMS9LQEO5RgG1EEo9R3cDlKe8yFHtREAcqZr45BVnjUVnAG1sbi52EchnKq9Vki8/w4LMpsjDJIscS2RRNIgITRWcp5lf0DFX4PJApjif7/0CCUFmQHmlJ1oazV/BL2r7vIulWzZU00Bk0cXn3SWYtfQcyV+VKOdlA5NOa4Q5niD/ydYs8BILWEoeUSeUUhsXTjo1lRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I7hOIkUzY2e+TSu7u+4dhxfirakw3dFh/YHd5X3pOyQ=; b=dLq70IfG8EMrl668W5g7f4B/snGrSVMas6X4Gn1l5fbojYFJIt+gK/IMQOMPGuj8XfFfW290TRhkCSy4FbDFDHzFchtSdeLcHxRiw5ehHX3llE8AI22vEtzZ0LSlrHSgpsL137gaiZ2IgwSsTmGd+renKg8eNOBU3a0XOKfECMD8Eou9h26+K6hO84LSDzUkr47CzsulMNCWEXD0WflWISnElfEBF1fwichYLNWbNf0p4ugAuTocM6CPJ+UJJdhOiMhjv1PuM4MWNPCowZxRThGHDtUwGHxRSkoVIbM1m3+rRqLKkPVl9K5XCa4+x5FyqY1mUcxFL4cB1Oj8o5SQmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I7hOIkUzY2e+TSu7u+4dhxfirakw3dFh/YHd5X3pOyQ=; b=KIWiuQz6W7K1wKujllk2IM3yBWL/J4J6UvNjTbbGS8VUm5Sv6AReAVjbGCTfwmyhIoo9rSEtVUedy9+82/vSmdyf5UZP+iLUcwUKpeyqwX5WyPiFVTl4N+drOIzgIh66PxGD66Eq230AlPTa4KDrfDXinofwkB9rnTbORLe23X8= Received: from DM4PR11MB6479.namprd11.prod.outlook.com (2603:10b6:8:8c::19) by DM6PR11MB4627.namprd11.prod.outlook.com (2603:10b6:5:2a2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct 2022 07:10:16 +0000 Received: from DM4PR11MB6479.namprd11.prod.outlook.com ([fe80::cf13:1785:f79d:9eb9]) by DM4PR11MB6479.namprd11.prod.outlook.com ([fe80::cf13:1785:f79d:9eb9%7]) with mapi id 15.20.5723.032; Thu, 20 Oct 2022 07:10:16 +0000 From: To: Subject: Re: [PATCH 31/33] dmaengine: at_hdmac: Use pm_ptr() Thread-Topic: [PATCH 31/33] dmaengine: at_hdmac: Use pm_ptr() Thread-Index: AQHY5FMBwM48+0wVvU6KDWIpYLhiQw== Date: Thu, 20 Oct 2022 07:10:16 +0000 Message-ID: References: <20220820125717.588722-1-tudor.ambarus@microchip.com> <20220820125717.588722-32-tudor.ambarus@microchip.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB6479:EE_|DM6PR11MB4627:EE_ x-ms-office365-filtering-correlation-id: 7e4131cf-cead-4c46-aaad-08dab26a23b6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sFLdt0C205A8598ydGb/lnIAP9uRC8yTdUdzdoUUFxgCyaThrfOZ7NHHM2cvCQXlE70nvvnszT4gJbpbRlE8wRYSCkjpO5TXk1ALJYptty7NvuERXUnV13/ZDpS9IIOu3OL5i57ZmYUNBetnAVeXYJmpeDLA2FN4/ejIjS64qxBnjoliNX7dAwxHF/2FWJS1nRz+57p4wI/83n1hSHyJSQtPJeXsiEfxDuZjtDpHDnrFHlgMImeMzJvHi5Q3zvCs4+T0YLXceLH5xlLaAtZDj48kvaUcnnWEs48lD48VdlWZPbTPVrD+3TzQCy6MIcMX1/Qg9+m+6M6+CUpaSAde6Do0No58tck755EAAAn7AhA3WkxHZnAGqSU0UOfD1Lljr16P99wULm7YLklqhxkNiCYdaHS9tgSrrbtcbhVBsR+tOR5vrim1RW/LYyRvwYqSkEPYnQgKWMun1ldbKSgxDI9B7rxOnsfhWYUL5qDJoo3Crp30MfInT5urJoV/aCt2ltpNrYnRnbbYkkZX6R/e8AnLKWqyWlp3B7tbeMlvMVYyoeSNBHLo3KjolyW05OqcTVlle5qZZkgTK0UeDtDVREiYSOd29gZbamVqS3jdOzkqrNTkXjUPku73cjROcK7pfj3lP+Ji6+lUWCHxck2/BHvfoiXaJVRxxZ0OPJAadK1/3wFAHabVBR9PxN3v7HHJX4tDpwmHkNipyYMB/AvHgUByEVx9qMex4k1jNFGPQl2Gjc2xiZyjf4QAEUBddxQ/6gFo11SRC7zZaA1j2AFogvjCc+cjv4polAOPrNV9gTF9jEz8cb5fD8csQFDkgog5QBBoNCmDX88EivkhKxXJGw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6479.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(396003)(39860400002)(376002)(366004)(451199015)(76116006)(478600001)(31686004)(71200400001)(83380400001)(86362001)(31696002)(6486002)(6512007)(36756003)(5660300002)(91956017)(66476007)(66556008)(53546011)(66446008)(8676002)(6506007)(26005)(316002)(41300700001)(8936002)(6916009)(4326008)(7416002)(54906003)(2616005)(186003)(2906002)(66946007)(64756008)(122000001)(38070700005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RGwxMUM0VXUzcUdUQUNXZzhIdG52Z0F5Wnp4czlqcnVNRURzY2F6VHU2QUp1?= =?utf-8?B?V21rZmd6YzZnbHdBWDluaUJxZUtzZ3RFL2VJNm9zVFJZVkpJNG5ncDVaVlVU?= =?utf-8?B?M0M0c1pFS2tYemxwNlZxSTNrUGliMXIvZVMvWVl3OEFNdVZWWWowTkg3SENW?= =?utf-8?B?SjBTRkExdE5vMXltZk9pR1NnTkM4YWJIZXNmS3RBbUltajRyczQ2ZlY2L1B1?= =?utf-8?B?VWU5dE1kMG5keGtFQWp6T1NXdTQ5dkVoOE41Q2JSRkd3WGZJTzVtRTVYaGxC?= =?utf-8?B?dU9GbXMzNkJQMUtVb2szcFVyc2hPYjViK0ZrOENPR0xpeTZmckFyL1lhUzhi?= =?utf-8?B?N0ZvckRlTXRxNzBNRDNiSXJPempRM1JoY2lrWDdybjR5bElGOU5VWSsyK2w3?= =?utf-8?B?SGcvanpQQjdxMUNxOW9ydnJBamp1Zk9ja1MxaEc5RXdHL0N1bW53SHpLd1hi?= =?utf-8?B?UFM0THRlTGorN2NiMHBaU2ZMamxqYzhJYjhxZDRCSGZNaDhvZkRYdTZGQVlu?= =?utf-8?B?QTB6cEhwT0VHTGZveUIxQndQZzFwVERNU29XWkxRL3FRdnFXaVd1YUEydUto?= =?utf-8?B?SHZUU05WWWVnSFp6aElNSEI0WTM0Z2NZYnVQcE9wRXIwTWQ1VDArN1c1RU1R?= =?utf-8?B?ZmVuUndhTFlaWDBBekNESUE0WFJwTXc5RkVVb3BpaldHWlU3ZXFmV0pGMzdX?= =?utf-8?B?dW8rSGswVWFQd1cydGtRSWtFUjZ2aTdzMS9CWk50QjMya3cwUkw5bjdoUjFZ?= =?utf-8?B?Q29TcUJoNUJQWXNDbWlxMXpJUmhySU54TjRiZVBpenBZVWxGZW03Umx6aXdZ?= =?utf-8?B?SDV1YjRxSTJGM0tKY0QzMitlanl4U0JaN01tMUZWNDIwdS9KNm4rYjJEZkRq?= =?utf-8?B?d2JvME1ycnd0WDYxWE5rWCtNdEt2ai9kb3JQeDRWcTQwOW5tM2N3bVpMR3Za?= =?utf-8?B?b3lRYjRWTFZnUDRVZlFablZrV0VlWkhMbjFLUjhKRklCMkdlaWtoZWF6dE1Q?= =?utf-8?B?ck1DOUJ1eWFMRlNuTXBSaEJGOEk0ajJneXFLdEtnVk95WS9weGl4NFVGWnJ5?= =?utf-8?B?UDRaR3ZobkExZytIU2pBckFkSmZONFZYWFl5OWljUnI0anRrSG50bVNWSE1H?= =?utf-8?B?WnByU3ZRK0FacVJuWTRSQmxZSWE1S1RHeWMxeEZsL2U1YzJhVEJyNEtiTStj?= =?utf-8?B?MnZ4Q0lpU1hjb3hGWVhTNlhPOW1IaVVxT0YzTmhjWkNRMitLVHEyc04xWFA3?= =?utf-8?B?MGk0UVNjL0ZKZlZJQm42RFpZUEc4WmNHZG1HS2FlQUJFMjkxQXRzZTloMnRI?= =?utf-8?B?UGNLK2t2R0t6Mmo2ZUxUK0NyUk55TlQ0akV5Z1hHS3dYUXpMREtDcG84Y1JZ?= =?utf-8?B?VUlXNDBab2tNV0JoVll2ak1Kd0RFcWk0R2diOTkvQ1dPZ0tTZkp5R2lXL3gr?= =?utf-8?B?OWhlYUEzVjloVHBNRytiZUJBL0tnd2JvVzYvaVpSWThOYzRwZTIzbGllaEw3?= =?utf-8?B?aG93ZHF2T0ErRzR2N1N0UURpSWdBL1NNNmFwRWRWQm1FOWFTenhGeXFzRWo3?= =?utf-8?B?bm1tdWJFTW1mMmFuZ25PZG9TU3NYNHQxUGM4NDVIbDkycWFWNmdzdWovUVdz?= =?utf-8?B?ZTZVczNZUDBkdkUzNmZQMWkxaVlZM0t4dStNY3paemNMUUcyd0dYWE5kaE5x?= =?utf-8?B?VC9JNGZhYytRV0pwN0hNRzQ0YUJGM1hma3F6Q3VtUlRXeHBhZlpXdUYwUlFO?= =?utf-8?B?c1VuQ1UzUy9PblpDazRJNi8vTENGMDRxQUo0RWZib0M1a2thczJaVWdtUlZ2?= =?utf-8?B?c1IybUg1VFlhbVVicldzTXFvUUw0d1Vxdms2SDZTK3NEc3M2bytUMmRMbmNo?= =?utf-8?B?VGc3aG5URmxVNXU2QVlickZPV081dW1HSFJpWmdOS2dZWSt0YjhqUHp2M202?= =?utf-8?B?OUtEcFFBTm81SDZPbkFaRENnNUxCbDNhSCtRVFp2VGF0OERWOUdvZ3BGMmZS?= =?utf-8?B?cTFZVEFXVWUxalhhWnVBV3BOdHlwZnpxV0cwUEx0V0M1ZzJTK3kwdmNoYStj?= =?utf-8?B?cmZnZjhqN2xSRTU1c1JuMFRUcHdlaXg1emo1b2gzRkJROXdmWHE0ZHB3M01n?= =?utf-8?Q?cP0PaWP8HWv/V0ZeRmNfVX47J?= Content-ID: <68A56763C488DE4D8F50AD14C1E3A60D@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6479.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e4131cf-cead-4c46-aaad-08dab26a23b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 07:10:16.1328 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vM1nxkHUwf/jVK+K/XxtxC+pkCa7dzGn52kOyTN6vGm7rpfd8Z92+7ntBEfJpuMfusTcZgOdgeI0jc2+4kAc/cP3oKhpMOhZtXtNGoAm2ro= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4627 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_001027_606223_AFF2E507 X-CRM114-Status: GOOD ( 19.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tudor.ambarus@gmail.com, linux-kernel@vger.kernel.org, maciej.sosnowski@intel.com, mripard@kernel.org, torfl6749@gmail.com, du@axentia.se, Ludovic.Desroches@microchip.com, regressions@leemhuis.info, dmaengine@vger.kernel.org, dan.j.williams@intel.com, peda@axentia.se, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/19/22 19:50, Vinod Koul wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 20-08-22, 15:57, Tudor Ambarus wrote: >> From: Tudor Ambarus >> >> Use pm_ptr() macro to fill at_xdmac_driver.driver.pm. In case CONFIG_PM is >> not enabled, the macro will return NULL. > > You annotated at_dma_dev_pm_ops with __maybe_unused which is a correct > thing to do, but should be explained here okay, will refine the commit message. > >> >> Signed-off-by: Tudor Ambarus >> --- >> drivers/dma/at_hdmac.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c >> index 0b473e6d161d..e35b4b325452 100644 >> --- a/drivers/dma/at_hdmac.c >> +++ b/drivers/dma/at_hdmac.c >> @@ -2524,7 +2524,7 @@ static int at_dma_resume_noirq(struct device *dev) >> return 0; >> } >> >> -static const struct dev_pm_ops at_dma_dev_pm_ops = { >> +static const struct dev_pm_ops __maybe_unused at_dma_dev_pm_ops = { >> .prepare = at_dma_prepare, >> .suspend_noirq = at_dma_suspend_noirq, >> .resume_noirq = at_dma_resume_noirq, >> @@ -2536,7 +2536,7 @@ static struct platform_driver at_dma_driver = { >> .id_table = atdma_devtypes, >> .driver = { >> .name = "at_hdmac", >> - .pm = &at_dma_dev_pm_ops, >> + .pm = pm_ptr(&at_dma_dev_pm_ops), >> .of_match_table = of_match_ptr(atmel_dma_dt_ids), >> }, >> }; >> -- >> 2.25.1 > > -- > ~Vinod -- Cheers, ta _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel