From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8DCDC4332F for ; Wed, 8 Nov 2023 07:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lN9o/N36eH/WaiO0NUwxUAxFmT7b1AR2sN4r6eAojXA=; b=jU6LurEddIN6n5 eUHi0VLH4xo0hA1ot4KJoekDI5BRg2LJIpRY/Cw17V9oOWjVtC+CZeFXJVJFKXXanBj8uCo8XRZJK ljWjDcfeFN9/DqMmpJGuXHu1zYGOkZmPiwhhSENdS88FaosRj0tnf76QMDDN1CHmZkqN39IQcQBbU FhbsReKgIs4+2a3QNNgYjJk6sf/46NFJujek3tYVobnFAg5X7+QHygHI2VvUCsD9egO2vlzx2c6lh 6Tp6s5sua7u1jBYlacXV3iqXGUznpiLhR9bSKqgaoLHbW15t+V6F+Tu+7yP8PjB1LQEVs7FEn6/ek IC1L996DFniNCrYgO//g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0dFm-003Cdg-0A; Wed, 08 Nov 2023 07:45:34 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0dFi-003Cce-1F; Wed, 08 Nov 2023 07:45:32 +0000 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A86Gk58009326; Wed, 8 Nov 2023 07:44:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=oGKLdo3NPJ5cRCFZ+eE7FWQBivkD2Wt2J//M4dNAs/s=; b=kz3HEavag4zn6s677HTpkQTx00RiNurPkmS/Q1ACbgPCk1FnlVj9X9DVVP1RQNlG/KUO xxqtQsbkQ4I7u4Lkg03kzGO6q6TQSj3ssMpUCsGIFV3u0kTNZqqetqDp/OAoRe8tTl2F DVe8rbIUO3swkT4+W1pwDkeyobbROnoQLPaCUItY3dVQXuev6aycBQuoy8/OI190/Tmb 47GNJY/E2Jkf+Ne4A8/LdgqJLLhRN7xpf1mL9lwtBzY4amROdcxE9JDkTHIk3GmNuIyM f6T0TH/EmXGyf7vOjYS0SYZHZwwAX/kxsj6iivIi5oCKuy5CyDEBaN8dH14580tdWEVG Yw== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u7xyu0sex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Nov 2023 07:44:58 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3A87ivZs002711 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 8 Nov 2023 07:44:57 GMT Received: from [10.253.34.202] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Tue, 7 Nov 2023 23:44:51 -0800 Message-ID: Date: Wed, 8 Nov 2023 15:44:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 1/7] scsi: ufs: host: Rename structure ufs_dev_params to ufs_host_params To: Andrew Halaney , Can Guo CC: , , , , , , , , , Alim Akhtar , "James E.J. Bottomley" , Krzysztof Kozlowski , Andy Gross , "Bjorn Andersson" , Konrad Dybcio , Matthias Brugger , AngeloGioacchino Del Regno , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Brian Masney , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , open list , "moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." References: <1699332374-9324-1-git-send-email-cang@qti.qualcomm.com> <1699332374-9324-2-git-send-email-cang@qti.qualcomm.com> Content-Language: en-US From: Can Guo In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Zg3DmZ3qNhekEerDGSpqD2-ivhjgznXo X-Proofpoint-GUID: Zg3DmZ3qNhekEerDGSpqD2-ivhjgznXo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-08_01,2023-11-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=999 adultscore=0 suspectscore=0 clxscore=1011 malwarescore=0 phishscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311080062 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_234530_564907_703441D4 X-CRM114-Status: GOOD ( 23.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On 11/8/2023 3:36 AM, Andrew Halaney wrote: > On Mon, Nov 06, 2023 at 08:46:07PM -0800, Can Guo wrote: >> From: Can Guo >> >> Structure ufs_dev_params is actually used in UFS host vendor drivers to >> declare host specific power mode parameters, like ufs__params or >> host_cap, which makes the code not very straightforward to read. Rename the >> structure ufs_dev_params to ufs_host_params and unify the declarations in >> all vendor drivers to host_params. >> >> In addition, rename the two functions ufshcd_init_dev_pwr_param() and > nit: s/ufshcd_init_dev_pwr_param/ufshcd_init_pwr_dev_param/ sure > >> ufshcd_get_dev_pwr_param() which work based on the ufs_host_params to > nit: s/ufshcd_get_dev_pwr_param/ufshcd_get_pwr_dev_param/ sure > >> ufshcd_init_host_param() and ufshcd_negotiate_pwr_param() respectively to >> avoid confusions. >> >> This change does not change any functionalities or logic. >> >> Signed-off-by: Can Guo >> --- >> drivers/ufs/host/ufs-exynos.c | 7 +++--- >> drivers/ufs/host/ufs-hisi.c | 11 ++++----- >> drivers/ufs/host/ufs-mediatek.c | 12 ++++------ >> drivers/ufs/host/ufs-qcom.c | 12 ++++------ >> drivers/ufs/host/ufshcd-pltfrm.c | 49 ++++++++++++++++++++-------------------- >> drivers/ufs/host/ufshcd-pltfrm.h | 10 ++++---- >> 6 files changed, 47 insertions(+), 54 deletions(-) >> > > >> diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c >> index da2558e..6e65b61 100644 >> --- a/drivers/ufs/host/ufshcd-pltfrm.c >> +++ b/drivers/ufs/host/ufshcd-pltfrm.c >> @@ -285,17 +285,17 @@ static int ufshcd_parse_operating_points(struct ufs_hba *hba) >> } >> >> /** >> - * ufshcd_get_pwr_dev_param - get finally agreed attributes for >> + * ufshcd_negotiate_pwr_param - get finally agreed attributes for >> * power mode change >> - * @pltfrm_param: pointer to platform parameters >> + * @host_param: pointer to platform parameters >> * @dev_max: pointer to device attributes >> * @agreed_pwr: returned agreed attributes >> * >> * Return: 0 on success, non-zero value on failure. >> */ >> -int ufshcd_get_pwr_dev_param(const struct ufs_dev_params *pltfrm_param, >> - const struct ufs_pa_layer_attr *dev_max, >> - struct ufs_pa_layer_attr *agreed_pwr) >> +int ufshcd_negotiate_pwr_param(const struct ufs_host_params *host_param, >> + const struct ufs_pa_layer_attr *dev_max, >> + struct ufs_pa_layer_attr *agreed_pwr) >> { >> int min_pltfrm_gear; > If you're going to change pltfrm -> host, maybe do so for > min_pltfrm_gear too? I think this all reads nicer with the functions > changed as is, but the consistency would be nice in my opinion. Sure, will address in next version. > > Outside of those nits, I think this reads nicer now as well. > > Acked-by: Andrew Halaney Thanks, Can Guo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel