From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Liviu Dudau <liviu.dudau@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: juno: align thermal zone names with bindings
Date: Wed, 3 Jan 2024 14:39:06 +0100 [thread overview]
Message-ID: <cbe43d1e-8de8-4f05-887c-a34b45ee327f@linaro.org> (raw)
In-Reply-To: <b9943188-b3f9-472f-bc60-e8e6e043ddf4@linaro.org>
On 03/01/2024 11:13, Krzysztof Kozlowski wrote:
>
>> 'pinctrl-[0-9]+'
>> 4 thermal-zones: gpu1-thermal: 'trips' is a required property
>> 4 thermal-zones: gpu0-thermal: 'trips' is a required property
>> 4 thermal-zones: big-cluster-thermal: 'trips' is a required property
>>
>> Last I checked this, it looked like the length of the child names was
>> limited because the thermal subsys uses the node names for its naming
>> which is limited to 20 chars (with null). Though the regex here allows
>> for 21 chars without nul. Looks like a double off by one error.
>
> Yes, that's another issue.
>
>>
>> The thought I had at the time was to make the kernel drop '-thermal'
>> from its names. Might be an (Linux) ABI issue if userspace cares (I
>> think it shouldn't). Also, I'm not sure how the kernel handles the
>> names overflowing. Maybe it is fine and we can just extend the length
>> in the schema from 12 to 18 (plus the 1 starting char).
>
> The name is used in the "/sys/class/thermal/thermal_zone0/type" file, so
> actually some userspace could depend on it, but it would be affected
> anyway by my renaming of nodes.
Stripping "-thermal" prefix is a bit bigger task, because it is later
used to find the actual nodes. The thermal framework does not store
device_node pointer, but looks up by the name.
There is on-going work around this:
https://lore.kernel.org/all/20231012175836.3408077-2-thierry.reding@gmail.com/
https://lore.kernel.org/all/20231221124825.149141-27-angelogioacchino.delregno@collabora.com/
so I will just fix the DTS (shorten the name) and fix bindings for 11
characters.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-01-03 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 17:16 [PATCH] arm64: dts: juno: align thermal zone names with bindings Krzysztof Kozlowski
2023-12-11 10:27 ` Liviu Dudau
2023-12-13 11:57 ` Sudeep Holla
2024-01-02 18:09 ` Rob Herring
2024-01-03 10:13 ` Krzysztof Kozlowski
2024-01-03 13:39 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbe43d1e-8de8-4f05-887c-a34b45ee327f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lpieralisi@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).