From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD1EFC3DA6E for ; Wed, 3 Jan 2024 13:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZvQyA4FC3HpyFHv9i+E+L+jtxY+F3LIISz3maWGfSWM=; b=OOBw3JcDDuJrYQ shfkKqmWjiNhQpuWzL86fzPubHczz8POMjk8UbDMMA1cNHVoxtBX5VecpQ3Wa30wNQnbRmIBaT7ZO rIxD5ca3j2TbR/jQUKw/HIGvj3Q331+thi657HglbrE78VzUxkF8KlBtkEOSiUG5wupTS2eaXriW5 ZNZXdfnLZGfIApR0LEHbAXu7gT5nODaXwl1XL27WiEFF6tevfSvYciXIwKRtaVd02iD/SVLF2h0PH MGhOJqtYZ9D+pvswHr4z+uyUFCRNAjqVKbu0JAgnC1dkscICgyyQnUWx+1iZaQxJZM5A9fyVnfU3z hJ54JaVt6WunkQp4p3bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rL1Sn-00AzZd-1i; Wed, 03 Jan 2024 13:39:17 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rL1Sj-00AzWE-0k for linux-arm-kernel@lists.infradead.org; Wed, 03 Jan 2024 13:39:15 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a27cd5850d6so289015966b.1 for ; Wed, 03 Jan 2024 05:39:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704289148; x=1704893948; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=5yn09ffYZPc7aBLokf+bfH+Tett0Gy39mn9i+Z/bJZY=; b=qU5jYo6dgJj8HFGnuU+0hNkmlMrW4kKQtxfhg08QNFCqfX08syQ3Q09oTpd0K2r6+o mdTiHXAiWDYMNAwBBVg68CRrt4hewMHwy33vOwLnVMdVvGUmCTDnc6BwQsG20jaw6o0/ wS7NlsGqW+ivvkswmGNibV8XSC8efxksM+0JzpOUG4Kt6OyyUS5pir78kdbGvqAzvl5g iov4HXv3TzGkyM1k5WOFVLTO1AA6w6WzJwuGkybEQGcQh21nEt5s0coB9QROeJ8N3mfX 9FuxIOm+gRCaqK4F7SlRgsxSsUBeEOdOPZQXw3IMv+ppFSs0dttfzbBxGXyVJHn9We3A L4Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704289148; x=1704893948; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5yn09ffYZPc7aBLokf+bfH+Tett0Gy39mn9i+Z/bJZY=; b=revW7VbBCqHKX7bOz1bFyqwqB32EsPpxG4JActTLQi/zFuTZz5/Tq9lVVX+l9M4z/r c+3lUTFQynbUspFxOlIkVYFLE4ST3eJgoVAaMOnWIZSn3MhmhoEOAVi+ApLriIDCPkgP K/dbYID6w7A9hMXde/K0u10zIPfInagx9w0eda0FfUFs0LzaIWuTW2X6Xf4R2vcjN5Jt bZ+1fZcbYidvk0zVkKquYoPFfgTVNF0S/Rnmu36X9oSGenAMfP5wkYHHhL1TCnXWXplC XzxAU1i4vlFGA5aufD9+vGNCVnWY/7M3sjK553y/akG+MbivK5bZVj60619qB1aBMr1V G1ZA== X-Gm-Message-State: AOJu0YxzB4eJyt5/nyvcKsfHXn4m1BCtDgSK2rDIVIMSY6Mu+oHurPD8 D0G+g0sl+Up0AggFkUqnehemULYcUBlUog== X-Google-Smtp-Source: AGHT+IGACRGMGX0Yf8cFK5MjN5WbNwSG9jrViLn6jwAsqsPJh2xixQVVpDljbKRh92Td3zAvTc9LMA== X-Received: by 2002:a17:906:71ce:b0:a26:a49a:7d3a with SMTP id i14-20020a17090671ce00b00a26a49a7d3amr9198715ejk.67.1704289148551; Wed, 03 Jan 2024 05:39:08 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id gh13-20020a1709073c0d00b00a2797a545a3sm4926210ejc.193.2024.01.03.05.39.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jan 2024 05:39:08 -0800 (PST) Message-ID: Date: Wed, 3 Jan 2024 14:39:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: juno: align thermal zone names with bindings Content-Language: en-US From: Krzysztof Kozlowski To: Rob Herring Cc: Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231209171612.250868-1-krzysztof.kozlowski@linaro.org> Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240103_053913_292300_CAEE45C0 X-CRM114-Status: GOOD ( 19.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/01/2024 11:13, Krzysztof Kozlowski wrote: > >> 'pinctrl-[0-9]+' >> 4 thermal-zones: gpu1-thermal: 'trips' is a required property >> 4 thermal-zones: gpu0-thermal: 'trips' is a required property >> 4 thermal-zones: big-cluster-thermal: 'trips' is a required property >> >> Last I checked this, it looked like the length of the child names was >> limited because the thermal subsys uses the node names for its naming >> which is limited to 20 chars (with null). Though the regex here allows >> for 21 chars without nul. Looks like a double off by one error. > > Yes, that's another issue. > >> >> The thought I had at the time was to make the kernel drop '-thermal' >> from its names. Might be an (Linux) ABI issue if userspace cares (I >> think it shouldn't). Also, I'm not sure how the kernel handles the >> names overflowing. Maybe it is fine and we can just extend the length >> in the schema from 12 to 18 (plus the 1 starting char). > > The name is used in the "/sys/class/thermal/thermal_zone0/type" file, so > actually some userspace could depend on it, but it would be affected > anyway by my renaming of nodes. Stripping "-thermal" prefix is a bit bigger task, because it is later used to find the actual nodes. The thermal framework does not store device_node pointer, but looks up by the name. There is on-going work around this: https://lore.kernel.org/all/20231012175836.3408077-2-thierry.reding@gmail.com/ https://lore.kernel.org/all/20231221124825.149141-27-angelogioacchino.delregno@collabora.com/ so I will just fix the DTS (shorten the name) and fix bindings for 11 characters. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel