From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4F40C07E9D for ; Tue, 27 Sep 2022 11:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DkYvJMKISEr68OFGit7AjWc/DlOOa8vk4LTNxSuFnxE=; b=ryNdwxaF9rkhNa cRrgCJgz+cHu+bNWK/XatIYVz4e4RdgVpG6hLaYSkWDZ+1+fK9vLv3IP917Ao4RSP493DXdWLRY9M TG7f77gkApopSmsC7Bf6Rd0E0I7Xxbk6ai4oGL1Pn3iM7yohC0oVpOhiQdRqACTKndWu8Qa3Ylgsu PUJuGX9WeaBkyuycCfwBJZHscpIq+QhOoR3XQKby+zLzvu8k7U2ZDzjm0gzaZ7NjFvLzWNHj0hgiu ypB4LjUhmaHLaK0ORqIxvMhrBUadY+wW5AzDp1QT6/X9Py8wLB8/0A/XN+QtX56ksW4BnLbzjGjgY xds+oFvaJrg/qSgdszPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1od8Kz-00A1q7-6x; Tue, 27 Sep 2022 11:01:17 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1od8Kw-00A1ok-7s; Tue, 27 Sep 2022 11:01:15 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 043BA6601F41; Tue, 27 Sep 2022 12:01:11 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1664276472; bh=RDWtY7wqaihCFtmoFWJVug40U4Jv115kYvwmjRDansY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gH87XogzsxK7TVCFj4qUFTrougqAFQMRPxlw9tr08UzMtOqb5qAkQs3VNiTHLPzTl CXck085FzbMkt1n8p97aeHMkhILghLYnxGuqy4My1+mEg4R4TjfktwnPJadZQd96JN S9VxJDQ3RaW7sovH/daruwR7wvcucICZRKBZJSluqda+sXCuW3NBY/RE5VLlkHXtmi NehuyuOiri8hiw9Qbr206d1IiSRW6mlvFoTGY8HCMYfTblLb2IzVVwdwJNFTWLmoHe XQrWPLwBZw3Gq5ZqNZRcymZ4uexQ1fx4yz8pbDSKTzfi082JGa983swS6+A9aQ2iD3 HfH2wshC9bung== Message-ID: Date: Tue, 27 Sep 2022 13:01:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v3 03/11] arm64: dts: mt8195: Add SCP core 1 node Content-Language: en-US To: Tinghan Shen , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Mauro Carvalho Chehab Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20220927025606.26673-1-tinghan.shen@mediatek.com> <20220927025606.26673-4-tinghan.shen@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220927025606.26673-4-tinghan.shen@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_040114_443622_2949695A X-CRM114-Status: GOOD ( 16.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 27/09/22 04:55, Tinghan Shen ha scritto: > Add the 2nd core(core 1) of MT8195 dual-core SCP to devicetree file. > Reserve some SRAM spaces for the core 1 image. > > Signed-off-by: Tinghan Shen > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 905d1a90b406..48d457bd39b8 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -760,12 +760,24 @@ > > scp: scp@10500000 { > compatible = "mediatek,mt8195-scp"; > - reg = <0 0x10500000 0 0x100000>, > + reg = <0 0x10500000 0 0xa0000>, > <0 0x10720000 0 0xe0000>, > <0 0x10700000 0 0x8000>; > reg-names = "sram", "cfg", "l1tcm"; > interrupts = ; > status = "disabled"; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x105a0000 0 0x105a0000 0x20000>; > + > + scp_c1: scp-c1@105a0000 { > + compatible = "mediatek,mt8195-scp-core"; > + reg = <0x105a0000 0x20000>; > + reg-names = "sram"; > + interrupts = ; > + status = "disabled"; > + }; I think that the best way of describing a dual-core SCP in devicetree would be either something like: scp: scp@10500000 { compatible = "mediatek,mt8195-scp"; reg = <0 0x10500000 0 0xa0000>, <0 0x105a0000 0 0x20000>, <0 0x10720000 0 0xe0000>, <0 0x10700000 0 0x8000>; reg-names = "sram", "sram-c1", "cfg", "l1tcm"; interrupts = , ; status = "disabled"; }; ...but that may pose an issue when trying to assign different (or more instances of the same) subnode(s) to each core... for which, I'd be more for something like: scp: scp@10500000 { compatible = "mediatek,mt8195-scp"; reg = <0 0x10720000 0 0xe0000>, <0 0x10700000 0 0x8000>; reg-names = "cfg", "l1tcm"; #address-cells = <1>; #size-cells = <1>; ranges = <0 0 0x10500000 0x100000>; status = "disabled"; scp_c0: scp-core@0 { compatible = "mediatek,mt8195-scp-core"; reg = <0x0 0xa0000>; reg-names = "sram"; interrupts = ; }; scp_c1: scp-core@a0000 { compatible = "mediatek,mt8195-scp-core"; reg = <0xa0000 0x20000>; reg-names = "sram"; interrupts = ; }; }; Regards, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel