From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 041BEC54798 for ; Fri, 1 Mar 2024 00:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YDUfdKGGPeebJbBz2Gp5gxK25+VCD73ZgxSN57hnnwo=; b=UJrI/4y2WAV7gG LDnCXgi08KxLRATBXuvSuAGiBJdWyz2O3/xvyaFJw3CDMAIo4bNTRcFqSxELh5KYkefwdAAjlizju qOvLliHbghY/oV0fNTlDNZjFDxomv4zYWLdymuBz7NypVEnQBCdVrPslynA1T9S3X/VdWNW+YKaTl /H+lf7gU76a5X8J3AEzMQqgl1MZjVIKqVg3R2IsiVIE6b6ZL78VnVAL0gud7eP0Y+xYVr/BA5AUfA nPa68TgyqnurkdZLa/NPVItOdaHwahbSP21Yjl6c323cuJOHPhF0kQNv0cEW2yVqS/kRPOsKQ954c ar+DTuuodMtWXkSpaGCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfqLb-0000000Fgy0-25Ka; Fri, 01 Mar 2024 00:01:55 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfqLZ-0000000FgxJ-0MRp for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2024 00:01:54 +0000 Received: from [192.168.68.112] (ppp14-2-70-176.adl-apt-pir-bras31.tpg.internode.on.net [14.2.70.176]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 21BD22012A; Fri, 1 Mar 2024 08:01:50 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1709251311; bh=wLcneC51g0yvr2rzTMvDPFpjn3ptVrIuHETKFxaBzdQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=TDvZPeRhAQ/ae5/L624GhlPAeR3buY0n8UuSKpHSUNxzU+Oc12emprmoIoHsRaIeu MkFUPSISftOmnJv+B1ew/H3oAvCgSoxsCgcJue/SizLC6PMC2ElnRb9Fgj0dA9ZkhC yX/NfH5gtdMsaYAm595hUfiJwfeHC1hhAvVe4tLejzqS9SomPFYy10/gf+87knqox/ f44qFlLO3i4WKXEBykHfikAVUP1Y47xSuKxn8PweCj16eENDn7HPq8PP1GaJ1RaCys sFUMhiZzA4J5CRayMyuEEpSzBYR49shqXw8LpD2HA15kz59xs/Ru87jSSCi0bScftq kCtM4H64KHGSw== Message-ID: Subject: Re: [PATCH v5 2/2] ARM: dts: aspeed: x4tf: Add dts for asus x4tf project From: Andrew Jeffery To: Kelly Hung , robh+dt@kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, kelly_hung@asus.com, Allenyy_Hsu@asus.com Date: Fri, 01 Mar 2024 10:31:47 +1030 In-Reply-To: <20240229111123.1932504-2-Kelly_Hung@asus.com> References: <20240229111123.1932504-1-Kelly_Hung@asus.com> <20240229111123.1932504-2-Kelly_Hung@asus.com> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_160153_349555_9C9AC762 X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2024-02-29 at 19:11 +0800, Kelly Hung wrote: > Base on aspeed-g6.dtsi and can boot into BMC console. > > Signed-off-by: Kelly Hung > > --- > V4 -> V5: None > V3 -> V4: None > V2 -> V3: > - fmc lable change to bmc. > - use 64M partition layout. > - rename spi1 label to bios. > - remove bios partition section. > V1 -> V2: > - do schema check and remove all warings. > - remove all unnecessary sections. > --- > arch/arm/boot/dts/aspeed/Makefile | 1 + > .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts | 581 ++++++++++++++++++ > 2 files changed, 582 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts > > diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile > index d3ac20e31..32c41f3d9 100644 > --- a/arch/arm/boot/dts/aspeed/Makefile > +++ b/arch/arm/boot/dts/aspeed/Makefile > @@ -10,6 +10,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-arm-stardragon4800-rep2.dtb \ > aspeed-bmc-asrock-e3c246d4i.dtb \ > aspeed-bmc-asrock-romed8hm3.dtb \ > + aspeed-bmc-asus-x4tf.dtb \ > aspeed-bmc-bytedance-g220a.dtb \ > aspeed-bmc-delta-ahe50dc.dtb \ > aspeed-bmc-facebook-bletchley.dtb \ > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts > new file mode 100644 > index 000000000..64f4ed07c > --- /dev/null > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts > @@ -0,0 +1,581 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +// Copyright 2024 ASUS Corp. > + > +/dts-v1/; > + > +#include "aspeed-g6.dtsi" > +#include "aspeed-g6-pinctrl.dtsi" aspeed-g6.dtsi already includes aspeed-g6-pinctrl.dtsi, so the include here is unnecessary. Other than that the patch looks okay to me. There are bunch of issues exposed by `make CHECK_DTBS=y aspeed/aspeed-bmc-asus-x4tf.dtb`, however they're almost all generic issues with aspeed-g6.dtsi or deficient binding definitions for the Aspeed controllers. I've put together a patch stack to clean them up and am working to upstream them. So for now: Reviewed-by: Andrew Jeffery I'll put v5 in a tree for Joel to pick up if he doesn't have any concerns. I'll drop the redundant include when applying the patch there. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel