From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC344E7737B for ; Sat, 30 Sep 2023 17:28:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3CMSsk4wjWyby/2AahuTOajM1WOX0mhvKBJzpVWhjio=; b=NyupHLxAZFX+MF AHpjx+z7FnQjSu6/le3Mj1B5bcddGLt95TqkmMWkFVrrTfLh6MYTjfCHcWgvTv1Ei4IrTXlYjZdAH 7c2BKr5EuJ4jIRwwjqqtv+Xee35F5y7nkkJrgFrCo8PkPRkCssRomdBGGZ3B+J1HRy+OJIO0h8ybP ZgqnNjAsE+6TO5HZjelI4w8JY0JqdFjn+XqMvOuZ/OwOUP/tHlc8ADekVjO9+CN6TWtQBAhOnaVVP s5jFfTGMIf8unhXQI/V1/B6vrChMDANj7FZOfRs0GtojLVvVAZ5vjK+5VC0gnXn0fa2YNHoTiCfBh nqmH0VAajRpfCihDMxmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qmdki-009vwp-2D; Sat, 30 Sep 2023 17:27:40 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qmdkg-009vw6-1u for linux-arm-kernel@lists.infradead.org; Sat, 30 Sep 2023 17:27:39 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-50444e756deso19694391e87.0 for ; Sat, 30 Sep 2023 10:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696094857; x=1696699657; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1esDqgq5T+kok5ueaCGLW9C7Tb/ZQUvYJBezpRqqynU=; b=BfoeBs7LNiieo9FHZdDFcq+J4wTIKhVwaEKL52SBKYRaCSYhU93+K3WDDtCA5F5djh Uv4I78uCKLJGE7h9ktU4Sbf6OGsBpfdRsp3sQUvaDe8mt2pRBsCff38gryJEzxmEt5WM hrYhV31i/xt/7o0hf2KwKNaVy3xLm1RvaaX+1ULIzz4WvmMD7Nvmh6dx1gfenAyPSsPz y6FcjLteSWtvhPBFpFrnqu1gcQOgCrEoXT4mDJgi10Lz5ieCJ2yUY91Oh2yLByhMRMnt M8mIxuvqeml3q1eYOiqN77pAG82lwYr7cYONPvsHkUaVUngO9uu3aSDrj90lZGTyAfRM hY/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696094857; x=1696699657; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1esDqgq5T+kok5ueaCGLW9C7Tb/ZQUvYJBezpRqqynU=; b=i16S8qPcbeqtCjiDyD7/5tpKK+wGZ2pFmypEJ/LQMIZAMqSpRovn25uqmd+p3z/mtc OXvrEdV5RNPpXM9brHAYgFQNscd9DvQrOJTrr0kLB2ZVHuorahZshHQ1vnoVFezoLS7x +mZTkb1OGuxersgSoOLpt3P3fxtcmvrs45nTMSgXvF7CkcDKebLOH/xbwD6+jhrcWge0 rCjmsv94pnbqocHqc3aYuya1MmV5opIht7+iKa4sncsGS1IZ4WGvHAp2LBDmkQd2sbsH 8aCyWNmw5GEwOULkqS92edTDBvyK8VErPkievTmUzy5/rpDq2OEzAxbF5/A/TGo8hi9i EDpQ== X-Gm-Message-State: AOJu0Yw5Dgz/o+9mmPc+6VKg5PyVBm1zWS+T16xF1sX5JP0uGUlWFhMc dK//qI7NyarS4/nw79GJHqLQ3w== X-Google-Smtp-Source: AGHT+IGW8pBqaaoPrjB/MmYzrMfiR0lUdFnOEoGcH/Kv0byQNThkUo9CXJPl8eHVnzwlIQ2tH11BeA== X-Received: by 2002:a05:6512:3902:b0:505:7113:1d12 with SMTP id a2-20020a056512390200b0050571131d12mr3223204lfu.3.1696094857086; Sat, 30 Sep 2023 10:27:37 -0700 (PDT) Received: from [192.168.246.189] (85-76-98-178-nat.elisa-mobile.fi. [85.76.98.178]) by smtp.gmail.com with ESMTPSA id z8-20020ac25de8000000b00500ba43a43asm3994414lfq.86.2023.09.30.10.27.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Sep 2023 10:27:36 -0700 (PDT) Message-ID: Date: Sat, 30 Sep 2023 20:27:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY in USB node Content-Language: en-GB To: Praveenkumar I , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, arnd@arndb.de, neil.armstrong@linaro.org, nfraprado@collabora.com, u-kumar1@ti.com, peng.fan@nxp.com, quic_wcheng@quicinc.com, quic_varada@quicinc.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: quic_kathirav@quicinc.com, quic_nsekar@quicinc.com, quic_srichara@quicinc.com References: <20230929084209.3033093-1-quic_ipkumar@quicinc.com> <20230929084209.3033093-7-quic_ipkumar@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <20230929084209.3033093-7-quic_ipkumar@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230930_102738_629812_534BB51F X-CRM114-Status: GOOD ( 15.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/09/2023 11:42, Praveenkumar I wrote: > Add UNIPHY node in USB to support Super-speed. As the SS PHY has > pipe clock, removed "qcom,select-utmi-as-pipe-clk" flag. > > Signed-off-by: Praveenkumar I > --- > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > index 1813b9fa4bb5..8fe4e45bfc18 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -349,8 +349,6 @@ usb: usb@8af8800 { > > resets = <&gcc GCC_USB_BCR>; > > - qcom,select-utmi-as-pipe-clk; > - > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -363,8 +361,8 @@ usb_dwc: usb@8a00000 { > clocks = <&gcc GCC_USB0_MOCK_UTMI_CLK>; > clock-names = "ref"; > interrupts = ; > - phy-names = "usb2-phy"; > - phys = <&usbphy0>; > + phy-names = "usb2-phy", "usb3-phy"; > + phys = <&usbphy0>, <&usbphy1>; Ah, I see now. Maybe usbphy_ss_0 or something like that would be a better label for this PHY. I'd expect usbphy1 to be used for other host than usbphy0. > tx-fifo-resize; > snps,is-utmi-l1-suspend; > snps,hird-threshold = /bits/ 8 <0x0>; -- With best wishes Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel