From: Krzysztof Kozlowski <krzk@kernel.org>
To: Parvathi Pudi <parvathi@couthit.com>,
nm@ti.com, vigneshr@ti.com, linux@armlinux.org.uk,
ardb@kernel.org, ebiggers@kernel.org, arnd@arndb.de,
geert+renesas@glider.be, tiwai@suse.de,
kory.maincent@bootlin.com, dmitry.baryshkov@oss.qualcomm.com,
prabhakar.mahadev-lad.rj@bp.renesas.com, twoerner@gmail.com
Cc: linux-arm-kernel@lists.infradead.org, pratheesh@ti.com,
j-rameshbabu@ti.com, praneeth@ti.com, srk@ti.com, rogerq@ti.com,
danishanwar@ti.com, m-malladi@ti.com, krishna@couthit.com,
mohan@couthit.com, pmohan@couthit.com, basharath@couthit.com
Subject: Re: [PATCH] arm: multi_v7_defconfig: Enable CONFIG_BRIDGE and CONFIG_DP83848_PHY for TI AM57x, AM437x and AM335x
Date: Sat, 28 Feb 2026 11:02:47 +0100 [thread overview]
Message-ID: <cc704eb9-e581-44c4-a564-5581cc39f27f@kernel.org> (raw)
In-Reply-To: <20260228062109.250794-1-parvathi@couthit.com>
On 28/02/2026 07:21, Parvathi Pudi wrote:
> Enable CONFIG_BRIDGE in multi_v7_defconfig as a module.
> This is to support STP/RSTP Switch mode using PRU-ICSS
> on TI SoCs.
Which boards need it? We don't care for example for downstream TI SoCs.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> Enable CONFIG_DP83848_PHY in multi_v7_defconfig since
> TI TLK10X PHY is used in TI SoCs and the support for
> TLK10X is available in DP83848.
Don't repeat the same twice. Once is enough.
>
> Signed-off-by: Parvathi Pudi <parvathi@couthit.com>
> ---
> arch/arm/configs/multi_v7_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index f75d75cf91c8..f0a2971fb57f 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -281,6 +281,8 @@ CONFIG_TI_KEYSTONE_NETCP=y
> CONFIG_TI_KEYSTONE_NETCP_ETHSS=y
> CONFIG_TI_PRUSS=m
> CONFIG_TI_PRUETH=m
> +CONFIG_BRIDGE=m
I don't see how this is related. Plus none of these two look properly
placed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-28 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 6:21 [PATCH] arm: multi_v7_defconfig: Enable CONFIG_BRIDGE and CONFIG_DP83848_PHY for TI AM57x, AM437x and AM335x Parvathi Pudi
2026-02-28 10:02 ` Krzysztof Kozlowski [this message]
2026-03-06 12:53 ` Parvathi Pudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc704eb9-e581-44c4-a564-5581cc39f27f@kernel.org \
--to=krzk@kernel.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=basharath@couthit.com \
--cc=danishanwar@ti.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=ebiggers@kernel.org \
--cc=geert+renesas@glider.be \
--cc=j-rameshbabu@ti.com \
--cc=kory.maincent@bootlin.com \
--cc=krishna@couthit.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=m-malladi@ti.com \
--cc=mohan@couthit.com \
--cc=nm@ti.com \
--cc=parvathi@couthit.com \
--cc=pmohan@couthit.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=rogerq@ti.com \
--cc=srk@ti.com \
--cc=tiwai@suse.de \
--cc=twoerner@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox