public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] arm: multi_v7_defconfig: Enable CONFIG_BRIDGE and CONFIG_DP83848_PHY for TI AM57x, AM437x and AM335x
@ 2026-02-28  6:21 Parvathi Pudi
  2026-02-28 10:02 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Parvathi Pudi @ 2026-02-28  6:21 UTC (permalink / raw)
  To: nm, vigneshr, linux, ardb, ebiggers, arnd, geert+renesas,
	parvathi, tiwai, kory.maincent, dmitry.baryshkov,
	prabhakar.mahadev-lad.rj, twoerner
  Cc: linux-arm-kernel, pratheesh, j-rameshbabu, praneeth, srk, rogerq,
	danishanwar, m-malladi, krishna, mohan, pmohan, basharath

Enable CONFIG_BRIDGE in multi_v7_defconfig as a module.
This is to support STP/RSTP Switch mode using PRU-ICSS
on TI SoCs.

Enable CONFIG_DP83848_PHY in multi_v7_defconfig since
TI TLK10X PHY is used in TI SoCs and the support for
TLK10X is available in DP83848.

Signed-off-by: Parvathi Pudi <parvathi@couthit.com>
---
 arch/arm/configs/multi_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index f75d75cf91c8..f0a2971fb57f 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -281,6 +281,8 @@ CONFIG_TI_KEYSTONE_NETCP=y
 CONFIG_TI_KEYSTONE_NETCP_ETHSS=y
 CONFIG_TI_PRUSS=m
 CONFIG_TI_PRUETH=m
+CONFIG_BRIDGE=m
+CONFIG_DP83848_PHY=m
 CONFIG_XILINX_EMACLITE=y
 CONFIG_SFP=m
 CONFIG_BROADCOM_PHY=y
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm: multi_v7_defconfig: Enable CONFIG_BRIDGE and CONFIG_DP83848_PHY for TI AM57x, AM437x and AM335x
  2026-02-28  6:21 [PATCH] arm: multi_v7_defconfig: Enable CONFIG_BRIDGE and CONFIG_DP83848_PHY for TI AM57x, AM437x and AM335x Parvathi Pudi
@ 2026-02-28 10:02 ` Krzysztof Kozlowski
  2026-03-06 12:53   ` Parvathi Pudi
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-28 10:02 UTC (permalink / raw)
  To: Parvathi Pudi, nm, vigneshr, linux, ardb, ebiggers, arnd,
	geert+renesas, tiwai, kory.maincent, dmitry.baryshkov,
	prabhakar.mahadev-lad.rj, twoerner
  Cc: linux-arm-kernel, pratheesh, j-rameshbabu, praneeth, srk, rogerq,
	danishanwar, m-malladi, krishna, mohan, pmohan, basharath

On 28/02/2026 07:21, Parvathi Pudi wrote:
> Enable CONFIG_BRIDGE in multi_v7_defconfig as a module.
> This is to support STP/RSTP Switch mode using PRU-ICSS
> on TI SoCs.

Which boards need it? We don't care for example for downstream TI SoCs.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597


> 
> Enable CONFIG_DP83848_PHY in multi_v7_defconfig since
> TI TLK10X PHY is used in TI SoCs and the support for
> TLK10X is available in DP83848.

Don't repeat the same twice. Once is enough.

> 
> Signed-off-by: Parvathi Pudi <parvathi@couthit.com>
> ---
>  arch/arm/configs/multi_v7_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index f75d75cf91c8..f0a2971fb57f 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -281,6 +281,8 @@ CONFIG_TI_KEYSTONE_NETCP=y
>  CONFIG_TI_KEYSTONE_NETCP_ETHSS=y
>  CONFIG_TI_PRUSS=m
>  CONFIG_TI_PRUETH=m
> +CONFIG_BRIDGE=m

I don't see how this is related. Plus none of these two look properly
placed.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm: multi_v7_defconfig: Enable CONFIG_BRIDGE and CONFIG_DP83848_PHY for TI AM57x, AM437x and AM335x
  2026-02-28 10:02 ` Krzysztof Kozlowski
@ 2026-03-06 12:53   ` Parvathi Pudi
  0 siblings, 0 replies; 3+ messages in thread
From: Parvathi Pudi @ 2026-03-06 12:53 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Parvathi Pudi, nm, Vignesh Raghavendra, linux, ardb, ebiggers,
	arnd, geert+renesas, tiwai, kory maincent, dmitry baryshkov,
	prabhakar mahadev-lad rj, twoerner, linux-arm-kernel, pratheesh,
	j-rameshbabu, praneeth, srk, rogerq, danishanwar, m-malladi,
	krishna, mohan, pmohan, basharath

Hi,

> On 28/02/2026 07:21, Parvathi Pudi wrote:
>> Enable CONFIG_BRIDGE in multi_v7_defconfig as a module.
>> This is to support STP/RSTP Switch mode using PRU-ICSS
>> on TI SoCs.
> 
> Which boards need it? We don't care for example for downstream TI SoCs.
> 

This is for AM57xx, AM437x and AM335x boards using PRU-ICSS in switch mode (STP/RSTP).
Since STP/RSTP support has been merged to mainline recently, enabling BRIDGE as a module
allows switch mode to work seamlessly.

We will add the SOC details and post the next version shortly.

> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
> 

Sure, we will address this in the next version.

> 
>> 
>> Enable CONFIG_DP83848_PHY in multi_v7_defconfig since
>> TI TLK10X PHY is used in TI SoCs and the support for
>> TLK10X is available in DP83848.
> 
> Don't repeat the same twice. Once is enough.
> 

We will clean up the commit message, remove the duplication.

>> 
>> Signed-off-by: Parvathi Pudi <parvathi@couthit.com>
>> ---
>>  arch/arm/configs/multi_v7_defconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/arch/arm/configs/multi_v7_defconfig
>> b/arch/arm/configs/multi_v7_defconfig
>> index f75d75cf91c8..f0a2971fb57f 100644
>> --- a/arch/arm/configs/multi_v7_defconfig
>> +++ b/arch/arm/configs/multi_v7_defconfig
>> @@ -281,6 +281,8 @@ CONFIG_TI_KEYSTONE_NETCP=y
>>  CONFIG_TI_KEYSTONE_NETCP_ETHSS=y
>>  CONFIG_TI_PRUSS=m
>>  CONFIG_TI_PRUETH=m
>> +CONFIG_BRIDGE=m
> 
> I don't see how this is related. Plus none of these two look properly
> placed.
> 

We'll fix the config placement and address this in the next version.

Thanks and Regards,
Parvathi.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-06 12:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-28  6:21 [PATCH] arm: multi_v7_defconfig: Enable CONFIG_BRIDGE and CONFIG_DP83848_PHY for TI AM57x, AM437x and AM335x Parvathi Pudi
2026-02-28 10:02 ` Krzysztof Kozlowski
2026-03-06 12:53   ` Parvathi Pudi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox