* [PATCH] drivers: iio: remove dead code in at91_adc_probe
@ 2023-03-09 15:05 Cheng Ziqiu
2023-03-10 9:14 ` Claudiu.Beznea
0 siblings, 1 reply; 5+ messages in thread
From: Cheng Ziqiu @ 2023-03-09 15:05 UTC (permalink / raw)
To: Eugen Hristev, Jonathan Cameron, Lars-Peter Clausen,
Nicolas Ferre, Alexandre Belloni, Claudiu Beznea
Cc: Cheng Ziqiu, Dongliang Mu, linux-iio, linux-arm-kernel,
linux-kernel
From the comment of platform_get_irq, it only returns non-zero IRQ
number and negative error number, other than zero.
Fix this by removing the if condition.
Signed-off-by: Cheng Ziqiu <chengziqiu@hust.edu.cn>
Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
---
drivers/iio/adc/at91-sama5d2_adc.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index 50d02e5fc6fc..168399092590 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev)
st->dma_st.phys_addr = res->start;
st->irq = platform_get_irq(pdev, 0);
- if (st->irq <= 0) {
- if (!st->irq)
- st->irq = -ENXIO;
-
+ if (st->irq < 0)
return st->irq;
- }
st->per_clk = devm_clk_get(&pdev->dev, "adc_clk");
if (IS_ERR(st->per_clk))
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: iio: remove dead code in at91_adc_probe
2023-03-09 15:05 [PATCH] drivers: iio: remove dead code in at91_adc_probe Cheng Ziqiu
@ 2023-03-10 9:14 ` Claudiu.Beznea
2023-03-10 9:41 ` 慕冬亮
0 siblings, 1 reply; 5+ messages in thread
From: Claudiu.Beznea @ 2023-03-10 9:14 UTC (permalink / raw)
To: chengziqiu, eugen.hristev, jic23, lars, Nicolas.Ferre,
alexandre.belloni
Cc: dzm91, linux-iio, linux-arm-kernel, linux-kernel
On 09.03.2023 17:05, Cheng Ziqiu wrote:
>>From the comment of platform_get_irq, it only returns non-zero IRQ
> number and negative error number, other than zero.
>
> Fix this by removing the if condition.
>
> Signed-off-by: Cheng Ziqiu <chengziqiu@hust.edu.cn>
I see From and 1st SoB matches but
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
this SoB seems extra. What is the contribution of Dongliang Mu to this patch?
> ---
> drivers/iio/adc/at91-sama5d2_adc.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index 50d02e5fc6fc..168399092590 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev)
> st->dma_st.phys_addr = res->start;
>
> st->irq = platform_get_irq(pdev, 0);
> - if (st->irq <= 0) {
> - if (!st->irq)
> - st->irq = -ENXIO;
> -
> + if (st->irq < 0)
> return st->irq;
> - }
>
> st->per_clk = devm_clk_get(&pdev->dev, "adc_clk");
> if (IS_ERR(st->per_clk))
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Re: [PATCH] drivers: iio: remove dead code in at91_adc_probe
2023-03-10 9:14 ` Claudiu.Beznea
@ 2023-03-10 9:41 ` 慕冬亮
2023-03-10 9:55 ` Claudiu.Beznea
0 siblings, 1 reply; 5+ messages in thread
From: 慕冬亮 @ 2023-03-10 9:41 UTC (permalink / raw)
To: claudiu.beznea
Cc: alexandre.belloni, lars, linux-iio, eugen.hristev, linux-kernel,
chengziqiu, linux-arm-kernel, jic23
> -----原始邮件-----
> 发件人: Claudiu.Beznea@microchip.com
> 发送时间: 2023-03-10 17:14:56 (星期五)
> 收件人: chengziqiu@hust.edu.cn, eugen.hristev@collabora.com, jic23@kernel.org, lars@metafoo.de, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com
> 抄送: dzm91@hust.edu.cn, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> 主题: Re: [PATCH] drivers: iio: remove dead code in at91_adc_probe
>
> On 09.03.2023 17:05, Cheng Ziqiu wrote:
> >>From the comment of platform_get_irq, it only returns non-zero IRQ
> > number and negative error number, other than zero.
> >
> > Fix this by removing the if condition.
> >
> > Signed-off-by: Cheng Ziqiu <chengziqiu@hust.edu.cn>
>
> I see From and 1st SoB matches but
>
> > Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
>
> this SoB seems extra. What is the contribution of Dongliang Mu to this patch?
I reviewed this patch locally since this student is the first time to submit patch to the kernel mailing list.
In my lab, I encourage all students to fix kernel issues. However, their patches should be reviewed by me first before sending the mailing list.
>
> > ---
> > drivers/iio/adc/at91-sama5d2_adc.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> > index 50d02e5fc6fc..168399092590 100644
> > --- a/drivers/iio/adc/at91-sama5d2_adc.c
> > +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> > @@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev)
> > st->dma_st.phys_addr = res->start;
> >
> > st->irq = platform_get_irq(pdev, 0);
> > - if (st->irq <= 0) {
> > - if (!st->irq)
> > - st->irq = -ENXIO;
> > -
> > + if (st->irq < 0)
> > return st->irq;
> > - }
> >
> > st->per_clk = devm_clk_get(&pdev->dev, "adc_clk");
> > if (IS_ERR(st->per_clk))
> > --
> > 2.34.1
> >
>
--
Best regards,
Dongliang Mu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: iio: remove dead code in at91_adc_probe
2023-03-10 9:41 ` 慕冬亮
@ 2023-03-10 9:55 ` Claudiu.Beznea
2023-03-10 9:58 ` Dongliang Mu
0 siblings, 1 reply; 5+ messages in thread
From: Claudiu.Beznea @ 2023-03-10 9:55 UTC (permalink / raw)
To: dzm91
Cc: alexandre.belloni, lars, linux-iio, eugen.hristev, linux-kernel,
chengziqiu, linux-arm-kernel, jic23
On 10.03.2023 11:41, 慕冬亮 wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> -----原始邮件-----
>> 发件人: Claudiu.Beznea@microchip.com
>> 发送时间: 2023-03-10 17:14:56 (星期五)
>> 收件人: chengziqiu@hust.edu.cn, eugen.hristev@collabora.com, jic23@kernel.org, lars@metafoo.de, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com
>> 抄送: dzm91@hust.edu.cn, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
>> 主题: Re: [PATCH] drivers: iio: remove dead code in at91_adc_probe
>>
>> On 09.03.2023 17:05, Cheng Ziqiu wrote:
>>> >From the comment of platform_get_irq, it only returns non-zero IRQ
>>> number and negative error number, other than zero.
>>>
>>> Fix this by removing the if condition.
>>>
>>> Signed-off-by: Cheng Ziqiu <chengziqiu@hust.edu.cn>
>>
>> I see From and 1st SoB matches but
>>
>>> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
>>
>> this SoB seems extra. What is the contribution of Dongliang Mu to this patch?
>
> I reviewed this patch locally since this student is the first time to submit patch to the kernel mailing list.
Then please use "Reviewed-by" tag.
>
> In my lab, I encourage all students to fix kernel issues. However, their patches should be reviewed by me first before sending the mailing list.
>
>>
>>> ---
>>> drivers/iio/adc/at91-sama5d2_adc.c | 6 +-----
>>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
>>> index 50d02e5fc6fc..168399092590 100644
>>> --- a/drivers/iio/adc/at91-sama5d2_adc.c
>>> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
>>> @@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev)
>>> st->dma_st.phys_addr = res->start;
>>>
>>> st->irq = platform_get_irq(pdev, 0);
>>> - if (st->irq <= 0) {
>>> - if (!st->irq)
>>> - st->irq = -ENXIO;
>>> -
>>> + if (st->irq < 0)
>>> return st->irq;
>>> - }
>>>
>>> st->per_clk = devm_clk_get(&pdev->dev, "adc_clk");
>>> if (IS_ERR(st->per_clk))
>>> --
>>> 2.34.1
>>>
>>
>
>
> --
> Best regards,
> Dongliang Mu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: iio: remove dead code in at91_adc_probe
2023-03-10 9:55 ` Claudiu.Beznea
@ 2023-03-10 9:58 ` Dongliang Mu
0 siblings, 0 replies; 5+ messages in thread
From: Dongliang Mu @ 2023-03-10 9:58 UTC (permalink / raw)
To: Claudiu.Beznea
Cc: alexandre.belloni, lars, linux-iio, eugen.hristev, linux-kernel,
chengziqiu, linux-arm-kernel, jic23
On 3/10/23 17:55, Claudiu.Beznea@microchip.com wrote:
> On 10.03.2023 11:41, 慕冬亮 wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>>> -----原始邮件-----
>>> 发件人: Claudiu.Beznea@microchip.com
>>> 发送时间: 2023-03-10 17:14:56 (星期五)
>>> 收件人: chengziqiu@hust.edu.cn, eugen.hristev@collabora.com, jic23@kernel.org, lars@metafoo.de, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com
>>> 抄送: dzm91@hust.edu.cn, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
>>> 主题: Re: [PATCH] drivers: iio: remove dead code in at91_adc_probe
>>>
>>> On 09.03.2023 17:05, Cheng Ziqiu wrote:
>>>> >From the comment of platform_get_irq, it only returns non-zero IRQ
>>>> number and negative error number, other than zero.
>>>>
>>>> Fix this by removing the if condition.
>>>>
>>>> Signed-off-by: Cheng Ziqiu <chengziqiu@hust.edu.cn>
>>>
>>> I see From and 1st SoB matches but
>>>
>>>> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
>>>
>>> this SoB seems extra. What is the contribution of Dongliang Mu to this patch?
>>
>> I reviewed this patch locally since this student is the first time to submit patch to the kernel mailing list.
>
> Then please use "Reviewed-by" tag.
Sure. I will ask him to send a v2 patch.
>
>>
>> In my lab, I encourage all students to fix kernel issues. However, their patches should be reviewed by me first before sending the mailing list.
>>
>>>
>>>> ---
>>>> drivers/iio/adc/at91-sama5d2_adc.c | 6 +-----
>>>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>>>
>>>> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
>>>> index 50d02e5fc6fc..168399092590 100644
>>>> --- a/drivers/iio/adc/at91-sama5d2_adc.c
>>>> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
>>>> @@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev)
>>>> st->dma_st.phys_addr = res->start;
>>>>
>>>> st->irq = platform_get_irq(pdev, 0);
>>>> - if (st->irq <= 0) {
>>>> - if (!st->irq)
>>>> - st->irq = -ENXIO;
>>>> -
>>>> + if (st->irq < 0)
>>>> return st->irq;
>>>> - }
>>>>
>>>> st->per_clk = devm_clk_get(&pdev->dev, "adc_clk");
>>>> if (IS_ERR(st->per_clk))
>>>> --
>>>> 2.34.1
>>>>
>>>
>>
>>
>> --
>> Best regards,
>> Dongliang Mu
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-10 10:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-09 15:05 [PATCH] drivers: iio: remove dead code in at91_adc_probe Cheng Ziqiu
2023-03-10 9:14 ` Claudiu.Beznea
2023-03-10 9:41 ` 慕冬亮
2023-03-10 9:55 ` Claudiu.Beznea
2023-03-10 9:58 ` Dongliang Mu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).