Re: [PATCH v5 1/2] arm64: perf: Add support caps in sysfs

[Shaokun Zhang <zhangshaokun@hisilicon.com>]

Hi Mark,

在 2020/7/21 20:17, Mark Rutland 写道:
> On Tue, Jul 21, 2020 at 06:49:32PM +0800, Shaokun Zhang wrote:
>> ARMv8.4-PMU introduces the PMMIR_EL1 registers and some new PMU events,
>> like STALL_SLOT etc, are related to it. Let's add a caps directory to
>> /sys/bus/event_source/devices/armv8_pmuv3_0/ and support slots from
>> PMMIR_EL1 registers in this entry. The user programs can get the slots
>> from sysfs directly.
>>
>> Cc: Will Deacon <will@kernel.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> 
> [...]
> 
>> +static int armv8pmu_get_pmu_version(void)
>> +{
>> +	int pmuver;
>> +	u64 dfr0;
>> +
>> +	dfr0 = read_sysreg(id_aa64dfr0_el1);
>> +	pmuver = cpuid_feature_extract_unsigned_field(dfr0,
>> +			ID_AA64DFR0_PMUVER_SHIFT);
>> +
>> +	return pmuver;
>> +}
>> +
>> +static umode_t
>> +armv8pmu_caps_attr_is_visible(struct kobject *kobj, struct attribute *attr,
>> +			      int unused)
>> +{
>> +	int pmuver = armv8pmu_get_pmu_version();
>> +	u32 pmceid1 = read_sysreg(pmceid1_el0);
>> +
>> +	/* Check the PMU version is >= v8.4 and STALL_SLOT is implemented */
>> +	if (pmuver >= ID_AA64DFR0_PMUVER_8_4 && (pmceid1 & BIT(31)))
>> +		return attr->mode;
>> +
>> +	return 0;
>> +}
>> +
>> +static ssize_t slots_show(struct device *dev, struct device_attribute *attr,
>> +			  char *buf)
>> +{
>> +	int slots = read_sysreg_s(SYS_PMMIR_EL1) & 0xFF;
>> +
>> +	return snprintf(buf, PAGE_SIZE, "%d\n", slots);
>> +}
> 
> You'll need to use the snapshots of these fields we take at probe time;

Ok,

> it's not safe to use read_sysreg() here as on a system with
> heterogeneous CPUs this code can be running on one CPU while it's

Apologies, I did not realize it at the beginning and will fix it in next
version.

Thanks,
Shaokun

> printing information for another CPU.
> 
> Mark.
> 
> .
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel