From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Nishanth Menon <nm@ti.com>, Benoit Parrot <bparrot@ti.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Tony Lindgren <tony@atomide.com>, Pratyush Yadav <p.yadav@ti.com>
Subject: Re: [PATCH 1/2] ARM: dts: dra76-evm: remove ov5640
Date: Mon, 12 Apr 2021 11:26:16 +0300 [thread overview]
Message-ID: <cca8ba39-d1b2-0022-15ad-e0126ee1a8cb@ideasonboard.com> (raw)
In-Reply-To: <YHP+GDq2omVJwCfq@pendragon.ideasonboard.com>
On 12/04/2021 11:00, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Mon, Apr 12, 2021 at 10:53:05AM +0300, Tomi Valkeinen wrote:
>> DRA76 EVM boards are not shipped with OV5640 sensor module, it is a
>> separate purchase. OV5640 module is also just one of the possible
>> sensors or capture boards you can connect.
>>
>> However, for some reason, OV5640 has been added to the board dts file,
>> making it cumbersome to use other sensors.
>>
>> Remove the OV5640 from the dts file so that it is easy to use other
>> sensors via DT overlays.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>> ---
>> arch/arm/boot/dts/dra76-evm.dts | 27 ---------------------------
>> 1 file changed, 27 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/dra76-evm.dts b/arch/arm/boot/dts/dra76-evm.dts
>> index 9bd01ae40b1d..f3c900e1b953 100644
>> --- a/arch/arm/boot/dts/dra76-evm.dts
>> +++ b/arch/arm/boot/dts/dra76-evm.dts
>> @@ -158,12 +158,6 @@ aic_dvdd: fixedregulator-aic_dvdd {
>> regulator-max-microvolt = <1800000>;
>> };
>>
>> - clk_ov5640_fixed: clock {
>> - compatible = "fixed-clock";
>> - #clock-cells = <0>;
>> - clock-frequency = <24000000>;
>> - };
>> -
>> hdmi0: connector {
>> compatible = "hdmi-connector";
>> label = "hdmi";
>> @@ -409,22 +403,6 @@ tlv320aic3106: tlv320aic3106@19 {
>> &i2c5 {
>> status = "okay";
>> clock-frequency = <400000>;
>> -
>> - ov5640@3c {
>> - compatible = "ovti,ov5640";
>> - reg = <0x3c>;
>> -
>> - clocks = <&clk_ov5640_fixed>;
>> - clock-names = "xclk";
>> -
>> - port {
>> - csi2_cam0: endpoint {
>> - remote-endpoint = <&csi2_phy0>;
>> - clock-lanes = <0>;
>> - data-lanes = <1 2>;
>> - };
>> - };
>> - };
>> };
>
> You could drop the node completely.
>
>>
>> &cpu0 {
>> @@ -574,11 +552,6 @@ can-transceiver {
>> };
>>
>> &csi2_0 {
>> - csi2_phy0: endpoint {
>> - remote-endpoint = <&csi2_cam0>;
>> - clock-lanes = <0>;
>> - data-lanes = <1 2>;
>> - };
>> };
>
> And here too.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Is there an overlay available somewhere for this ?
I have a work branch for dra76 and am654 overlays for TI's DT overlay tree:
https://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux-dt.git/commit/?h=multistream/work&id=c997e4854164cbfcf11174e9c7d012967b6f399d
https://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux-dt.git/commit/?h=multistream/work&id=311bdaaa28ba16b0142f5879fc7c79aa3aa5906d
I have not sent these to TI yet.
Tomi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-04-12 8:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 7:53 [PATCH 1/2] ARM: dts: dra76-evm: remove ov5640 Tomi Valkeinen
2021-04-12 7:53 ` [PATCH 2/2] arm64: dts: ti: k3-am654-base-board: " Tomi Valkeinen
2021-04-12 8:00 ` Laurent Pinchart
2021-04-12 8:36 ` Pratyush Yadav
2021-04-12 9:15 ` Tomi Valkeinen
2021-04-12 9:26 ` Vignesh Raghavendra
2021-04-12 14:03 ` Nishanth Menon
2021-04-12 8:00 ` [PATCH 1/2] ARM: dts: dra76-evm: " Laurent Pinchart
2021-04-12 8:26 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cca8ba39-d1b2-0022-15ad-e0126ee1a8cb@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nm@ti.com \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).