From: Krzysztof Kozlowski <krzk@kernel.org>
To: Weigang He <geoffreyhe2@gmail.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] soc: samsung: exynos-pmu: fix of_node refcount leak in exynos_get_pmu_regmap()
Date: Tue, 9 Jun 2026 15:44:55 +0200 [thread overview]
Message-ID: <ccade938-7626-4d9d-87dc-875854b76ae9@kernel.org> (raw)
In-Reply-To: <20260609133320.1748882-1-geoffreyhe2@gmail.com>
On 09/06/2026 15:33, Weigang He wrote:
> drivers/soc/samsung/exynos-pmu.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
> index d58376c38179b..265a095316079 100644
> --- a/drivers/soc/samsung/exynos-pmu.c
> +++ b/drivers/soc/samsung/exynos-pmu.c
> @@ -167,11 +167,13 @@ static const struct mfd_cell exynos_pmu_devs[] = {
> */
> struct regmap *exynos_get_pmu_regmap(void)
> {
> - struct device_node *np = of_find_matching_node(NULL,
> - exynos_pmu_of_device_ids);
> - if (np)
> - return exynos_get_pmu_regmap_by_phandle(np, NULL);
> - return ERR_PTR(-ENODEV);
> + struct device_node *np __free(device_node) =
> + of_find_matching_node(NULL, exynos_pmu_of_device_ids);
> +
> + if (!np)
> + return ERR_PTR(-ENODEV);
> +
> + return exynos_get_pmu_regmap_by_phandle(np, NULL);
I don't understand why do you need to change the rest of the function.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-06-09 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 13:33 [PATCH v2] soc: samsung: exynos-pmu: fix of_node refcount leak in exynos_get_pmu_regmap() Weigang He
2026-06-09 13:44 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccade938-7626-4d9d-87dc-875854b76ae9@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=geoffreyhe2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox